From: Neil Armstrong <neil.armstrong@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Kevin Hilman <khilman@baylibre.com>, Da Xue <da.xue@libretech.co>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: amlogic: cottonwood: fix blue/green led inversion
Date: Fri, 6 Oct 2023 16:46:04 +0200 [thread overview]
Message-ID: <bf5e3789-8ca3-4347-95c3-278aa1e65be5@linaro.org> (raw)
In-Reply-To: <20231006141915.3623097-1-jbrunet@baylibre.com>
On 06/10/2023 16:19, Jerome Brunet wrote:
> While making the v2, blue and green LED pwms got inverted
> This change fixes the problem
>
> Fixes: 9f841514c9c2 ("arm64: dts: amlogic: add libretech cottonwood support")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
> index ed826f673349..35e8f5bae990 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
> @@ -70,7 +70,7 @@ led {
> function = LED_FUNCTION_ACTIVITY;
> linux,default-trigger = "heartbeat";
> max-brightness = <255>;
> - pwms = <&pwm_cd 1 1250 0>;
> + pwms = <&pwm_ab 1 1250 0>;
> active-low;
> };
> };
> @@ -83,7 +83,7 @@ led {
> function = LED_FUNCTION_STATUS;
> linux,default-trigger = "default-on";
> max-brightness = <255>;
> - pwms = <&pwm_ab 1 1250 0>;
> + pwms = <&pwm_cd 1 1250 0>;
> active-low;
> };
> };
Squashed into 9f841514c9c2 ("arm64: dts: amlogic: add libretech cottonwood support")
Thanks,
Neil
prev parent reply other threads:[~2023-10-06 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 14:19 Jerome Brunet
2023-10-06 14:46 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf5e3789-8ca3-4347-95c3-278aa1e65be5@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=da.xue@libretech.co \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®