From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Rob Clark <robdclark@chromium.org>,
Akhil P Oommen <quic_akhilpo@quicinc.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Vladimir Lypak <vladimir.lypak@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
Chia-I Wu <olvaffe@gmail.com>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] drm/msm: Hangcheck progress detection
Date: Thu, 3 Nov 2022 02:26:20 +0300 [thread overview]
Message-ID: <bf5fb954-c71b-f02f-5300-4e030b10811a@linaro.org> (raw)
In-Reply-To: <20221101223319.165493-3-robdclark@gmail.com>
On 02/11/2022 01:33, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> If the hangcheck timer expires, check if the fw's position in the
> cmdstream has advanced (changed) since last timer expiration, and
> allow it up to three additional "extensions" to it's alotted time.
> The intention is to continue to catch "shader stuck in a loop" type
> hangs quickly, but allow more time for things that are actually
> making forward progress.
Just out of curiosity: wouldn't position also change for a 'shader stuck
in a loop'?
> Because we need to sample the CP state twice to detect if there has
> not been progress, this also cuts the the timer's duration in half.
>
> v2: Fix typo (REG_A6XX_CP_CSQ_IB2_STAT), add comment
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-11-02 23:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 22:33 [PATCH v2 0/2] drm/msm: Improved hang detection Rob Clark
2022-11-01 22:33 ` [PATCH v2 1/2] drm/msm/adreno: Simplify read64/write64 helpers Rob Clark
2022-11-01 22:33 ` [PATCH v2 2/2] drm/msm: Hangcheck progress detection Rob Clark
2022-11-02 23:26 ` Dmitry Baryshkov [this message]
2022-11-03 14:25 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf5fb954-c71b-f02f-5300-4e030b10811a@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olvaffe@gmail.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=vladimir.lypak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®