From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A6D027E056 for ; Mon, 5 Jan 2026 07:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767597679; cv=none; b=MXnyBikp1WVM2DTw7nlAv/yo/Te62GcZNnXiWO77TCceWR8NxYDMrWDStFlvGL+osSUvx1o2mPGtyYuO7yZi67cCNS7AfgdA9ldEDwQ9pgin+a44d6HoGmYqqLqy3ea4JIl7TnevRUojvooTYHmPfIblSDagNi0ls32A9Tdr7zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767597679; c=relaxed/simple; bh=Q9fUcBP8YjPUKrNYmKrrs1nQiSNlglzUEHd/A6jOgpA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S3TF9IDS2XHUguXa8VS6sciKdWx1SFO9h+aOv08ZuXfm3y977TwSEauQQtC8vIY8Bky1VmXPPl5QUB9kou+e9cgBRQ4LIxTSSw2zuNua3BqaHnU5sE8yD8J6mo31m6ZzuPwoOEAOWUhSMSMn73iuWTtVxO2uBMEKuvTwMRBtjyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JX9djdWB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WKQGA7+M; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JX9djdWB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WKQGA7+M" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6055ZTLQ4031720 for ; Mon, 5 Jan 2026 07:21:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WtQReFN9My29FPdkv/q1sjeQWhd2NDf7z17BNmHNNPs=; b=JX9djdWBtaIH/cN4 yXhT5rEltFkPnYKCrqSDbEJP9fozBKpa/eCMOqZVgP6Qsj1Y3wrvB8xch3uSWObw ClE4NfR3qstOYHBl2Js98ohreHKoYTwK5AeqHvJ5gg1i3OhWslHOmAGzyWYfM4yX bHo0rT+D9qEJaOxsU9bAKxweMJWgkRaBV1p+0+pHVObc5O8bu5Vi3QkQrbWP3zlh MT6uxo2Z/Z/VzI8so/2jRfKG1WIv7jh/efA2Bo8NVq1XXHX7DrJhjTgMAJQaF8s5 Ik+q7pd5s9/yOUysfA251Bv65G4ofP8RRRphKZVRdvhMWHh1kHYRUlBj9KhKi50+ zALnyQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bg79ng9w2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 05 Jan 2026 07:21:16 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b90740249dso24445072b3a.0 for ; Sun, 04 Jan 2026 23:21:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767597676; x=1768202476; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WtQReFN9My29FPdkv/q1sjeQWhd2NDf7z17BNmHNNPs=; b=WKQGA7+MZTG4Fy4toVW/1EwSiSVyJUYl3gA0Mw1hEj3LvTxvgdscvhAkF62aFdYvqD LuV1c//lXI4D4a72Vni75aG/v/JsCAg38vOHxERT2weVMcijQhKAK7ceDH21cziJcAz6 zlLMzCMZeRmgmqhtDaOe4q0c+9Nj010d/ku4oCf03JWgfOZGChSWeD2H09s/u1q/UHf1 W1/PVtn0LdND6ETacPYToVsyx3YYLKd8HtG67tbv7td/Q5BhhETwdRrOIYOwUOlQEP+L hltfaY3AafnnWzEZP/6eCaIjkXZmhhWJnAwhxAOM9tPh+ZPO5FRN90hCiJLH1hmMR5j6 ZeWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767597676; x=1768202476; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WtQReFN9My29FPdkv/q1sjeQWhd2NDf7z17BNmHNNPs=; b=pG1tSV3xlz0nLRH2DWqAgUHrC9OuzmaPNgq41Z2CUPu5xqu/bR3dTK466OWLrzwp3W b/l+cYmBu1dy3927UYBI5wsgZLer8JvmHrAgk6gpMKSJS9gbjtiQRogqMMo/M+Gerbgh 1jA7H6ZVRqsklr2MNdzlNYbQ3dDUACXc9MexkUh3Fga2wSZjn3diFBViouFc7YI4awrW x1ZHFXj2q33sMygL6lpuvbHsZZxP/9wPtces7pn4Wzio5XbubieB4lC1yjhoY3ZmOUP+ y9PwMzTeTLVvPnPakQIkipvQ+z6MBPtCru/BOFGrnscb6cqKUu9HdwCsYoLSIXCNM9U0 VGbA== X-Forwarded-Encrypted: i=1; AJvYcCVYcDksJyHIWjCtESlAneKuI48IGLaz34OOs/mecX4lxNnkXvDh8WU0NDKvSVUDi7E5cv/rYYEz5TUfPoA=@vger.kernel.org X-Gm-Message-State: AOJu0YxM4BGTHpNmuAESe+ybHvA+3vSiyyai8Jk5ZDMaslhsYEdFbS0e Azn2QXj1zqw/WSNW2yjm5Qrv0+vrlFaLuEKQf1oLKEfurWH4K/WDfih/TXVAldRPf+fR52g5dji Ocy2LAhCg5n9n1T0vH6xU+bYpGoWpbN5qKpTZWedGOtIAUh/OkT2gBZWSZ0EcdbNkPig= X-Gm-Gg: AY/fxX7yOVv2uJfBDX8/42ML5+hYlHiiZkaoVSjc+JZGt+WrTX8YvcRsWwv7CEX5sS2 beepd8os36Ft8orV8IUiTQxAbZd5ez96Bd3o3PJlvmBeMsjQNJlBi02sL95sK4TsnHiDO64h+uE 9jxVFjIRFHp3U8CPC1RjGtBpWSfubUQc4+CFjlULmWiLXik38Z1US+JEQRJIcGvhAT15+pA/kJu aexyz+huO9hDdPJX2JN68YQYAOVXmROnh64mY8hdHMX08IUCoTud5TZZk/kVT0XdpUgx+fUOvDp FhTe/F2+DmSOAeGfLSIeZyAPfgVYcR9Jx4QTJXk2KRA8fYzAlFwQj7I3LTompQEgAtVcck3yIaJ 1VDjHnp+BC4nPrGROKOyatwXiFfsYIxqK2diisMalItbX X-Received: by 2002:a05:6a00:44cb:b0:7e8:450c:61b4 with SMTP id d2e1a72fcca58-7ff6607cfb4mr37312033b3a.36.1767597676005; Sun, 04 Jan 2026 23:21:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHw4Tmcr2OP7fseCNIxK8T3ePllQcqGwhtVRopMyrwyavAtC32anSV8EZ4ZVYurNUGM/JJETA== X-Received: by 2002:a05:6a00:44cb:b0:7e8:450c:61b4 with SMTP id d2e1a72fcca58-7ff6607cfb4mr37312010b3a.36.1767597675512; Sun, 04 Jan 2026 23:21:15 -0800 (PST) Received: from [192.168.0.171] ([49.205.248.148]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7af2ddf2sm47130415b3a.19.2026.01.04.23.21.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jan 2026 23:21:14 -0800 (PST) Message-ID: Date: Mon, 5 Jan 2026 12:51:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: agatti: Fix IOMMU DT properties To: Sumit Garg Cc: Sumit Garg , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, akhilpo@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, robin.clark@oss.qualcomm.com, lumag@kernel.org, linux-kernel@vger.kernel.org, Prakash Gupta References: <20251229070712.456138-1-sumit.garg@oss.qualcomm.com> <5fdf6122-3c2b-44fb-b8ea-9e554208a56d@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: lwdYMz3vynODApnGTS7IcVotg3MRxGN0 X-Proofpoint-ORIG-GUID: lwdYMz3vynODApnGTS7IcVotg3MRxGN0 X-Authority-Analysis: v=2.4 cv=Y8P1cxeN c=1 sm=1 tr=0 ts=695b666d cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=IiibPKZ/S6LkjEaqkWskKw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=PTQFZ5kuHX2ljL7qyYAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDA2NSBTYWx0ZWRfX5ZBhVHmvEwiK ng3QwOS3LXqwmJyDi8gdU+9AHkhjnLehi5ero1svOKr9MtA37KRif2yUyvGDIy9CmLADrOhuEk2 4IzsznesNiFUwG+rQn4OzbAeRcWyetTdvV/ZqFkfaoRMU0Tn47Go6VrPJZJWWdmBX+JqLcauNS2 5Wv4lWzaunQl4UqOW/xU9VkL/HcZbU3DCeoFjN3ddo57prj9uM3OKv4+D/ALUGt84xWhHJsDOFG IgKikXbVr2v6ejnzSHa/973fjPKrmLozOQCnUbEqwHSUno8B/n4Slh3UUfqIMVR3KmGgpTPoxkI PUEqmFPxcEsnhu4ewa+UN+kJ+CShrTH5Twc8ihil8MTVWH7d3dAgXiInMr/fGCetb4d+/Xvu6fL okPlFsEjHB05MmEBsRGSwKDss6M6FD5H/DXz0g6Lp0MQLpX6Jn/DhakUX2Ezr8wJOyf3l+2xvJI +v6XiMRan02m+n6qytA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601050065 Hi Sumit, On 1/2/2026 5:22 PM, Sumit Garg wrote: > On Fri, Jan 02, 2026 at 03:32:57PM +0530, Vikash Garodia wrote: >> >> On 12/29/2025 12:50 PM, Sumit Garg wrote: >>> Hey Everyone, >>> >>> On Mon, Dec 29, 2025 at 12:37 PM Sumit Garg wrote: >>>> >>>> Fix IOMMU DT propeties for GPU, display and video peripherals via >>>> dropping SMMU stream IDs which relates to secure context bank. >>>> >>>> This problem only surfaced when the Gunyah based firmware stack is >>>> ported on Agatti replacing the legacy QHEE based firmware stack. Assigning >>>> Linux kernel (HLOS) VMID to secure context bank stream IDs is treated >>>> as a fault by Gunyah hypervisor which were previously ignored by QHEE >>>> hypervisor. >>>> >>>> The DT changes should be backwards compatible with legacy QHEE based >>>> firmware stack too. >>>> >>>> Suggested-by: Prakash Gupta >>>> Signed-off-by: Sumit Garg >>>> --- >>>> arch/arm64/boot/dts/qcom/agatti.dtsi | 11 +++-------- >>>> 1 file changed, 3 insertions(+), 8 deletions(-) >>>> >>> >>> Looks like I messed up this patch-set with email delivery leading to >>> non-delivery. I resent it properly again here [1]. Apologies for the >>> noise. >>> >>> [1] https://lore.kernel.org/lkml/20251229070712.456138-1-sumit.garg@oss.qualcomm.com/ >>> >>> -Sumit >>> >>>> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi >>>> index 8bf5c5583fc2..e705eb24160a 100644 >>>> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi >>>> @@ -1613,8 +1613,7 @@ gpu: gpu@5900000 { >>>> &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>; >>>> interconnect-names = "gfx-mem"; >>>> >>>> - iommus = <&adreno_smmu 0 1>, >>>> - <&adreno_smmu 2 0>; >>>> + iommus = <&adreno_smmu 0 1>; >>>> operating-points-v2 = <&gpu_opp_table>; >>>> power-domains = <&rpmpd QCM2290_VDDCX>; >>>> qcom,gmu = <&gmu_wrapper>; >>>> @@ -1895,8 +1894,7 @@ mdss: display-subsystem@5e00000 { >>>> >>>> power-domains = <&dispcc MDSS_GDSC>; >>>> >>>> - iommus = <&apps_smmu 0x420 0x2>, >>>> - <&apps_smmu 0x421 0x0>; >>>> + iommus = <&apps_smmu 0x420 0x2>; >>>> interconnects = <&mmrt_virt MASTER_MDP0 RPM_ALWAYS_TAG >>>> &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>, >>>> <&bimc MASTER_APPSS_PROC RPM_ALWAYS_TAG >>>> @@ -2339,10 +2337,7 @@ venus: video-codec@5a00000 { >>>> >>>> memory-region = <&pil_video_mem>; >>>> iommus = <&apps_smmu 0x860 0x0>, >>>> - <&apps_smmu 0x880 0x0>, >>>> - <&apps_smmu 0x861 0x04>, >>>> - <&apps_smmu 0x863 0x0>, >>>> - <&apps_smmu 0x804 0xe0>; >>>> + <&apps_smmu 0x880 0x0>; >> >> Are you planning to update the binding [1] with this change ? > > Yeah I am planning to update bindings as per changes posted here [1]. I tried a similar approach for the very same usecase [1], and what i learnt is that we cannot describe a range of iommus given the fact that there is no hardware which exist with *min* count of iommus interface. It is suppose to be a fixed number of iommus interface, OR i interpreted it differently then ? [1] https://lore.kernel.org/all/20251017-knp_video-v2-1-f568ce1a4be3@oss.qualcomm.com/ > >> If so, how to >> handle the case of iommus for gunyah based vs non-gunyah based ? > > Currently Agatti doesn't have any support for Linux running in EL2. This > patch-set is just trying to enable Gunyah based stack. > > [1] https://lore.kernel.org/all/aVOFL3jmNrFNiYV0@sumit-xelite/ > > -Sumit