From: Guenter Roeck <linux@roeck-us.net>
To: Andrej Picej <andrej.picej@norik.com>,
wim@linux-watchdog.org, linux-watchdog@vger.kernel.org
Cc: y.bas@phytec.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: da9063: Add hard dependency on I2C
Date: Mon, 29 Nov 2021 07:13:56 -0800 [thread overview]
Message-ID: <bf64b71b-41c1-7a44-9583-c29887bea70b@roeck-us.net> (raw)
In-Reply-To: <20211129134938.3273289-1-andrej.picej@norik.com>
On 11/29/21 5:49 AM, Andrej Picej wrote:
> Commit 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in
> reset handler") implements atomic save i2c transfer which uses i2c
> functions directly. Add I2C hard dependency which overrides COMPILE_TEST.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in reset handler")
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9d222ba17ec6..3207085f799f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -207,6 +207,7 @@ config DA9055_WATCHDOG
> config DA9063_WATCHDOG
> tristate "Dialog DA9063 Watchdog"
> depends on MFD_DA9063 || COMPILE_TEST
> + depends on I2C
> select WATCHDOG_CORE
> help
> Support for the watchdog in the DA9063 PMIC.
>
next prev parent reply other threads:[~2021-11-29 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 13:49 Andrej Picej
2021-11-29 15:13 ` Guenter Roeck [this message]
2021-11-29 15:32 Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf64b71b-41c1-7a44-9583-c29887bea70b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrej.picej@norik.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
--cc=y.bas@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®