From: Helge Deller <deller@gmx.de>
To: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Cc: niederp@physik.uni-kl.de, tomi.valkeinen@ti.com,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fbdev: ssd1307fb: fix potential page leak in ssd1307fb_probe()
Date: Fri, 5 Dec 2025 11:32:27 +0100 [thread overview]
Message-ID: <bf69bf02-35f1-493f-84d7-957f25b38b4c@gmx.de> (raw)
In-Reply-To: <20251203035546.26849-1-nihaal@cse.iitm.ac.in>
On 12/3/25 04:55, Abdun Nihaal wrote:
> The page allocated for vmem using __get_free_pages() is not freed on the
> error paths after it. Fix that by adding a corresponding __free_pages()
> call to the error path.
>
> Fixes: facd94bc458a ("fbdev: ssd1307fb: Allocate page aligned video memory.")
> Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
> ---
> Compile tested only. Not tested on hardware.
>
> v1->v2:
> - Fix incorrect call to __free_pages with uninitialized values as
> pointed out by Helge Deller. Now, the patch uses vmem and vmem_size
> which hold valid values at the goto site.
>
> Thanks for catching. I'm sorry I overlooked this in v1.
>
> v1 link: https://lore.kernel.org/all/20251202191225.111661-1-nihaal@cse.iitm.ac.in/
>
> drivers/video/fbdev/ssd1307fb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
applied.
Thanks!
Helge
prev parent reply other threads:[~2025-12-05 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 3:55 Abdun Nihaal
2025-12-05 10:32 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf69bf02-35f1-493f-84d7-957f25b38b4c@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niederp@physik.uni-kl.de \
--cc=nihaal@cse.iitm.ac.in \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®