From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848AbdKJKrt (ORCPT ); Fri, 10 Nov 2017 05:47:49 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:50298 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752451AbdKJKrr (ORCPT ); Fri, 10 Nov 2017 05:47:47 -0500 Subject: Re: [PATCH net-next] bindings: net: stmmac: correctify note about LPI interrupt To: Niklas Cassel , Rob Herring , Mark Rutland , "David S. Miller" , Joao Pinto , Niklas Cassel , Giuseppe Cavallaro , Thierry Reding CC: , , References: <20171109170928.15496-1-niklas.cassel@axis.com> From: Alexandre Torgue Message-ID: Date: Fri, 10 Nov 2017 11:47:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171109170928.15496-1-niklas.cassel@axis.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG8NODE2.st.com (10.75.127.23) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-10_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2017 06:09 PM, Niklas Cassel wrote: > There are two different combined signal for various interrupt events: > In EQOS-CORE and EQOS-MTL configurations, mci_intr_o is the interrupt > signal. > In EQOS-DMA, EQOS-AHB and EQOS-AXI configurations, these interrupt events > are combined with the events in the DMA on the sbd_intr_o signal. > > Depending on configuration, the device tree irq "macirq" will refer to > either mci_intr_o or sbd_intr_o. > > The databook states: > "The MAC generates the LPI interrupt when the Tx or Rx side enters or exits > the LPI state. The interrupt mci_intr_o (sbd_intr_o in certain > configurations) is asserted when the LPI interrupt status is set. > > When the MAC exits the Rx LPI state, then in addition to the mci_intr_o > (sbd_intr_o in certain configurations), the sideband signal lpi_intr_o is > asserted. > > If you do not want to gate-off the application clock during the Rx LPI > state, you can leave the lpi_intr_o signal unconnected and use the > mci_intr_o (sbd_intr_o in certain configurations) signal to detect Rx LPI > exit." > > Since the "macirq" is always raised when Tx or Rx enters/exits the LPI > state, "eth_lpi" must therefore refer to lpi_intr_o, which is only raised > when Rx exits the LPI state. Update the DT binding description to reflect > reality. > > Signed-off-by: Niklas Cassel > --- > Documentation/devicetree/bindings/net/stmmac.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt > index c3a7be6615c5..3a28a5d8857d 100644 > --- a/Documentation/devicetree/bindings/net/stmmac.txt > +++ b/Documentation/devicetree/bindings/net/stmmac.txt > @@ -12,7 +12,7 @@ Required properties: > Valid interrupt names are: > - "macirq" (combined signal for various interrupt events) > - "eth_wake_irq" (the interrupt to manage the remote wake-up packet detection) > - - "eth_lpi" (the interrupt that occurs when Tx or Rx enters/exits LPI state) > + - "eth_lpi" (the interrupt that occurs when Rx exits the LPI state) > - phy-mode: See ethernet.txt file in the same directory. > - snps,reset-gpio gpio number for phy reset. > - snps,reset-active-low boolean flag to indicate if phy reset is active low. > Acked-by: Alexandre TORGUE