From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF43347CC97 for ; Wed, 3 Jun 2026 13:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495123; cv=none; b=tFg7IhVcahryw2YWQRKQHe9srCvBpsrx0nm3Xa3qoeMZQcpTIr04K+14K/zpU6D6S/A56S7Bsz9fMf3si/lvhvyXE+pXp7rGEHv5z63InZc47pwKNNj/rhX+d3/GVJlHRy9qJLvNFJpJFmIsQudhLS44jgOl4eEqlXRNUyDtK7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495123; c=relaxed/simple; bh=x8J8/N+2R1uvmgb9p8RIKLrLL3NV4CkdX/BgzqZfPuI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lrAKucE+Mh6JiAWRpC4QzzTLURcnEbIQ8eCyfXsmt2MFmF1hNzgHf9qF/MSuIiNTQdk7enJ2x8dKWBtaWqiRYpMpH6uTrPpG3ggbTj7v1U/MGw5K3Ta9dG0SO5LsSyXZEO0NgHphOk6OwxfYz1WWuY1bxFB4eYyTbhrqFGL+v7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KQuj0fq/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=USyxEjPK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KQuj0fq/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="USyxEjPK" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653Cbu8M3077837 for ; Wed, 3 Jun 2026 13:58:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5kfz6Dv68L4pwFmiCY3LaHQ0LYxLmU/e3hNomwI34hw=; b=KQuj0fq/FNlCX7s4 0zVooYxNnJTlsmaulVFgXMdVtsEkF4D4a1mmEl4YkuBFHimPm00cO4Sp2x8uvd2M SzT0KOpHDmUgKEx+0fLs519VrHfVQ99D2BG4b7j7fT7HCjNs8717Xnkzd5nXBr6l CTFQZNZEUrUuxl7Jw4P61MfRgK+urr2hisbLmEAXf0eO5OCUxx3iltDcPKFmZGXl vFU3GDIz2ow/B/6VrWbRK2GxxIM7l84ZFb6McHdqS9s7kMEDPP0Hb0vGgBTqWdGV QhDD6qkPooZMdegS841a1YekNZNq+rB6Ect4skzIPIS0hdL+vSD4rDHnouDgFyQb XvGOow== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejabbtrw8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 13:58:34 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-91550dd07f7so100024185a.1 for ; Wed, 03 Jun 2026 06:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780495114; x=1781099914; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5kfz6Dv68L4pwFmiCY3LaHQ0LYxLmU/e3hNomwI34hw=; b=USyxEjPKm+QdCXUe60YwTqErfYX98UxDa48f91HYpVRQ+oX6KFt+vfENggEPRZH6n7 BrL/QaqF1ILfod1VyNuKqRQJf39ndHD1mJB9nSdFAl/0kHW+9frZ/DuBsFt9g4Mcz7oE +OOjwDsJTk2AcpnOUkBWOIeG6EGBXi9eul+XuFLvkd7drHOQ3Vnh7acY5R/X9kyACH3a xmz08Zu/U0/nGX8MPwfCLxmUOzIqcMLrRiv7KASxVMqMO8Na5/GkrRfXkCz6Sk2og51l JxJ394vwCbX56s4rlQRjvBfwizIOjoQZKW+cOk/nO1bFlen7MdIHUCEWHjbRoPNuYRyI UTFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780495114; x=1781099914; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5kfz6Dv68L4pwFmiCY3LaHQ0LYxLmU/e3hNomwI34hw=; b=VQO090+9dGUNlD4Ey/sqrlTBJojanMDsF7TuIYYsvFeypaRz6ULtkPdhsv1Ze/MXuX H1ZLiLc2Ok36B7kM0+HnHfVwirupjHT6AOmCc+odiF9+CyGBjGMuwwx+qg/Oijx+XuqK z5220eAhrtsvKVumfhWrGR0/tprJO+yUhs+Pia7qKn9jrD95NF3fDgo5pur+yaSacyMt OoHR1mA+xUIJ2LbkKcx50YA9rg4KXCxBEFqKOOXG2fMtY/WpiG/jWvL5/T1fqeoAhjh/ DjApqppNOCvyQsI5f+BbUsMrrGQk5VS1GYCHav7HbzR7dihBaVqYdOaMe9QgEu9ZJgEV mvUQ== X-Forwarded-Encrypted: i=1; AFNElJ9CziRQkH0upyqYurPvHMcR3VCa6cUIaohZQ09v7pikKu3XdqNngHrNiGnESSaadxvC445PCOSVeen+geY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxz2zLzgwG6/HVIfMk7LKPECwzTHnpC8HHyUHYDQdiAEiDIXK6N EO2/Ppqxr6z0B9XafGVn/+PFs7T6mAppiAoRPONlGBxh6TxdfXJXBPz9NX8yRlAQAgkS7Onz4CB v2njzeTiSBpypa2tCSqOEw6rULeZflhzj7sg8l0b0mHtd1ebuWLgZNe079ihMfzTTxu0= X-Gm-Gg: Acq92OGgwAKp5sHl3iO5GpinKMmywRIyQu9ahKbq6aFvtaKWtbmY7gv5ejyy1NIn56O Y1eDlUrXgapVt01JUPvlLI8grha61eVCVt0uar+l97c1Cd5NJEo7zI6Zdy3JXaRKeHHdPv7jxeW QqEEcohtGC/6MhDVNiP7I1o2iqIcLfTEue+9hBVIDXPgQHrfGen7JoQXMUXjZAM5fQZEB2HTi10 0oui8/95Y9aNm4rW9Cb1D7LOIBvMYUXTf7RB2m+Nr2B3vURguJaXFSWpwL9rGSXGkOGtzh3XEI2 X0XAc+B9W1HG1YgiFW7KH2QKQindx95iL7eZarf2lGL0x7tNY0vuSe6ui3kYSu0i1565xUj2o4n Yt+z60Sa7w3Ku3G1P1fnTcvkJqnrHS5LeKj1QFYQ0yN9gwINoj0aTaH1FQ4HwMi8UkbRc82kr0T sGVVBUmILDjG4= X-Received: by 2002:a05:620a:6ccc:b0:915:7c1a:1388 with SMTP id af79cd13be357-9158a3ab0bdmr408458285a.5.1780495113846; Wed, 03 Jun 2026 06:58:33 -0700 (PDT) X-Received: by 2002:a05:620a:6ccc:b0:915:7c1a:1388 with SMTP id af79cd13be357-9158a3ab0bdmr408453685a.5.1780495113378; Wed, 03 Jun 2026 06:58:33 -0700 (PDT) Received: from [10.100.11.76] (public.toolboxoffice.it. [213.215.163.27]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e64e2d2bcsm1227544a12.10.2026.06.03.06.58.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 06:58:32 -0700 (PDT) Message-ID: Date: Wed, 3 Jun 2026 15:58:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] pinctrl: qcom: Avoid assigning thread_op_remain in unthreaded test To: Sneh Mankad , Bjorn Andersson , Linus Walleij , Yuanjie Yang Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260529-tlmm_test_changes-v1-0-88bfdccb4369@oss.qualcomm.com> <20260529-tlmm_test_changes-v1-3-88bfdccb4369@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260529-tlmm_test_changes-v1-3-88bfdccb4369@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDEzNCBTYWx0ZWRfX7+ukKE8KL4Ed Z9N4XsK8qM6CR2Pe3dzGYRhm5WbtCU+s+EmfevjWLTzbCOmlO7kK5aRRcR+9+gTUEIKfFGVTUEi x6OnW6liS8l3L1ncJydIiTgHtIiwcbfUH8yaFNNHjza4Zjvw3fwKxA0ZyV0fzSjTVzuhxlnSwe2 9YxJlaC00mQFnvtzeinZz8/YHA6PklyovDBUDAFk75eR62lOAknZ/ib+2k2YIiou+AziJ1cJkRW uUL/c8qCRngXruaeDC4JhxKXuJsIoOeB5WcO40RdlceWz83lNuwUKZAeqQ/DYlNYTw/LTIRzJvB 177u/v71G/VtyHZ6mDwT6a/JmwRYjwn5HyFPTi1K/Gkgv9FPcKJjeyp0MVLaR9e2gbZJyXs3VG3 cSsncS4C+RbmI8UfFi+ZdEeOHyGjjRzfVyFmzWsvlNdiMH6zFlRKNj4KqZ2iSaTQGiSuqgmMpzY 6CY8CPyUgT2vIpcn53w== X-Authority-Analysis: v=2.4 cv=UqZT8ewB c=1 sm=1 tr=0 ts=6a20330a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=aBIYUfOEhgoR9egqXYNcqA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=B2h_tRwOUKtx79AgloMA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: 0U3wm9qkqriHpop9V64S1pKlv6F5Mpo7 X-Proofpoint-GUID: 0U3wm9qkqriHpop9V64S1pKlv6F5Mpo7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030134 On 29-May-26 14:55, Sneh Mankad wrote: > tlmm_test_rising_while_disabled() sets thread_op_remain to 10, but this > variable is only used by the threaded IRQ handler to control the number > of GPIO pin toggles. Since tlmm_test_rising_while_disabled() does not > register a threaded IRQ handler, the assignment is never used. > > Remove the thread_op_remain assignment from > tlmm_test_rising_while_disabled(). > > This does not cause any change in functionality. > > Signed-off-by: Sneh Mankad > --- > drivers/pinctrl/qcom/tlmm-test.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/tlmm-test.c b/drivers/pinctrl/qcom/tlmm-test.c > index 007d6539ceced294e81cfbe93a00c75a98c858de..e9e04300ab3687825255885821ebde0f3ee586a8 100644 > --- a/drivers/pinctrl/qcom/tlmm-test.c > +++ b/drivers/pinctrl/qcom/tlmm-test.c > @@ -521,7 +521,6 @@ static void tlmm_test_rising_while_disabled(struct kunit *test) > unsigned int before_edge; > > priv->intr_op = TLMM_TEST_COUNT; > - atomic_set(&priv->thread_op_remain, 10); Should this be setting priv->intr_op_remain instead? Konrad