Re: [PATCH RESEND RFC v4 3/6] drm/display: dp: use new DCPD access helpers

[Kees Bakker <kees@ijzerbout.nl>]

Op 24-03-2025 om 12:51 schreef Dmitry Baryshkov:
> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Switch drm_dp_helper.c to use new set of DPCD read / write helpers.
>
> Reviewed-by: Lyude Paul <lyude@redhat.com>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/gpu/drm/display/drm_dp_helper.c | 296 +++++++++++++-------------------
>   1 file changed, 116 insertions(+), 180 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index 410be0be233ad94702af423262a7d98e21afbfeb..e2439c8a7fefe116b04aaa689b557e2387b05540 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> [...]
> @@ -3542,7 +3509,7 @@ int drm_dp_pcon_frl_configure_2(struct drm_dp_aux *aux, int max_frl_mask,
>   	else
>   		buf &= ~DP_PCON_FRL_LINK_TRAIN_EXTENDED;
>   
> -	ret = drm_dp_dpcd_writeb(aux, DP_PCON_HDMI_LINK_CONFIG_2, buf);
> +	return drm_dp_dpcd_write_byte(aux, DP_PCON_HDMI_LINK_CONFIG_2, buf);
>   	if (ret < 0)
>   		return ret;
>   
Don't forget to delete the remainder of the function.
Also the variable `ret` isn't used anymore.
-- 
Kees