From: John Garry <john.garry@huawei.com>
To: "Jin, Yao" <yao.jin@linux.intel.com>, <acme@kernel.org>,
<jolsa@kernel.org>, <peterz@infradead.org>, <mingo@redhat.com>,
<alexander.shishkin@linux.intel.com>
Cc: <Linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>, <ak@linux.intel.com>,
<kan.liang@intel.com>, <yao.jin@intel.com>,
Kan Liang <kan.liang@linux.intel.com>
Subject: Re: [PATCH v1] perf pmu: Add PMU alias support
Date: Fri, 23 Jul 2021 12:46:38 +0100 [thread overview]
Message-ID: <bf81673d-4b8f-e68a-bb44-32ad15b106f7@huawei.com> (raw)
In-Reply-To: <6b9fb1dc-5f53-d378-9119-84e991a0c86e@linux.intel.com>
On 23/07/2021 07:56, Jin, Yao wrote:
>>>
>>> Use the real name,
>>> $ perf stat -e uncore_cha_2/event=1/ -x,
>>> 4044879584,,uncore_cha_2/event=1/,2528059205,100.00,,
>>>
>>> Use the alias,
>>> $ perf stat -e uncore_type_0_2/event=1/ -x,
>>> 3659675336,,uncore_type_0_2/event=1/,2287306455,100.00,,
>>
>> Having a self-test case would be nice. And it's questionable why this
>> goes in x86 code.
>>
>
> OK, I will add test cases for uncore PMU alias.
>
JFYI, I am doing a bit of a rewrite of tests/pmu-events.c to tighten it
up to catch cases like those fixed and also broke in "perf tools: Fix
pattern matching for same substring in different pmu type".
> For why it's now only x86 specific code, my understanding is, currently
> x86 has this usage case, we can further extend it to other ARCHs and
> make it a generic way in future.
Generally that is not how things are done, but I'm not the maintainer ...
Thanks,
john
prev parent reply other threads:[~2021-07-23 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 1:45 Jin Yao
2021-07-22 10:28 ` John Garry
2021-07-23 6:56 ` Jin, Yao
2021-07-23 11:46 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf81673d-4b8f-e68a-bb44-32ad15b106f7@huawei.com \
--to=john.garry@huawei.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®