From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: <xen-devel@lists.xenproject.org>,
Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 1/1] x86/xen: fix section of xen_init_time_ops() in header
Date: Mon, 4 Sep 2017 13:43:08 +0100 [thread overview]
Message-ID: <bf8ba0df-3067-a691-f1f5-399cf0d8f8d8@citrix.com> (raw)
In-Reply-To: <59AD66020200007800177273@prv-mh.provo.novell.com>
On 04/09/17 13:41, Jan Beulich wrote:
>>>> On 04.09.17 at 12:35, <andrew.cooper3@citrix.com> wrote:
>> On 04/09/17 11:15, Jan Beulich wrote:
>>>>>> On 04.09.17 at 10:17, <jgross@suse.com> wrote:
>>>> On 03/09/17 10:38, Nicolas Iooss wrote:
>>>>> Commit d162809f85b4 ("xen/x86: Do not call xen_init_time_ops() until
>>>>> shared_info is initialized") moved xen_init_time_ops() from __init to
>>>>> __ref without updating xen-ops.h accordingly. Fix this.
>>>>>
>>>>> Fixes: d162809f85b4 ("xen/x86: Do not call xen_init_time_ops() until
>>>>> shared_info is initialized")
>>>>> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
>>>>> ---
>>>>> arch/x86/xen/xen-ops.h | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h
>>>>> index 0d5004477db6..b2a5d48a2c2a 100644
>>>>> --- a/arch/x86/xen/xen-ops.h
>>>>> +++ b/arch/x86/xen/xen-ops.h
>>>>> @@ -69,7 +69,7 @@ void xen_setup_runstate_info(int cpu);
>>>>> void xen_teardown_timer(int cpu);
>>>>> u64 xen_clocksource_read(void);
>>>>> void xen_setup_cpu_clockevents(void);
>>>>> -void __init xen_init_time_ops(void);
>>>>> +void __ref xen_init_time_ops(void);
>>>>> void __init xen_hvm_init_time_ops(void);
>>>> When correcting this could you please modify the prototypes to comply to
>>>> the intended form as noted in include/linux/init.h (the __ref or __init
>>>> annotations should be just before the ending semicolon)?
>>> Why would these annotations be kept on the declarations anyway?
>>> Attributes affecting code/data placement generally belong on the
>>> definitions only.
>> Because:
>>
>> a) That’s what the coding style says, and
>>
>> b) So various static analysis can be done (e.g. sparse) on an individual
>> translation unit basis.
>>
>>
>> Your objection to having annotations on declarations is why I've never
>> got around to adding sparse to the hypervisor build.
> Would you mind educating me what use these annotations can be
> for static analysis? If they're useful in headers, I would stop
> objecting to them being added there, but I'd then demand for them
> to never be present on non-static definitions (unless there are
> attributes where the compiler requires them to be repeated, but I
> think all attributes are cumulative).
For one, finding calls to __init functions from non __init functions.
~Andrew
next prev parent reply other threads:[~2017-09-04 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 8:38 Nicolas Iooss
2017-09-04 8:17 ` Juergen Gross
2017-09-04 10:15 ` [Xen-devel] " Jan Beulich
2017-09-04 10:35 ` Andrew Cooper
2017-09-04 12:41 ` Jan Beulich
2017-09-04 12:43 ` Andrew Cooper [this message]
2017-09-04 12:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf8ba0df-3067-a691-f1f5-399cf0d8f8d8@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®