mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anjelique Melendez <quic_amelende@quicinc.com>
To: Luca Weiss <luca.weiss@fairphone.com>, <pavel@ucw.cz>,
	<lee@kernel.org>, <thierry.reding@gmail.com>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <agross@kernel.org>,
	<andersson@kernel.org>
Cc: <konrad.dybcio@linaro.org>, <u.kleine-koenig@pengutronix.de>,
	<linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-pwm@vger.kernel.org>
Subject: Re: [PATCH 0/7] Add support for LUT PPG
Date: Tue, 25 Jul 2023 12:33:34 -0700	[thread overview]
Message-ID: <bf8bab0c-3081-91e0-5dbc-658aa8bab68a@quicinc.com> (raw)
In-Reply-To: <CTMFUY0GPRNK.532E4O05LWKW@otso>

On 6/26/2023 1:28 AM, Luca Weiss wrote:
> Hi Anjelique,
> 
> On Wed Jun 21, 2023 at 8:59 PM CEST, Anjelique Melendez wrote:
>> In certain PMICs, LUT pattern and LPG configuration can be stored in SDAM
>> modules instead of LUT peripheral. This feature is called PPG.
>>
>> This change series adds support for PPG. Thanks!
> 
> Thanks for sending this series!
> 
> I've tested this on SDM632 Fairphone 3 and everything appears to work
> fine with setting the pattern. Using fbcli from feedbackd[0] the pattern
> shows up correctly.
> 
> The only thing missing really is the addition of the pbs node and adding
> the nvmem/nvmem-names & qcom,pbs-client to the lpg node in pmi632.dtsi -
> something like the patch below.
> 
> Are you planning to include this in the next revision? Otherwise I can
> also send a patch for the pmi632.dtsi after this series has landed.
> 
> Tested-by: Luca Weiss <luca.weiss@fairphone.com> # sdm632-fairphone-fp3 (pmi632)
> 
> [0] https://source.puri.sm/Librem5/feedbackd
> 
> Regards
> Luca
> 

Hi Luca,

So sorry for the late response, I missed this message! Thank you for testing!

I was not planning to include adding the pbs node or updating lpg node in pmi632.dtsi.
If you are able to send a patch for pmi632.dtsi after that would be great!

Thanks,
Anjelique



      reply	other threads:[~2023-07-25 19:34 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 18:59 Anjelique Melendez
2023-06-21 18:59 ` [PATCH 1/7] dt-bindings: soc: qcom: Add qcom-pbs bindings Anjelique Melendez
2023-06-21 19:36   ` Rob Herring
2023-06-24  9:38   ` Krzysztof Kozlowski
2023-06-26 13:58   ` Rob Herring
2023-06-29  1:19     ` Anjelique Melendez
2023-06-29  8:45       ` Dmitry Baryshkov
2023-06-29 21:53         ` Anjelique Melendez
2023-06-29 23:58           ` Dmitry Baryshkov
2023-07-01 11:03       ` Krzysztof Kozlowski
2023-07-11  3:52         ` Anjelique Melendez
2023-07-11  5:58           ` Krzysztof Kozlowski
2023-07-11 20:12             ` Anjelique Melendez
2023-07-12 14:22               ` Krzysztof Kozlowski
2023-07-12 14:35                 ` Dmitry Baryshkov
2023-07-12 20:11                   ` Krzysztof Kozlowski
2023-07-14 20:32                     ` Anjelique Melendez
2023-07-17  7:36                       ` Krzysztof Kozlowski
2023-06-21 18:59 ` [PATCH 2/7] dt-bindings: leds: leds-qcom-lpg: Add support for LUT through NVMEM devices Anjelique Melendez
2023-06-21 19:36   ` Rob Herring
2023-06-24  9:42   ` Krzysztof Kozlowski
2023-06-29  0:12     ` Anjelique Melendez
2023-07-01 11:01       ` Krzysztof Kozlowski
2023-06-21 18:59 ` [PATCH 3/7] soc: qcom: add QCOM PBS driver Anjelique Melendez
2023-06-24  9:55   ` Krzysztof Kozlowski
2023-06-24 10:01     ` Krzysztof Kozlowski
2023-06-29  0:48     ` Anjelique Melendez
2023-06-21 18:59 ` [PATCH 4/7] leds: rgb: leds-qcom-lpg: Add support for LUT pattern through single SDAM Anjelique Melendez
2023-06-21 18:59 ` [PATCH 5/7] leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG Anjelique Melendez
2023-06-21 18:59 ` [PATCH 6/7] leds: rgb: leds-qcom-lpg: Support two-nvmem PPG Scheme Anjelique Melendez
2023-06-21 18:59 ` [PATCH 7/7] leds: rgb: Update PM8350C lpg_data to support " Anjelique Melendez
2023-06-26  8:28 ` [PATCH 0/7] Add support for LUT PPG Luca Weiss
2023-07-25 19:33   ` Anjelique Melendez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf8bab0c-3081-91e0-5dbc-658aa8bab68a@quicinc.com \
    --to=quic_amelende@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®