From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D596CC3A589 for ; Tue, 20 Aug 2019 14:27:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5D8F214DA for ; Tue, 20 Aug 2019 14:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730354AbfHTO11 (ORCPT ); Tue, 20 Aug 2019 10:27:27 -0400 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:44765 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728770AbfHTO11 (ORCPT ); Tue, 20 Aug 2019 10:27:27 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=36;SR=0;TI=SMTPD_---0Ta-z0CR_1566310900; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0Ta-z0CR_1566310900) by smtp.aliyun-inc.com(127.0.0.1); Tue, 20 Aug 2019 22:21:42 +0800 Subject: Re: [PATCH 14/14] mm/lru: fix the comments of lru_lock To: Matthew Wilcox Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mel Gorman , Tejun Heo , Jason Gunthorpe , Dan Williams , Vlastimil Babka , Ira Weiny , Jesper Dangaard Brouer , Andrey Ryabinin , Jann Horn , Logan Gunthorpe , Souptick Joarder , Ralph Campbell , "Tobin C. Harding" , Michal Hocko , Oscar Salvador , Wei Yang , Johannes Weiner , Pavel Tatashin , Arun KS , "Darrick J. Wong" , Amir Goldstein , Dave Chinner , Josef Bacik , "Kirill A. Shutemov" , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Mike Kravetz , Hugh Dickins , Kirill Tkhai , Daniel Jordan , Yafang Shao , Yang Shi References: <1566294517-86418-1-git-send-email-alex.shi@linux.alibaba.com> <1566294517-86418-15-git-send-email-alex.shi@linux.alibaba.com> <20190820140019.GB24642@bombadil.infradead.org> From: Alex Shi Message-ID: Date: Tue, 20 Aug 2019 22:21:39 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190820140019.GB24642@bombadil.infradead.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2019/8/20 ÏÂÎç10:00, Matthew Wilcox дµÀ: > On Tue, Aug 20, 2019 at 05:48:37PM +0800, Alex Shi wrote: >> @@ -159,7 +159,7 @@ static inline bool free_area_empty(struct free_area *area, int migratetype) >> struct pglist_data; >> >> /* >> - * zone->lock and the zone lru_lock are two of the hottest locks in the kernel. >> + * zone->lock and the lru_lock are two of the hottest locks in the kernel. >> * So add a wild amount of padding here to ensure that they fall into separate >> * cachelines. There are very few zone structures in the machine, so space >> * consumption is not a concern here. > > But after this patch series, the lru lock is no longer stored in the zone. > So this comment makes no sense. Yes, It's need reconsider here. thanks for opoint out. > >> @@ -295,7 +295,7 @@ struct zone_reclaim_stat { >> >> struct lruvec { >> struct list_head lists[NR_LRU_LISTS]; >> - /* move lru_lock to per lruvec for memcg */ >> + /* perf lruvec lru_lock for memcg */ > > What does the word 'perf' mean here? sorry for typo, could be s/perf/per/ here. Thanks Alex