From: Michal Simek <michal.simek@xilinx.com>
To: Jan Kiszka <jan.kiszka@web.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Wei Xu <xuwei5@hisilicon.com>
Cc: Ryan Grachek <ryan@edited.us>,
John Stultz <john.stultz@linaro.org>,
<linux-wireless@vger.kernel.org>, "Reizer, Eyal" <eyalr@ti.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
Tony Lindgren <tony@atomide.com>,
Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH v2] arm64: dts: zcu100-revC: Give wifi some time after power-on
Date: Fri, 25 Jan 2019 13:38:34 +0100 [thread overview]
Message-ID: <bf8ed343-d9af-c7d3-0836-6dda2b3e8243@xilinx.com> (raw)
In-Reply-To: <efc793c8-da17-e267-851e-f08f097843ee@web.de>
On 24. 01. 19 9:28, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Somewhere along recent changes to power control of the wl1831, power-on
> became very unreliable on the Ultra96, failing like this:
>
> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
>
> After playing with some dt parameters and comparing to other users of
> this chip, it turned out we need some power-on delay to make things
> stable again. In contrast to those other users which define 200 ms,
> Ultra96 is already happy with 10 ms.
>
> Fixes: 5869ba0653b9 ("arm64: zynqmp: Add support for Xilinx zcu100-revC")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>
> Changes in v2:
> - fix changelog
>
> arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index 13a0a028df98..e5699d0d91e4 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -101,6 +101,7 @@
> sdio_pwrseq: sdio-pwrseq {
> compatible = "mmc-pwrseq-simple";
> reset-gpios = <&gpio 7 GPIO_ACTIVE_LOW>; /* WIFI_EN */
> + post-power-on-delay-ms = <10>;
> };
> };
>
> --
> 2.16.4
>
Applied.
Thanks,
Michal
prev parent reply other threads:[~2019-01-25 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 8:28 Jan Kiszka
2019-01-24 15:29 ` Tony Lindgren
2019-01-25 12:38 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf8ed343-d9af-c7d3-0836-6dda2b3e8243@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=eyalr@ti.com \
--cc=jan.kiszka@web.de \
--cc=john.stultz@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ryan@edited.us \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=valentin.schneider@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®