From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425623B0ADE for ; Thu, 30 Jul 2026 08:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785398409; cv=none; b=kleb+Knf+tVwzLqWvsmqtUn7PisbV9/krvBV5gYJKS9sH+TU0OtPm+GgWp5e5OLu+gDlrEGu4sJT7LFzDQfdHfCHSu3BslFweKsCtSgUbKbzwQedr91ZJkE7jwTZiwJYS+Jg0bcXPoDuISn5peyB63RhLRRhpRo5Zm51Q+FiZlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785398409; c=relaxed/simple; bh=isRfVqCrTeJuXESVbQDgCHVzjp5mrnfEXx8zcVOOmZw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=la41QhBcCfZJDoOOwNC67AMtdToQBZsdbiWAH2sOtuF5h6PZ4C7B625smy6kJDowP8IlOuGL9yg8PTotlokNfhEg45CVwALo6/tN7wl5axQ3MmQBw1LPsMAHEQJRsIv9413DG8iOkDj6C7L5AdLdSUVtDinOmtpCB8acH4J8Sl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rpht+v6W; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gg0NpSMG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rpht+v6W"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gg0NpSMG" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66U6aixq270666 for ; Thu, 30 Jul 2026 08:00:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bKfAWqKof+fZNEYGEOBMVQlW4vh6V4id4rJXwvfR8sg=; b=Rpht+v6WlOKG5vyq Af36mYCM0yxOOlLbzpFA9cRzdkCNEoxHDavwfASIvgdyY/KFOENSsmWW+hIDL7Nf bwJHiq98IvAvLDLyMP+p6sW5UQHwE6DZ2QwrgDbQaA6dOKGPUcumpzP0dd/2tNVQ UwMiAdT3B+2Swz4f9KMYeA0sxRNPBIIE3jiwDGRySrNX/Z6ZWeQLVy/0E24Gike3 T8IPG25xzKPOcBI41QmU6w8Ap5T9C/MH2CFbZ5/75hrQgRTgu8me11YYkSEDiOG9 d9/s07TF4QxJPy23fHcPR/LoVHMyrOsHdOVe9q4Qpw1MTcYO/JDi+G4OrCh5um46 MNiV3Q== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr1c80d0a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 08:00:03 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-930b81c13b0so15345985a.0 for ; Thu, 30 Jul 2026 01:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785398402; x=1786003202; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bKfAWqKof+fZNEYGEOBMVQlW4vh6V4id4rJXwvfR8sg=; b=Gg0NpSMGh7T2a3oWRvoIhvpYo1i0cT2EgWfVw1C+szonME8QhDJLUXgauF7TE3f6XT mNnR58k4DlMcwUm/QFgOzxKFVojKIEG6KZnkY6BKkXVYs23oyHFOzSQhtukr7K+1Nres C2V8P+4hrRCA/XdUMIgISA5l1GIoxP2Nc+4p8IW9I0V42aLm0JZu8IHGSd49Ep9e480l HEs2svmRvOhrBtsnySg0vsp/cJ3U4tBOX4g6DMayelhpSec1bgQnogqA244nmI5D7Kmd ukm95bYvQpGxwaIOJvIqpEg6gFV5Nh7kakwf+z8ofDJ0Y7PpATRxrMvqX3DN8ACyvt6F oftQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785398402; x=1786003202; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bKfAWqKof+fZNEYGEOBMVQlW4vh6V4id4rJXwvfR8sg=; b=Zax29042WK36y/s+2NLAdlf7GkFbc6UNADoH2tmNGsJCGkEEpbV4YsB1PdVsAX0tAn CpfqigXnW5XzcEmns+jmHm/p2nyFmxsFJ5xJnC7CvlPkRSyYCbxSU2mSB14GM8K0kPw6 QQDuHtbOMTr8DxuiLchedDUXfefrKkRHAN+X5cve9vt/mkre5GYTRZf7ULec0ZlRt3OO rfgwsIksVxy0O9F+7tsF6MJe04BalsGZwmMZ+L30BbXtT+pAosenauVhy7RbfY4KcejY r6dztU4FQywFHt9IHdMtLtkhoM42QlnGokgCA13yQ7EqFTJWubdJLiPvIcjzY8+rwDHa LrJg== X-Forwarded-Encrypted: i=1; AHgh+RoJ+j0KhTsk9URY4WKsssnyZ1I2QqLDav98sDavHfmdBmrUpqKiNYr7H5ZRRY7o09V0hNcS1SFcR1ihFHI=@vger.kernel.org X-Gm-Message-State: AOJu0YzFh3u/kn58mvM7zBBMEqW7tAl0sJ2FMcpNr6DcQzp+owx/LW4j ydKI6KgZKDzom+6emewwFPpSK/nTcPwsi1uIH2kBwqNGxtsVYPdX4+iV2q+KfMdJxi5R40wCGN9 gb6PFAkGtCPIVU7/yUKE+zV+MyiuRGGbllmUhaIUQCBkKqsz3ZMnZd0oGL1qzQ0euS80= X-Gm-Gg: AR+sD10PnLGX+wGd0dM4vLxj8Qcw47DuQFWvy8E43ktDalV/0IKnxclU1oHEu/dPD8b gMeSaB2ibqfOGEp5ZMGMQ4vDK9dssjUO3w94RAAaoQPugfgPl2CprUbZW7DSLDkHwaIL0Z6NqGt 335SYkQk2RimUqWEEussS5J+cJY4ZUMKmw8CRq9uXYhlyaAEtLv5ToNJLFGHFJsmu1ng+6R2Xvb 6YxAaFZLu4D4ub2zUF8BsuBt6+F3UthbgntxvOVl1pkfl9yh9JjUoU+AyYmxVH2LO/nT3UaBWa/ 72zaqCka/7xubBUubmPdrwBE6VII9EP522SQvRe5oc8cvOZlg5zNl15zqFOxtQ4TN0eXbyhB2nm OcLjCaJ6Z5YTlBGss0n4nWjTo X-Received: by 2002:a05:620a:a501:b0:92e:5ef1:9072 with SMTP id af79cd13be357-934861506efmr199727885a.2.1785398402554; Thu, 30 Jul 2026 01:00:02 -0700 (PDT) X-Received: by 2002:a05:620a:a501:b0:92e:5ef1:9072 with SMTP id af79cd13be357-934861506efmr199725285a.2.1785398402121; Thu, 30 Jul 2026 01:00:02 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a07c77bbcfsm278261a12.7.2026.07.30.00.59.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 01:00:01 -0700 (PDT) Message-ID: Date: Thu, 30 Jul 2026 09:59:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: eliza-evk: Add PCIe1 with TC9563 PCIe switch To: Manivannan Sadhasivam Cc: Krishna Chaitanya Chundru , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski , Abel Vesa References: <20260730-eliza_evk-v6-0-40ece2d33114@oss.qualcomm.com> <20260730-eliza_evk-v6-3-40ece2d33114@oss.qualcomm.com> <9a042817-3a3d-4637-8df7-466ffa380403@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: lEN0OdKl6DDMPxeK2vQ735uVQKYM_6Jk X-Proofpoint-ORIG-GUID: lEN0OdKl6DDMPxeK2vQ735uVQKYM_6Jk X-Authority-Analysis: v=2.4 cv=EJU2FVZC c=1 sm=1 tr=0 ts=6a6b0483 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=8zT0Z9mGZitViAjM5KwA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA1NiBTYWx0ZWRfXxmn4m8jyXJph S8R4uAAkriP5OCcjIZ4Ek69SC5+ycNGbLf7vUjCU8VsRAiRU/slgsl+0kJ20i00zl5C+8rUzYV/ Rq5R0T5JHLA4/yKmVzLZuky5X2hExHegOr7ePR8JZ4b+aJoTqSvxqYn6ADI97pjDPFwcT82Nz/m 0awe62nKzACBe3ssCNYmhrXQX9n2qFT9H5+HM7/D/frWtUaBpfafQu/bODRpsIVUHiC1gYlM8OG f4IWF+ExEp1NXhQkB01Ftjqg7zG6YmNNw51cjKHDg1ZFZ0nnSxo0UQLZV80FZMyyqiH4UjkX9rk iJ9emxFu17RlQPv+SvwUEO4EAvpq0q8QDvdVGmJ6S8W69EmJ22+1/mmzM7tqnZ5YTB22nDgkUpW Gs39QVLsO2GgcP1flOga419egb1zoRXJbPISawHYUJGIXiZ+9YkGmEx2mdDnG6A0jXpu0dr8Lex DwuDbC4D07RL8gnqTig== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA1NiBTYWx0ZWRfX7r6znRk2XKpO SBsVNgVtWm4sFlQC17hXtVnT5h93oOyRnDJpjsef44KN6M0q+IkjpV+p8yEDoQINUkMEMimoghQ KxtCfCSzNBcZHorzKTEcI8DpLq68Khc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_02,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300056 On 7/30/26 9:52 AM, Manivannan Sadhasivam wrote: > On Thu, Jul 30, 2026 at 09:42:29AM +0200, Konrad Dybcio wrote: >> On 7/30/26 7:25 AM, Manivannan Sadhasivam wrote: >>> On Thu, Jul 30, 2026 at 10:18:55AM +0530, Krishna Chaitanya Chundru wrote: >>>> The Eliza EVK board connects PCIe1 (8GT/s x2) to a Toshiba TC9563 >>>> PCIe switch. Enable PCIe1 and its QMP PHY nodes. >>>> >>>> TC9563 uses I2C (at address 0x77 on I2C4) for its management interface. >> >> [...] >> >>>> + pcie@3,0 { >>>> + reg = <0x21800 0x0 0x0 0x0 0x0>; >>>> + #address-cells = <3>; >>>> + #size-cells = <2>; >>>> + device_type = "pci"; >>>> + ranges; >>>> + bus-range = <0x5 0xff>; >>>> + >>>> + pcie@0,0 { >>>> + reg = <0x50000 0x0 0x0 0x0 0x0>; >>>> + #address-cells = <3>; >>>> + #size-cells = <2>; >>>> + device_type = "pci"; >>>> + ranges; >>> >>> Sashiko pointed out that you are using bridge specific properties in EP node: >>> https://lore.kernel.org/linux-pci/20260730051031.20D8E1F000E9@smtp.kernel.org >> >> Can we harden the bindings here? >> > > Possible, but overkill IMO. The base dtschema for PCI bridge includes both > 'pci-device' and 'pci-bus-common'. So for the Endpoints, we need to restrict > them to use only 'pci-device' schema and that would require adding > 'patternProperties' to cover the Endpoint nodes in each binding. > > Since this is not a recurring issue, I don't think we really need to go that > far. OK Konrad