mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Haifeng Xu <haifeng.xu@shopee.com>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: i40e: How the packets will be processed when status_error_len is 0
Date: Tue, 13 May 2025 14:23:50 +0800	[thread overview]
Message-ID: <bf9a3230-26b9-40f7-aff0-99c802fb7764@shopee.com> (raw)
In-Reply-To: <CAL+tcoAYvN20aMz-WYFEUeBypS8yMJ53YgdMUHCX6FCr__qT9A@mail.gmail.com>



On 2025/5/13 14:13, Jason Xing wrote:
> On Tue, May 13, 2025 at 12:08 PM Haifeng Xu <haifeng.xu@shopee.com> wrote:
>>
>> Hi all,
>>
>>         If the packets arrive at the rx and then raise soft irq to handle it, but in i40e_clean_rx_irq, status_error_len is 0 and return.
> 
> Directly "return"? What version of I40E are you looking at?

stable kenrel 5.15.162,

i40e_clean_rx_irq
...
	qword = le64_to_cpu(rx_desc->wb.qword1.status_error_len);
	...
	size = (qword & I40E_RXD_QW1_LENGTH_PBUF_MASK) >>
		       I40E_RXD_QW1_LENGTH_PBUF_SHIFT;
	if (!size)
		break;
...

if status_error_len is 0, the i40e_clean_rx_irq returns 0.
> 
>>         The data isn't fetchted from the rx buffer, so the how the packets arrive at the rx will be processed?
> 
> In i40e_clean_rx_irq(), packets are one by one constructed into the
> sk_buff and then passed to the stack by napi_gro_receive().
> 
> AFAIK, common drivers implement nearly the same scenario.
> 
> 
> Thanks,
> Jason
> 
> 
>>
>>         FYI, the every rx/tx queue has been bounded to one cpu(64 queues, 64 cpus).
>>
>> Thanks!
>>


      reply	other threads:[~2025-05-13  6:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13  4:03 Haifeng Xu
2025-05-13  6:13 ` Jason Xing
2025-05-13  6:23   ` Haifeng Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf9a3230-26b9-40f7-aff0-99c802fb7764@shopee.com \
    --to=haifeng.xu@shopee.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®