From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5941E24DD0E for ; Wed, 15 Oct 2025 18:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760553699; cv=none; b=OndfaPDZkZBKvEdXNm0oIgNs179+ZFQGKZ2zt6bynwsB/EzLCGdh8EPbanxZybzhElygQa2YoGLBuxuYPEr4u6MNBT8jwVMLCUG6OcWXz1Dkh6Ssj6lTAcuPgljlEDb/n0mgH9R851RGU99ez/I+uSBnn9/dBS2NItb5UFbTDSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760553699; c=relaxed/simple; bh=dx0qVmHaErexTyZmeoLh4fwFrUvfpdSCx26iEjNbWxg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GFABWVqKtVu35ZoxIkFXApe539XxO6Dp5PjuX/IY7zXUxCghWLUlXQQI/o06Ka4bGBXyZnOXPrqnNESo8tgmUhHgIRRHXEOIeSpK85vdKXcu5yMzNzVlEESOx/rA8I1U2UJ1LBdci2z+KeBAXR9aV9P3UFuPnfC2s0pk80KPOss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HehQwM83; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HehQwM83" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-58b037243d5so1210812e87.1 for ; Wed, 15 Oct 2025 11:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760553695; x=1761158495; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=tJlLj6BAoxjVSk1NLTz6D1jxyQjoorCPPfMJr/rohBw=; b=HehQwM83lHvn4pSkb9fcOeFLAQVkxPXyOWY9idFVi1qswWRKVD806cxXLvsNoiRLCY 5ePMhDUMvrfaa/67RNks/KMnhgPQJB9d7Z82rTxtTr1si+oY+6etJeZwpBwA6irkpzOZ HD8hZSpiDa9kKY4SQgSxGzMTFkBj6wTFT9+gu+HPe3fe7SS3dC+EKT7Zadxrq7Vipfmb gakLaijFgjP2qSS7bWJTNAST/Q5j+c7loJ3VhEc+9ATBIyPOv4zpJnoWRUmFkdZuokZb SvfRniiulfo0/3v7leX3Ob95lLo/Y6HZhetYoVNlmD3MVkkk7KBROrSmYHUlLwfGsJhc 9OeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760553695; x=1761158495; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tJlLj6BAoxjVSk1NLTz6D1jxyQjoorCPPfMJr/rohBw=; b=VNtUUbyVkXB/CzSbn/8k1wKuMyxlPnCGEMFP3oji5179AOK2+btgmjfq4EJRNbwRRZ za5rQ4JfOBIWdAgopotN9KtuaPR0nAtFfaH24yjf3sW4pTsTiPzE75xC7qWbz14QQ13B 237o/h3evNFHRnAZJrSKi1t/Bb1LYVZTMDIIg7QnrX+8Rk/7MAvWw2VDrxzr+MDo1Y1U o8QXYrD3ltjZXUGLsy6HJ0lbs82j8emnGkfTRXE5KFja1n4qNC3z9584HSM+un1OUDwZ ibQlQ0HpZoWgIfGus+n4KDQeszIn+vyKqncigAXlz054Q0qY+oiPwnez0lRqsTthOJjg tj5w== X-Forwarded-Encrypted: i=1; AJvYcCXFmBK9yDAApwg5FwBjfv0STHCxZirGMJt4kvr/JnO24YUCimsJyRzjyvR+vexwIy7AJ+6M7WRrGWHdMm4=@vger.kernel.org X-Gm-Message-State: AOJu0YxY+QpFoOVom3a5y7adlFkyKbV+DKuIfcrL3Ve37p6cW9I9W2hD +H0BX13CEM3rp1aHrsRon6BhXSGYNkXiXNWaXtyh2uRBpUhZoYvoXS0XspksvzT1HfA= X-Gm-Gg: ASbGncvzhqynPvXFPNi0dlDN+NYlaZKRYM2XehacspTLxLAPXAiZAD+4PcpDwgyPEck g0yh7o6vCcay82AVIT6MMVAtAydDQ6iQ10WFsxwb6OqHFS8LcYcfRHCw7gBMcka5oOozpM+UHi7 PwY2c6SlfhS4jyh2wQLkKy2eenB12DuvnpzpdflVciOXspS68iyb6dc2WrzZMK7sFRaiv3cQj8n ZQmGT3cWOEg/6Fmq+GqN0WQEdjFinIsQQUTwxE1o7WDXSmWh5AU52arNubOnWu3XLA9vaTC1piv ubZjCbegTMVnzB+RUYUCFjV4j/GqHHknGqhW5VYqIE8RMJgPySD1jJX+RNZ5ZN67dHDEr0ntOy1 uRI5Gs44QGFq5gRSstpapFYxWpzXV1MCn2woYtyJTZw8AE39dVCIpTkqnon3G0SilYqzFMxGeOy mu98Dd+KfAjTqNTibbFyQaQCD2mPMiL2MQi7c= X-Google-Smtp-Source: AGHT+IF+omlnIj0VW42QBPNVZc431CsHdQ7EPsBKi1Mx1WFqeaAKSz1ndgSM5DbxSPhZLcvdHjBrYg== X-Received: by 2002:a05:651c:1987:b0:36b:9ecc:cb62 with SMTP id 38308e7fff4ca-376099f239fmr41529381fa.0.1760553695443; Wed, 15 Oct 2025 11:41:35 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3762ea14d46sm49223291fa.34.2025.10.15.11.41.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Oct 2025 11:41:34 -0700 (PDT) Message-ID: Date: Wed, 15 Oct 2025 21:41:32 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies To: Vikram Sharma , mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nihal Kumar Gupta , bryan.odonoghue@linaro.org References: <20251015130130.2790829-1-quic_vikramsa@quicinc.com> <20251015130130.2790829-2-quic_vikramsa@quicinc.com> From: Vladimir Zapolskiy In-Reply-To: <20251015130130.2790829-2-quic_vikramsa@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/15/25 16:01, Vikram Sharma wrote: > Add support for vdda-phy-supply and vdda-pll-supply in the QCS8300 > CAMSS binding to reflect camera sensor hardware requirements. What are "camera sensor hardware requirements"? You do add properties to the ISP. > > Co-developed-by: Nihal Kumar Gupta > Signed-off-by: Nihal Kumar Gupta > Signed-off-by: Vikram Sharma > --- > .../bindings/media/qcom,qcs8300-camss.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml > index 80a4540a22dc..dce0a1fcb10c 100644 > --- a/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml > @@ -120,6 +120,14 @@ properties: > items: > - const: top > > + vdda-phy-supply: > + description: > + Phandle to a regulator supply to PHY core block. What is "PHY core block" here? > + > + vdda-pll-supply: > + description: > + Phandle to 1.8V regulator supply to PHY refclk pll block. This is a copy-paste example of a known to be wrong pattern. If you open a QCS8300 documentation or a schematics of some QCS8300 powered board, can you get a link between the actual pin names and the introduced property? Likely there should be nothing, which resembles "PHY refclk pll block" over there, and thus the description of the property is misleading. Please check other similar and recently added properties, like it's been done if you add a voltage level reference (and that's the only known for sure information), there will be no need to guess the right voltage level. And it's either incorrect in the description above or in the example below. > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > > @@ -160,6 +168,8 @@ required: > - power-domains > - power-domain-names > - ports > + - vdda-phy-supply > + - vdda-pll-supply > > additionalProperties: false > > @@ -328,6 +338,9 @@ examples: > power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>; > power-domain-names = "top"; > > + vdda-phy-supply = <&vreg_l4a_0p88>; > + vdda-pll-supply = <&vreg_l1c_1p2>; > + > ports { > #address-cells = <1>; > #size-cells = <0>; -- Best wishes, Vladimir