mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Eric Anholt <eric@anholt.net>, dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown.
Date: Wed, 2 Aug 2017 22:53:06 +0200	[thread overview]
Message-ID: <bfa71e20-6822-bb01-cef0-5966180f4b9f@tronnes.org> (raw)
In-Reply-To: <20170802203242.12815-1-eric@anholt.net>


Den 02.08.2017 22.32, skrev Eric Anholt:
> It's also destroyed from the top level vc4_drv.c initialization, which
> is where the cache was actually initialized from.
>
> This used to just involve duplicate del_timer() and cancel_work_sync()
> being called, but it started causing kmalloc issues once we
> double-freed the new BO label array.
>
> Fixes: 1908a876f909 ("drm/vc4: Add an ioctl for labeling GEM BOs for summary stats")
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>   drivers/gpu/drm/vc4/vc4_gem.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
> index 209fccd0d3b4..892a031a3ced 100644
> --- a/drivers/gpu/drm/vc4/vc4_gem.c
> +++ b/drivers/gpu/drm/vc4/vc4_gem.c
> @@ -1117,6 +1117,4 @@ vc4_gem_destroy(struct drm_device *dev)
>   
>   	if (vc4->hang_state)
>   		vc4_free_hang_state(dev, vc4->hang_state);
> -
> -	vc4_bo_cache_destroy(dev);
>   }

I don't have a display connected, but there's no crashing anymore.

Tested-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Noralf Trønnes <noralf@tronnes.org>

  parent reply	other threads:[~2017-08-02 20:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02 20:32 Eric Anholt
2017-08-02 20:32 ` [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload Eric Anholt
2017-08-03 13:37   ` Noralf Trønnes
2017-08-04 10:02   ` Boris Brezillon
2017-08-02 20:32 ` [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI Eric Anholt
2017-08-03 13:37   ` Noralf Trønnes
2017-08-04 10:08   ` Boris Brezillon
2017-08-02 20:53 ` Noralf Trønnes [this message]
2017-08-04 10:01 ` [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfa71e20-6822-bb01-cef0-5966180f4b9f@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®