From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C138C04EB8 for ; Thu, 6 Dec 2018 15:29:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB24E214C1 for ; Thu, 6 Dec 2018 15:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544110157; bh=1NFOhZvaIk9JpC9e78wXlet8uKg3wctLID0Ajn1928g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=1QHrq6jdHLCFD94Z6AVHUsgBcTzeNKhPDgPGR0WyVwL/K1jJa6oHT5WEiSb8B//kH g8seU8ugRhL5dWyM4HdhPv6lAK8wijrD+XnC4pNXFphPzjIsDr1+oVCl3Z/Z61cR/0 Bw89RhBBTzyOhundMWqqSegGkSK3qyGQnUioe1qE= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB24E214C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726060AbeLFP3Q (ORCPT ); Thu, 6 Dec 2018 10:29:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:41264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbeLFP3Q (ORCPT ); Thu, 6 Dec 2018 10:29:16 -0500 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B7DE20878; Thu, 6 Dec 2018 15:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544110155; bh=1NFOhZvaIk9JpC9e78wXlet8uKg3wctLID0Ajn1928g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=qKnE2guRFUgBv0YRtoscuv5RdN2Jw3QJc7RtKXN/Yw6ErgAQrFMdJbRPkklgTQjBM oyMeY/K4X7oqDtIJY6CEeu/cNjVW+Xp3x6X8Pq7QMarQUu9Hvp0E1j05pjZ/SYIVke 6ThS4PlKinfM470Dn8GwWAXTtBPertw0/z/DRtKM= Subject: Re: [RFC PATCH v8 3/4] media: media.h: Enable ALSA MEDIA_INTF_T* interface types To: Hans Verkuil , mchehab@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, shuah References: <0f47952fd84fd275646e3c9a18e208ced08dd6bb.1541109584.git.shuah@kernel.org> <76e1a986-fb47-869d-ee7e-8c9b919718cb@xs4all.nl> From: shuah Message-ID: Date: Thu, 6 Dec 2018 08:29:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <76e1a986-fb47-869d-ee7e-8c9b919718cb@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On 11/20/18 4:22 AM, Hans Verkuil wrote: > On 11/02/2018 01:31 AM, shuah@kernel.org wrote: >> From: Shuah Khan >> >> Move ALSA MEDIA_INTF_T* interface types back into __KERNEL__ scope >> to get ready for adding ALSA support to the media controller. >> >> Signed-off-by: Shuah Khan >> --- >> include/uapi/linux/media.h | 25 ++++++++++--------------- >> 1 file changed, 10 insertions(+), 15 deletions(-) >> >> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h >> index 36f76e777ef9..07be07263597 100644 >> --- a/include/uapi/linux/media.h >> +++ b/include/uapi/linux/media.h >> @@ -262,6 +262,16 @@ struct media_links_enum { >> #define MEDIA_INTF_T_V4L_SWRADIO (MEDIA_INTF_T_V4L_BASE + 4) >> #define MEDIA_INTF_T_V4L_TOUCH (MEDIA_INTF_T_V4L_BASE + 5) >> >> +#define MEDIA_INTF_T_ALSA_BASE 0x00000300 >> +#define MEDIA_INTF_T_ALSA_PCM_CAPTURE (MEDIA_INTF_T_ALSA_BASE) >> +#define MEDIA_INTF_T_ALSA_PCM_PLAYBACK (MEDIA_INTF_T_ALSA_BASE + 1) >> +#define MEDIA_INTF_T_ALSA_CONTROL (MEDIA_INTF_T_ALSA_BASE + 2) >> +#define MEDIA_INTF_T_ALSA_COMPRESS (MEDIA_INTF_T_ALSA_BASE + 3) >> +#define MEDIA_INTF_T_ALSA_RAWMIDI (MEDIA_INTF_T_ALSA_BASE + 4) >> +#define MEDIA_INTF_T_ALSA_HWDEP (MEDIA_INTF_T_ALSA_BASE + 5) >> +#define MEDIA_INTF_T_ALSA_SEQUENCER (MEDIA_INTF_T_ALSA_BASE + 6) >> +#define MEDIA_INTF_T_ALSA_TIMER (MEDIA_INTF_T_ALSA_BASE + 7) >> + > > I would only enable those defines that you need for the next patch. > Good plan. I fixed this to move just the ones I need for this work. thanks, -- Shuah