Re: [PATCH] HID: pulsar: add driver for Pulsar gaming mice

[Leo <leo@managarm.org>]

Hi,

> With three vendors sharing the same protocol, a vendor-neutral name would make
> sense. Any suggestions? Something like hid-paw3395-battery (sensor),
> hid-nrf52840-mouse (SoC), or is there a better identifier for this protocol?

I did some digging into the protocol, and from what I can tell it is
not necessarily associated with the specific sensor, as multiple mice
with differing sensors speak the same protocol (PAW3950 to name one).
The nrf52840 also does not seem to be limited to this protocol. I can't
find a public name for the protocol. Given that and that I'm not sure
what the subsystem's policy on module naming is, but I would assume
that changing them after the fact is not ideal. Probably (?) the
optimal solution would be to integrate your patch (thank you!) with the
existing hid-kysona driver; maybe a maintainer should weigh in on that.

I added my mouse's ID (3554:F58F) to the list and tested the patch.
Everything behaved as expected, UPower output looks reasonable. If you
like, you can amend the device ID to your patch. The `model_id` for it
is reported as 0x0220, and the model format string should be
"ATK VXE R1 SE+ (%s)". My 2.4 GHz receiver seems to not report a model
ID; the web configuration utility uses a different command to identify
the mouse model. Given that it uses a different idVendor anyway, I'm
not worried about that for now.

Tested-by: Leo <leo@managarm.org>

Cheers,
Leo