From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751281AbdFESRY (ORCPT ); Mon, 5 Jun 2017 14:17:24 -0400 Received: from resqmta-po-10v.sys.comcast.net ([96.114.154.169]:41144 "EHLO resqmta-po-10v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbdFESRV (ORCPT ); Mon, 5 Jun 2017 14:17:21 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , linux-kernel@vger.kernel.org Cc: Andy Lutomirski , Jonathan Corbet , Kees Cook , Will Drewry , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan , Shuah Khan References: <20170526184402.30267-1-mic@digikod.net> <20170526184402.30267-4-mic@digikod.net> <516eafac-7f32-5ddf-44cc-83edbd14c90c@digikod.net> From: Shuah Khan Message-ID: Date: Mon, 5 Jun 2017 12:17:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <516eafac-7f32-5ddf-44cc-83edbd14c90c@digikod.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GBueSLNamB5gjER9ogl55ilCFJUqG1Mwc" X-CMAE-Envelope: MS4wfIB8Zow4LvRu6pOFuYFeiPol3WERiYYO1v9leza7hDGkoRO7kxW/TBD7ON2zjgjO13kWk/leibfJXjX/w2nQxr58ahGptnF+h+X4BM1eqiXEid4tsrE3 jXiaEhmlQbExjRhgZDa4u0GVWMWsKYb44db16qaTu97itM2LwgKqzd2lb11o5ybH2dDz9Syag1kF8qyM9NiEfVoXcHa3sV65p0W3IXQL3ivoZTFD3x36tsB2 zv3D6olPvSW+V/UmGU7zoNV78qHQiN7C+NxPyAYGCPpWVLs41Cw703+cFGRS2BN96Ow5snPLWz1ofOTE84VsVVZDSwQAj8nsbTstX+G20WoYKefSbrFKMe1d Sf6n3zuogsexWsv8juaJHwE1GicxDrUZ9eLF+Jjt++FMjlRTYN0lZ2eNtLRkEq1tUC11twCyByLGQwFj8aqJRnTCYEpFAR+rFGV8lKPuNLubdrV3Icc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GBueSLNamB5gjER9ogl55ilCFJUqG1Mwc Content-Type: multipart/mixed; boundary="PkGEP7pJFfghKHPJwBCS1FQQwEf565wPG"; protected-headers="v1" From: Shuah Khan Reply-To: shuah@kernel.org To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , linux-kernel@vger.kernel.org Cc: Andy Lutomirski , Jonathan Corbet , Kees Cook , Will Drewry , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan , Shuah Khan Message-ID: Subject: Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies References: <20170526184402.30267-1-mic@digikod.net> <20170526184402.30267-4-mic@digikod.net> <516eafac-7f32-5ddf-44cc-83edbd14c90c@digikod.net> In-Reply-To: <516eafac-7f32-5ddf-44cc-83edbd14c90c@digikod.net> --PkGEP7pJFfghKHPJwBCS1FQQwEf565wPG Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Micka=C3=ABl, On 06/03/2017 05:13 AM, Micka=C3=ABl Sala=C3=BCn wrote: > Hi Shuah, >=20 > On 02/06/2017 21:31, Shuah Khan wrote: >> Hi Micka=C3=ABl, >> >> On 05/26/2017 12:43 PM, Micka=C3=ABl Sala=C3=BCn wrote: >>> Rebuild the seccomp tests when kselftest_harness.h is updated. >>> >>> Signed-off-by: Micka=C3=ABl Sala=C3=BCn >>> Acked-by: Kees Cook >>> Cc: Andy Lutomirski >>> Cc: Shuah Khan >>> Cc: Will Drewry >>> --- >>> tools/testing/selftests/seccomp/Makefile | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing= /selftests/seccomp/Makefile >>> index 5fa6fd2246b1..aeb0c805f3ca 100644 >>> --- a/tools/testing/selftests/seccomp/Makefile >>> +++ b/tools/testing/selftests/seccomp/Makefile >>> @@ -4,3 +4,5 @@ LDFLAGS +=3D -lpthread >>> =20 >>> include ../lib.mk >>> =20 >>> +$(TEST_GEN_PROGS): seccomp_bpf.c ../kselftest_harness.h >>> + $(CC) $(CFLAGS) $(LDFLAGS) $< -o $@ >>> >> >> This change breaks seccomp build: >> >> make -C tools/testing/selftests/seccomp/ >> make: Entering directory '/mnt/data/lkml/linux_4.12/tools/testing/self= tests/seccomp' >> make: *** No rule to make target '../kselftest_harness.h', needed by '= /mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'. = Stop. >> make: Leaving directory '/mnt/data/lkml/linux_4.12/tools/testing/selft= ests/seccomp' >> shuah@mazurka:/mnt/data/lkml/linux_4.12$ cd tools/testing/selftests/se= ccomp/ >> shuah@mazurka:/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccom= p$ make >> make: *** No rule to make target '../kselftest_harness.h', needed by '= /mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'. = Stop. >> >> >> Did you happen to try building with this change? >=20 > Yes I did, and it builds fine for me (with the same command and > patches). There is only one warning from GCC with > ../kselftest_harness.h:368 because of the trick from OPTIONAL_HANDLER()= , > which is intentional (and not modified by my patches). >=20 > I don't get why your "make" said that there is "No rule to make target"= > ../kselftest_harness.h . This file exists (patch 1/7) so there is no > need to create it=E2=80=A6 > gen_kselftest_tar.sh works fine too. >=20 I think I know what's going on here. It is my bad. Never mind, we are goo= d. I will apply this patch to linux-kselftest next. thanks, -- Shuah --PkGEP7pJFfghKHPJwBCS1FQQwEf565wPG-- --GBueSLNamB5gjER9ogl55ilCFJUqG1Mwc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJZNaAuAAoJEAsCRMQNDUMcL4EQAJsBvHCGJM90ciB1cdrQU/We 6Ua7OTq3FJpn9jrCEzphDSSU/YmLeY73X0otmTq8LFqT2ndETJn2p/ECRYb1vjr/ b5tKzQX1MWK+4dXYH162wygr/J9sGaIpHphdCpW0xgpFO53/zFkvh8Ci5yRUqKTh 2MKf0zVm1VxKZYax7mduzbI/dvLD3yUlL5XfZw4gvk21NLHQz4+c69L5FifVgl5t /N8qkP4G8iwPs8LBwX4PWqyjswMzWd36UntNathWuJyXYCz+EBmTPTI8LZ3nPnbD jfmnQnXeNjxK5Du6F+p4DobxrtBzXIRPmMctT4TY+lsuwHcMLU3jbV7VG8s+S400 poD2K8njgUhtas2cu49Q2fypw3QXZ9Dd4WO7r6NCE6aUfimFgRoNYY81Mj1EEGDJ rSnEbs/cpZxuiM+omDKkLGZ4Hdsc5zjoHS/mcKav+yCN3YunCz/zlKr6NVk1Btg7 eCCsKzku/ah0ZrzFEYWaaam9x3p/UORPYtj8idgdBT/vsTsNXyK/7rc9fNzrZhEt D7vYrhSmUL60djDXcFMCu0LHHgy1CkgicfBMkfxipQUY4hMHFs9+dvD0pG5I8uwb DLWEFBNQZJaUC1phu3MxEyavhHACQkGGGt7JQPaOx8DIlsUgzH5mfyqYsg1zfzAs Sve5Bmn2bIZkFOnGjJbR =NOaH -----END PGP SIGNATURE----- --GBueSLNamB5gjER9ogl55ilCFJUqG1Mwc--