From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751994AbdJBPob (ORCPT ); Mon, 2 Oct 2017 11:44:31 -0400 Received: from out0-243.mail.aliyun.com ([140.205.0.243]:43380 "EHLO out0-243.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbdJBPoa (ORCPT ); Mon, 2 Oct 2017 11:44:30 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03271;MF=yang.s@alibaba-inc.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---.91ZNTKl_1506959055; Subject: Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel panic To: Christopher Lameter Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , akpm@linux-foundation.org, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1506473616-88120-1-git-send-email-yang.s@alibaba-inc.com> <1506473616-88120-3-git-send-email-yang.s@alibaba-inc.com> From: "Yang Shi" Message-ID: Date: Mon, 02 Oct 2017 23:44:08 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/17 11:43 PM, Christopher Lameter wrote: > On Thu, 28 Sep 2017, Yang Shi wrote: > >>> CONFIG_SLABINFO and /proc/slabinfo have nothing to do with the >>> unreclaimable slab info. >> >> The current design uses "struct slabinfo" and get_slabinfo() to retrieve some >> info, i.e. active objs, etc. They are protected by CONFIG_SLABINFO. > > Ok I guess then those need to be moved out of CONFIG_SLABINFO. Otherwise > dumping of slabs will not be supported when disabling that option. Yes. > > Or dump CONFIG_SLABINFO .. I prefer to this. It sounds pointless to keep CONFIG_SLABINFO. It is always on by default and can't be changed in menuconfig. Thanks, Yang >