From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
"David S . Miller" <davem@davemloft.net>,
Grygorii Strashko <grygorii.strashko@ti.com>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: ethernet: ti: fix spelling mistake "rundom" -> "random"
Date: Mon, 30 Mar 2020 10:52:09 -0700 [thread overview]
Message-ID: <bfc2cff78325ad2845ef0c7ec2d7ba719fd4f1a1.camel@perches.com> (raw)
In-Reply-To: <20200330101639.161268-1-colin.king@canonical.com>
On Mon, 2020-03-30 at 11:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a dev_err error message. Fix it.
[]
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
[]
> @@ -1627,7 +1627,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
> port->slave.mac_addr) ||
> !is_valid_ether_addr(port->slave.mac_addr)) {
> random_ether_addr(port->slave.mac_addr);
> - dev_err(dev, "Use rundom MAC address\n");
> + dev_err(dev, "Use random MAC address\n");
This continues without returning an error value.
Is this actually an error?
It might be useful to describe the slave and
random ethernet address too.
Perhaps:
dev_notice(dev, "%pOF slave[%d] using random MAC address %pM\n",
port_np, port_id, port->slave.mac_addr);
or maybe dev_info
prev parent reply other threads:[~2020-03-30 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 10:16 Colin King
2020-03-30 17:21 ` David Miller
2020-03-30 17:52 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfc2cff78325ad2845ef0c7ec2d7ba719fd4f1a1.camel@perches.com \
--to=joe@perches.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®