From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.229 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792560181; b=FMbjekqx/an+OCXk+7Dh1Hnq1zS9gT0Tv+KJ2WVRPzh7/5eqrVEsAb/teFKS5kgg5dW6 TgZs+QK4ovWP0gEjIqcYazViioI2fIHKuFC0Cqg9CNB5IpIVQ3MK1vBJLoEwPAR093Zfb ShE3wSyY6LxB5SRVbgtf7gjVhkDYK2Wn71jLxXUhAs/fGwO86unEPqwLWcIWxTNPLW7Iw QtvhCrhh0XvhIj3igfzl7MAJvuN2ju1UWdrEu56aAfrKtYfjY6IF2jzIkcOZ6V4XZ31C+ OIEAWl6SyMfTR9XpUA1HYUFHlmGHKSLJrd7qQfsn1v0apEyw4+b0gHpnPRlH6j7euAg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792560181; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=Swfs28hXtM8sdZG1SyRpeTzhFRqeD6kprzmA4qDc3ps=; b=UJ9lnQkwuEay3o3q1u3pZ11uOvP56xY6y5C0Elbxrgx4ZQLYhtXKgegLmDVWEg7YVh9e 705QtKAag6H1yizsUfaFgSpJID3rKPb/frEH6s7HdIjpP97obbm5GJXr2m9WyhOE4ATK4 PzAh53eVpqE445wH643QAtKnzIvb9spdcamoMDGSNPpYfaJcqvqMN1jQP+YqCTHyr36VA 1PMuFECCnE9kIFvhbzJJJNOSOcYsjxet9TjUd1ZDF135SvzwX4R163QODALbGTfgB1ex7 m6ra01pWIxMNkcSTPscg4fiS8ylOD+QSpp0Bz8U6tZgVs4fzxHo/6o9XoLC4ulIrWyg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass header.d=packett.cool header.i=@packett.cool header.a=rsa-sha256 header.s=key1 header.b=RaXdLKKd; arc=none smtp.remote-ip=91.218.175.229 Received: from mta0.migadu.com (out-229.mta0.migadu.com [91.218.175.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE972606A31E for ; Wed, 21 Oct 2026 05:22:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DE972606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=packett.cool header.i=@packett.cool header.a=rsa-sha256 header.s=key1 header.b=RaXdLKKd X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=TCPeloyadGAu87uW5ws1DgAebc3Cc2vxp0sBhDg8za0=; c=simple/simple; d=packett.cool; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792560174; v=1; x=1793164974; b=RaXdLKKdviumWYiwGHPMbHseCFipUyls44pXG9jgvwNjPZtgZSZkzZ+Zg/K95zd/1lU3pQPZ 7SlMiZ2+AdaKI8CPgfiLnmWFekeWzqsa9242nEAX0Wpmd5luBK3/HLFQW49AzXTW5PGjklRH+SD I5BdvNneDv3Jv+RcoCo5VnfUbod+tVHKKaAfMQGqbkhJPtZMMH0sAFcNsqQIhsEuGcCcc97637L BIVMJ8IKp4JD8JPubtiINSpI1qtx5gQg1Kr7NOkxeyPOQuA0C+F5iSgMRvglcBnUvwNRRN6ReYm a9PLQ0rURddlF6KK/JF74grExaAk3MOBpilL0Eo13pYLQ== X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id effd227a1c24da30; Wed, 21 Oct 2026 05:22:53 +0000 X-Mizu-Trace-ID: effd227a1c24da30 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Wed, 21 Oct 2026 02:22:48 -0300 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] bus: mhi: host: pci_generic: Update the default autosuspend_delay_ms as 5000ms To: Slark Xiao , mani@kernel.org, jeff.hugo@oss.qualcomm.com, krishna.chundru@oss.qualcomm.com Cc: loic.poulain@oss.qualcomm.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20261021024038.17127-1-slark_xiao@163.com> Content-Language: en-US From: Val Packett In-Reply-To: <20261021024038.17127-1-slark_xiao@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/20/26 11:40 PM, Slark Xiao wrote: > For some MHI devices in some specific scenario, the default value > of autosuspend_delay_ms may not enough to handle last wake event. Missing verb.. may not *be* enough > This may lead to some unexpected problems. Sounds vague, are there any examples of the problems? A short description of a concrete error message or something would be nice. > Refer to the Qualcomm's Windows settings and we checked this with > Quaclomm over case, Qualcomm recommend us to set this as 5000ms. spelliiiiing. Quaclomm? :) (also "over case" sounds odd) > Qualcomm also suggests us to update this for all MHI devices. > Since this setting has affected some existed kernel versions, it's > better to be applied to stable version. Please leave the "meta" stuff about where the commit applies outside of the commit message. > Fixes: d3800c1dce24 ("bus: mhi: pci_generic: Add support for runtime PM") > Cc: stable@vger.kernel.org > Signed-off-by: Slark Xiao > --- > v2: define a autosuspend delay timeout and explain the reason > --- > drivers/bus/mhi/host/pci_generic.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c > index 7193a384cca4..1f52542794d7 100644 > --- a/drivers/bus/mhi/host/pci_generic.c > +++ b/drivers/bus/mhi/host/pci_generic.c > @@ -21,6 +21,9 @@ > > #define MHI_POST_RESET_DELAY_MS 2000 > > +/* Add define of initial autosuspend_delay_ms to accommodate a potential 'late wake-event' issue */ Not a very necessary comment, but if you do add it, please don't write things like "Add define of". This *is* the define, we're looking at it.. Also, it's not "initial" if it's not a tunable or anything, it's just *the* delay value. > +#define MHI_AUTOSUSPEND_DELAY_MS 5000 > + > #define HEALTH_CHECK_PERIOD (HZ * 2) > > /* PCI VID definitions */ > @@ -1483,7 +1486,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > > /* Allow runtime suspend only if both PME from D3Hot and M3 are supported */ > if (pci_pme_capable(pdev, PCI_D3hot) && !(info->no_m3)) { > - pm_runtime_set_autosuspend_delay(&pdev->dev, 2000); > + pm_runtime_set_autosuspend_delay(&pdev->dev, MHI_AUTOSUSPEND_DELAY_MS); > pm_runtime_use_autosuspend(&pdev->dev); > pm_runtime_mark_last_busy(&pdev->dev); > pm_runtime_put_noidle(&pdev->dev); Thanks, ~val