mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Qun-wei Lin (林群崴)" <Qun-wei.Lin@mediatek.com>
To: "akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "Andrew Yang (楊智強)" <Andrew.Yang@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Elena Yu (余季芸)" <Elena.Yu@mediatek.com>,
	"pasha.tatashin@soleen.com" <pasha.tatashin@soleen.com>,
	"shakeel.butt@linux.dev" <shakeel.butt@linux.dev>,
	wsd_upstream <wsd_upstream@mediatek.com>,
	"Chinwen Chang (張錦文)" <chinwen.chang@mediatek.com>,
	"Casper Li (李中榮)" <casper.li@mediatek.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"kent.overstreet@linux.dev" <kent.overstreet@linux.dev>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] sched/task_stack: Fix object_is_on_stack() for KASAN tagged pointers
Date: Mon, 18 Nov 2024 03:12:59 +0000	[thread overview]
Message-ID: <bfc6291c4fadd5b7720945e6242a2f59f8f2dae3.camel@mediatek.com> (raw)
In-Reply-To: <20241112230644.cfe24aa5e863112de04b16c0@linux-foundation.org>

On Tue, 2024-11-12 at 23:06 -0800, Andrew Morton wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Wed, 13 Nov 2024 12:25:43 +0800 Qun-Wei Lin <
> qun-wei.lin@mediatek.com> wrote:
> 
> > When CONFIG_KASAN_SW_TAGS and CONFIG_KASAN_STACK are enabled, the
> > object_is_on_stack() function may produce incorrect results due to
> > the
> > presence of tags in the obj pointer, while the stack pointer does
> > not
> > have tags. This discrepancy can lead to incorrect stack object
> > detection
> > and subsequently trigger warnings if CONFIG_DEBUG_OBJECTS is also
> > enabled.
> > 
> > Example of the warning:
> 
> Thanks.
> 
> Are we able to identify when this started happening?  ie, a suitable
> Fixes: taret?
> 

The issue has been present since the introduction of
CONFIG_KASAN_STACK. The stack instrumentation was not accounted for in
the object_is_on_stack() function from the beginning.

Thanks!

      reply	other threads:[~2024-11-18  3:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13  4:25 Qun-Wei Lin
2024-11-13  7:06 ` Andrew Morton
2024-11-18  3:12   ` Qun-wei Lin (林群崴) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfc6291c4fadd5b7720945e6242a2f59f8f2dae3.camel@mediatek.com \
    --to=qun-wei.lin@mediatek.com \
    --cc=Andrew.Yang@mediatek.com \
    --cc=Elena.Yu@mediatek.com \
    --cc=akpm@linux-foundation.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=casper.li@mediatek.com \
    --cc=catalin.marinas@arm.com \
    --cc=chinwen.chang@mediatek.com \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=shakeel.butt@linux.dev \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®