From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021116.outbound.protection.outlook.com [52.101.70.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4C4A434E5C for ; Wed, 19 Aug 2026 09:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.116 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787131678; cv=fail; b=RUp50jzivw7giXgkt9iU+hhZXiRUbbg0PXr5hkc1+SRr+M7UtjGfE3asS5mfQapc0sjry8PpRR5yFTsU9FdXwnJGuACiAST8VXvnLvjQ3f6Xy/anKfHyky+/KSuqdf7tgvBo8vcojv+mrs9lbJIBHPSCrFHY6ZZHECtuGNIb1pg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787131678; c=relaxed/simple; bh=HgwwMKjg/F0zbvwg3ncawaJoUKvshSO4A0qOVbr0068=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=cJjxowwzg6JYlvZZhf/JgtMYCAbcThVkkfLlhigq82c9qdet5ZwOxo4EU1ZYItfGNJ0Xkz/TC/hfqRibBUrEM72S3MxYVyGgzvNx7jeDol/90qyZRTcSQblkorJFm4gR2OS4B2RJqSneepVLR9qC0kqRflxMPuSaEWnVdLyFLhI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=virtuozzo.com; spf=pass smtp.mailfrom=virtuozzo.com; dkim=pass (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b=JxGJVsfA; arc=fail smtp.client-ip=52.101.70.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=virtuozzo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="JxGJVsfA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CAY1HiPnNiau9fLm3K+EjJj8hQ3lWIO93yl73VmQpmSABVAgsRdNOMB9QzS3oVx6enxt4CeqMd0i570cfqgF/VfIbUV3coblkV8RQnPBmN41njfbL3yjf6jjykNfo9ofR+V9PImJyrxARKNQ7Db9NIjInoOT85sGTUa+p7zniD70RasynCj0Hcm5TGzoa5QehEaQWF+ty+ZNcqyW1E3/S/H6SSeXMgmwQJJuf3+IEjXzPd3b5EDpV+LkXNVndfvyICCYsigVarySimjsJNzAorv0d8MFIQ3VQPDvcsmooKl09BCJCYiYKFGk+e6KfK0mPtGim9UtRG9+3lF+jS/5IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWpofC50O9G4Kt/WhBnXDRYCdIC4WI3j1//tshhhC5g=; b=Qp1XZ3VxKPUV45GcKk0Dt28GsVFTBxw/On4K98TXtGbp8hHi51Limk8TUVgbmVzZVv08/dFAKZSK8DbnT14cU9UKmJqY7L69ZzHfuQZiSNyF47E11rOi+F4O8gF3K1kF5CqvfbOZ7ie3lqY0A/WhkjEJbTnDCPsodJtzMVsR01mZwaOGP+IuicYsnDOjmSnbmOI7jmru7fKEbse42neXvqD94wsNILE5o3oewxldnir02KACsDBHxkJPoqT5RA4cGodw3B/pDfBfG/JS95oaNwgO4CZrN0r3yxsm0N1zpxWX0DzSI/rO6r4Q3lHZ6ATziWY5JUTVssxVuCS92ThSdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWpofC50O9G4Kt/WhBnXDRYCdIC4WI3j1//tshhhC5g=; b=JxGJVsfAis3InoEO1iJYVYBG7CO2bP3GavrUMxNYPjiy7M7BY/TIYqdvKhsWRulRmabHlk0ToOIaVsOlKDUk7kxbhNboQVTrzBfIg3TQRCK0khwD4tQxn9OIJ3/fQVzCXmMtC01c033E239PKhA7ndcXJYaOa7ypRoawZEUbjj+Xz6lXE47TjOUz6AF6GMuaWTmMpHhgQbOYyBO47Rbg4mAT/zrBgdIY06O/53q6bJDgSmZibCR3SIN4saoclt6RU4g+4H0qM84y11KtzRS9ZCETuDInmWw97Nk563+3drKoIOLmh874tqEcgixrUo8Vuz2XrYXBqTKeIyd+wl3RFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AM0PR08MB11804.eurprd08.prod.outlook.com (2603:10a6:20b:747::14) by DU0PR08MB9025.eurprd08.prod.outlook.com (2603:10a6:10:471::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.17; Wed, 19 Aug 2026 09:27:48 +0000 Received: from AM0PR08MB11804.eurprd08.prod.outlook.com ([fe80::bf46:f137:f6d2:5b3a]) by AM0PR08MB11804.eurprd08.prod.outlook.com ([fe80::bf46:f137:f6d2:5b3a%7]) with mapi id 15.21.0315.016; Wed, 19 Aug 2026 09:27:48 +0000 Message-ID: Date: Wed, 19 Aug 2026 11:27:47 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] proc: Report SIGEV_NONE in /proc/pid/timers if target task has died To: Andrei Vagin , Thomas Gleixner , Andrew Morton Cc: linux-kernel@vger.kernel.org, criu@lists.linux.dev, Thomas Gleixner References: <20260816161216.984580-1-avagin@google.com> Content-Language: en-US From: Pavel Tikhomirov In-Reply-To: <20260816161216.984580-1-avagin@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BE1P281CA0195.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:8d::12) To AM0PR08MB11804.eurprd08.prod.outlook.com (2603:10a6:20b:747::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR08MB11804:EE_|DU0PR08MB9025:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c94716d-3be7-4c18-2755-08defdd42240 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|10070799003|366016|23010399003|6133799003|56012099006|10067099003|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: Y1t+7/zyiBB6YsfXtchAmgFJXUCqV/3jeqVIWLbFDgRycBBhw34dsKn1PvejEQwNhF0L35qqvr2cgr9zmPWLxc80ZQYZrrOtWnGQu6473hjMJTjDdhmTdnV81yuKAFJY5MDGTSRzan6V/psQQ9rWKDg7rccEu0fatsjdLIAw6pOG46190MIT9x9pJvy3ouNzmyC8cIaywmxWmNAurDP9Lty7G5yIjSvcPGr5d4QMRce+RE/pZOfibk454DgRIYwheX2GqO8Ns6lX1NpVvPS7O8P9nhOzgmOPdufxgV63oRp3ZMevTf7fngM2ZENNsIsYr899XLVkcesBQPuIo0xafOUBmcDgyI/2JwS/rLy+eSu1nUw+5Yijdqn8WX0LpzYsQdm3iVLIFkIjblkeuY/8zyU2l5Jx0X1CdywEzmQ3LG5iwCk+kkFbwHitHYLX+CVJTKlc6geZtU2B6fr6d51TGksFybSHu6OLfSxSsNFqhaJb+tHcM48uXpc44Xvq9u72p8t7vusZg6/UGjhtkTdI/1XuYYiWex2FSB3kKlb4YjSb2J2QUUwSWgScfNbZkHWT8IeLj8lEFiupZkIeR0zvQBSY3mCxNMCKVhentXZbDH8SVnKDk30fET60/ZsLTqDuTOvR8DiMvpd3H3sJXOVBvBWoP3XV1j8CZIwUuJqy0gs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB11804.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(10070799003)(366016)(23010399003)(6133799003)(56012099006)(10067099003)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEVaajVtUTdsekNYWmVZRDcvWWRiOTNBQ29mUHFXNjVZMFhEazBvY0hHVTRJ?= =?utf-8?B?S3RXSlRvWUlzcGNSbUZkbmxneitvaXdHeWU3dGZQTzhXR3VIeTRMVTNOLzBm?= =?utf-8?B?OXlrSUlza2FxbGtsVTdDcVlHeE5aaHhWem5neE9nVUN3cExaazdoM3VnaDZL?= =?utf-8?B?cnJXdm1CcDRVR3JFalhlWEFtQ0Q0dXJNWUpMWnBrUzNFbXBQT2pWR1VLcVBt?= =?utf-8?B?aG1GdkhPWU5TVUtQQUV3TlNEdEdWTWVZQWpSU2thR1VxdUVXcDFIQURtOFRk?= =?utf-8?B?dmx0NHJNeEhtSVM5Q3BPeGJ6NUdXTmpoYjJWWEFnMnhSckJNQlFBeGlkQXl4?= =?utf-8?B?eHd5WDhOR1lBaHJZNTRKdVk4NU5tMXZnYXhSZWpJOGFqZGYreVpiRFJLbjl3?= =?utf-8?B?end2ODNYdDFTQnpZbmxsUHVxcWh5M3VkT3J2WTNMV3lFc3ZJVEVJQTF4S25V?= =?utf-8?B?T3A2RThLYWRuV0wwdGdRRkJySk5Mei9PTHNGTnZ5T1ozR0t1WUtZRWpSTGlX?= =?utf-8?B?MVB5MlNXUExHb2R1eGl0Si9xcndpWXFuNGdMbVhVS0hWK0g0ajVrYUdkZm0x?= =?utf-8?B?U2duT0JnTE5MUE55ekNTSk9URnUvSUFDUlRGdzhsejFaTzl0dVc1VDhmZXB3?= =?utf-8?B?aGZXK2JMeXdjWnJNSndtZWRqaWltTGpBZS9UcHlYM3d3M1g1Ukx4L2lMclR2?= =?utf-8?B?QzAwaWZodklldGdTRTBZVVlPcEVMbS9mVnljNDlNNGs1Q25PaGN3MW5PT21U?= =?utf-8?B?QVp5WEJwelhUNUs0bVN1OEFDaDBIdVdPWG9QRnNHWllGb3QySEtJOXphSDM2?= =?utf-8?B?TXF3TUpHdnUvajN1ek9oK3crdDFwZkdEUWxONnoybzVNNXp6ZGx4emtKazBV?= =?utf-8?B?TjZPdHRqLzgxWlU2SVBGc0tyUjJxeGUxY1BoMHR4eHhDM2Joa2tpN0U1VmZq?= =?utf-8?B?RXQyMFcyUVRIcTQvR0lRRk9Fa3RZdURSR2NqZitwRFhVMXpLeGJ4Z1pwckwr?= =?utf-8?B?RUU0bkFObVNEaGlDcGo5Q2JnS3NTQnJ6S0w3Y3JiU2I0SmNpaDlvMWZ2SE5H?= =?utf-8?B?anNzTVZKT2dERHdoYTBzYjY3ZVA4Y1JxR0RvV045dnpUdXBJM2kweDFpc1ds?= =?utf-8?B?ZU9JVGkvdTNleG5QOTdBZ2k2V3JWbzBaaGZjc1QyeC9KUGxDUEQ3bWpKOWZQ?= =?utf-8?B?TzBvelYzSjhLSFZTQW4yNVUyTjVFc2tNN0Zjb2prWGphY1lOWVpKM3ZiNDA0?= =?utf-8?B?QVdKd2lZVEZMTFJrcmNzTm0yL3o2Y1hFa3JlRndEWGZqdVJzZCtZVDFRc3NH?= =?utf-8?B?VEg4NnV5SFdzOTZaVzFDdGRxc2F0NEgxKzFSYnhCZlVxaDdVZEV6NFZrZEZJ?= =?utf-8?B?R0lLbDhmNHV6VlM1N0x3WWdmZWcyY3pMY2JWVEVEZnBmd3JIYkUrbzFvSFhx?= =?utf-8?B?Mlc5TFdpb1RQSXVaUThWYUo0bHhBaDNnWk5SUWFONDBjWVNUc3V1RGJOenNP?= =?utf-8?B?d3ZGZm5NSEtXdmRGYlMrZVlxdm5JSVE3bUxqSDVMa1ltdzRweG0vejFUUkY0?= =?utf-8?B?dEtnd2VRamZNODFlMzhHd3diNTNjdHlTYlNTaWtVWHQ3V0srQks5QU9vN1My?= =?utf-8?B?MTZaM3MzNFk5MC9MdU5LSTArWmtOS1BkV1JkcVNYNmxwRFRDYjZEZmV6cG1V?= =?utf-8?B?UEJaa1IxQ3pFSUZvaVl6Y3RCZWRjcm1Uall4YmFTQTBkK3EyRHIxYzFlTzkr?= =?utf-8?B?NU5ON2JXRFBBNzNRd1A1VnREL1NiT3hGWFJmcHpoYUhVK2lNQ0F1OG1nQWJP?= =?utf-8?B?K1RVejZhQ0VXc09xNFNOMEdYWWw4NTRxZW9GNHlNR294L0F4dU13YnFkNlpt?= =?utf-8?B?VkMzOG9jWjhhN1h1SndFNUFhWW1tUFdMMkxxRmppWk1icm9OQkdqNUJOMm5Y?= =?utf-8?B?MG9rdHBaUERGRUtPRHBOKzB5bkJPWXZVcFdrVU00N0lJTm9la05zZUp0N1VS?= =?utf-8?B?WGxIN3poSEJ4b0pQZk5ydzRBRSsxUVk2bFRyV1ZhMUZCVTBCL0ZVOGRlWnRL?= =?utf-8?B?aUxkckZSQWpiOVQ2ZFQxa2VhcnVIVDJVZUJseHhwSmxwWnpzL3dJZVZwRUYy?= =?utf-8?B?ak85ZTBJcVUxV2xjOHBQQUkvdVpqYWd3NmJWLzhWUlJvRENDUldKK3FHRER3?= =?utf-8?B?Ums3TXlqSnllZkdtMHltS09VUFFIQzIxcFY3djY5eHZyeWxRUUZiZ2ZHVXRz?= =?utf-8?B?Vi9MVzh5UGRJd1BncEZGb3FiRU5SamE1NkZHMmdqVjkyM2VBSkw2R25uVTRG?= =?utf-8?B?b1ZpS3FVYm5oVzBIR1pESVhLTGc3TnRPa25adlFzTDdrODE3SURnYURpWTdQ?= =?utf-8?Q?uMd25imH0FMIexyuS60/jVJ9akdsXVCoa9W1ob6AbJC15?= X-MS-Exchange-AntiSpam-MessageData-1: 7Nf2xcjZR/EqKH8LVT/zEMsOoo3Zv6L9BCE= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c94716d-3be7-4c18-2755-08defdd42240 X-MS-Exchange-CrossTenant-AuthSource: AM0PR08MB11804.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2026 09:27:48.3956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pEqF/1fMNZACRdhDh3MCnDNf+leDhz19SpzLsPGRIjhaoNSuir7LL8yCpGrDWe4ZTHk5NRi+t+P+6XjLeouDQX34dLCEff1nw6GkRIkGUpQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9025 On 8/16/26 18:12, Andrei Vagin wrote: > When a posix timer is created targeting a specific thread (using > SIGEV_SIGNAL | SIGEV_THREAD_ID), it takes a reference to the target > struct pid in timer->it_pid. If the target thread subsequently > terminates, its numeric tid is freed and can be recycled for an > unrelated task. However, the timer holds its reference to the original > struct pid. > > show_timer() in /proc/[pid]/timers previously called pid_nr_ns() > directly on timer->it_pid without checking whether any task remained > attached to that struct pid. As a result: > 1. It reported the stale tid, which could mistakenly refer to a recycled > pid. > 2. In the kernel, expired signals for dead target threads are dropped by > posixtimer_send_sigqueue() because posixtimer_get_target() returns > NULL, so the timer functionally acts as SIGEV_NONE. > 3. Checkpoint/restore tools (CRIU) parsing /proc/[pid]/timers would try > to restore a timer with SIGEV_SIGNAL | SIGEV_THREAD_ID targeting a > non-existent or unrelated thread. > > Check pid_has_task(timer->it_pid, timer->it_pid_type) in show_timer(). > If the target task has died, override notify to SIGEV_NONE and report > PID 0 (e.g., 'notify: none/pid.0'). > > Cc: Thomas Gleixner > Signed-off-by: Andrei Vagin Reviewed-by: Pavel Tikhomirov Hopefully a useful note: Though the fixed interface is not full-proof by itself, e.g. there is still window that task alive at the time of check can be already dead at the time when userspace uses the reported pid. That gap probably can be closed easily from userspace, e.g. with taking pidfd on this reported pid and re reading the info (to make sure it's still the same task), or in CRIU we just have container processes frozen/ptrace-stopped so the reported pid task should not go away under us. > --- > fs/proc/base.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/fs/proc/base.c b/fs/proc/base.c > index 780f81259052..e3a6ea4fffea 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -2519,17 +2519,23 @@ static int show_timer(struct seq_file *m, void *v) > struct k_itimer *timer = hlist_entry((struct hlist_node *)v, struct k_itimer, list); > struct timers_private *tp = m->private; > int notify = timer->it_sigev_notify; > + pid_t nr = 0; > > guard(spinlock_irq)(&timer->it_lock); > if (!posixtimer_valid(timer)) > return 0; > > + if (timer->it_pid && pid_has_task(timer->it_pid, timer->it_pid_type)) > + nr = pid_nr_ns(timer->it_pid, tp->ns); > + else > + notify = SIGEV_NONE; > + > seq_printf(m, "ID: %d\n", timer->it_id); > seq_printf(m, "signal: %d/%px\n", timer->sigq.info.si_signo, > timer->sigq.info.si_value.sival_ptr); > seq_printf(m, "notify: %s/%s.%d\n", nstr[notify & ~SIGEV_THREAD_ID], > (notify & SIGEV_THREAD_ID) ? "tid" : "pid", > - pid_nr_ns(timer->it_pid, tp->ns)); > + nr); > seq_printf(m, "ClockID: %d\n", timer->it_clock); > > return 0; -- Best regards, Pavel Tikhomirov Senior Software Developer, Virtuozzo.