From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A3CA2F39A3 for ; Mon, 12 Jan 2026 19:13:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768245181; cv=none; b=q+9xXOupjp1WG4uWiL4s1ilrby3qnCJ+BCysgPQP5QnA/3DKFc8EWf7cOHLfhcv4Za9X7ZN0eZlg4YSYWp0OVNc3Cc/Kq1atjZX4ZRiJFN0zJtAzBuGPYtFVGwFqqH9freOSDq7ZTzgQzTgo8IZiTCN8LubNc4xw2ZIUcIwDyh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768245181; c=relaxed/simple; bh=GzJ6XVWa2r4zVf7krtugyMXldgpLAfA6hmjcVRijFUs=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=r0MiTG/ooidutunTa2Vj6F4oixaVVYMHlG2J5dU5HgxZJkx+Sg+vyvEdl+xz0ZIBswuFb8BcZRiSOVMiuPk6O455tAYnlxKAnFgrqT7sPxrJICFI8qWrJjv3RyFRjay17oI5fMiJB+pNoLRy5KV+8jZ3Y+hAmL1RQ6dx+0F6q8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ncn+/bUC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SLn5iM7q; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ncn+/bUC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SLn5iM7q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768245179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B/LS3+D2+0JGACQST8G26iX5o4ix4SU35Pj9rPbsm5Y=; b=Ncn+/bUCsljy7fWittjZy8MMBsjbRLkN9O0ju71XOZKp9h1mocWn4qKl1Kt7TDtt1URBfZ H47zEKGHUZhMR/+zV04t52M7FBN5SmEkSgFReog3P21DLwes2LjxWB89zKBu059Apb8KzB 6iJSL4gGY/2auJAtA0XCjUyeS7MRLwM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-Dr2n5cTgPxKSrv4AjMgsDw-1; Mon, 12 Jan 2026 14:12:54 -0500 X-MC-Unique: Dr2n5cTgPxKSrv4AjMgsDw-1 X-Mimecast-MFC-AGG-ID: Dr2n5cTgPxKSrv4AjMgsDw_1768245173 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47d3ffa98fcso44516225e9.3 for ; Mon, 12 Jan 2026 11:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768245173; x=1768849973; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=B/LS3+D2+0JGACQST8G26iX5o4ix4SU35Pj9rPbsm5Y=; b=SLn5iM7q4ZpRAokK7W6881x2CCw7aaISnpIDFL54g4uK74AGybpBzPhIs0rTvSw1iy dTyRokqwC48ywVSOZT+jp9WHR+V6wobwOQSumA+0T9y/2+DE9x/sGex+9O8mUa+rqLVi y9aEiaLbWHSMFoKPYi4iazfNCkqQqI7OiDoM1o2FYyz8Dbdh8H80je3VYJzlFlyrXfqy iG8NaBZZnOoq9A1Yko6WMF75csNR9szETJNF1gyTS7Sbn1FMshe4yGxHy7wsauUyGojm y1Ztx238IDpDMJiNinl1j/QS06l/TvV0EutS1Euft5GF90ngSmPuhC1yMal7Gc18RSBX OxNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768245173; x=1768849973; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B/LS3+D2+0JGACQST8G26iX5o4ix4SU35Pj9rPbsm5Y=; b=QMtjYz+SNaAu2WAWpmvoGsimdmT1N6+s9MY6Kmiaa/+3rNu0e1ru7w/8K7WnfIGOLa rpUjZVGPUrMIDB0pGgX8dof6Awri0CkNq5uJLwRapmCE/RHu95LiwIZJvYfcER4f9jjQ upiwS5UPbKhPwKco9RAvE+WvWZKK0r0OulttX85pN1MVueNPw4G5ZA7Xp3pcUsvEwQyk EWYz6TwdI5H8M7yyBaBdL3yvN0FIc878YrHB8jbsIq113ZXqJ9dT4D+xVDZCyiBl5skM TRMgCZXQ/bBitVnDAQMywUsm0nm3uNj28oL2dgfW7yiPZldYysY/97TqWTzhWNFyUggp kOZw== X-Forwarded-Encrypted: i=1; AJvYcCWznGrHZETUg16qMVifx1148AK7iCWctGdv/wGQfGQ4dmc4s3hf6yqNwitGfgSXr/ZbUttLKABjJ3G27Co=@vger.kernel.org X-Gm-Message-State: AOJu0YzRv89jhJfUh4+RTqW0zf9FxFsxJQG7e9Ure8+3oLSMdPOQiN0q NsMwBBsdC8xI+o/WaEudxq5W4bQZH9j7XJ7FYVPfstCoBidOMW+Z9ApUs8evHMKz5F+5tSvdKsY aKp8QJfCjSIuNKSoWSJ0Apt2l4OFUxqaO8pKV8e9gCQm9RuRSSkomIAhes06z4Q/2Jvl+eZep5Q == X-Gm-Gg: AY/fxX4HhUO5lWclLlmgylEf7xVdv7aM/cq3Z0uIFJFp2OxvTtNI/sEIGo1oc0Beswr TwBn6aQ1DEp3PtGW0fOBV+5UKwDSFnPTFmpq05Vn2SR8RJwrDTQbdD45COaV1Z1M8KGls9/9NAK MDcO0yVCo5YQM7Jc+u0zYZBM43IJbs3KYZcfMySWx843Lnoml6xmsWMdaDLuGI2R5HTeofwf8o1 XTp4Op1RTpgfI7225ekmaKkgSmc0q9tJk6S9Y2be2fpRcPPJq2B+qIlYXMHLFuF3h2Y085qtiXn pOnJVlClTJPEeMGv+f53LJN/VKChmXhVkYjtGir+xwAk2IMjtH0oSpqRJVOPQNksKjDTXk2NcBp myPmuIYbI3QESUxy/NYXul8Eye7sarxsR05TZ1FbHCE53t2AV9yVnt+3t5LibXAA8qjxURA== X-Received: by 2002:a05:600c:500d:b0:476:d494:41d2 with SMTP id 5b1f17b1804b1-47d84b3bc37mr166004725e9.29.1768245173363; Mon, 12 Jan 2026 11:12:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDfgCZHyxfDNzopCdhCdbmTHkg1Lro5Bs5rh2uwlheYxWEnkW5GyIfRIOS+fD5ZOP1ovVcXg== X-Received: by 2002:a05:600c:500d:b0:476:d494:41d2 with SMTP id 5b1f17b1804b1-47d84b3bc37mr166004565e9.29.1768245172924; Mon, 12 Jan 2026 11:12:52 -0800 (PST) Received: from [192.168.1.167] (cpc76484-cwma10-2-0-cust967.7-3.cable.virginm.net. [82.31.203.200]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8717a48asm141719035e9.8.2026.01.12.11.12.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 11:12:52 -0800 (PST) Message-ID: Date: Mon, 12 Jan 2026 19:12:51 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [gfs2?] WARNING in rgblk_free (2) To: syzbot , gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <69651807.050a0220.eaf7.00b2.GAE@google.com> Content-Language: en-US From: Andrew Price In-Reply-To: <69651807.050a0220.eaf7.00b2.GAE@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/01/2026 15:49, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 54e82e93ca93 Merge tag 'core_urgent_for_v6.19_rc4' of git:.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1216e5fa580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=513255d80ab78f2b > dashboard link: https://syzkaller.appspot.com/bug?extid=3e2c95229d1ab81a0bfd > compiler: Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11b4bc3a580000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1015b922580000 > > Downloadable assets: > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/d900f083ada3/non_bootable_disk-54e82e93.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/f3befb5f53a4/vmlinux-54e82e93.xz > kernel image: https://storage.googleapis.com/syzbot-assets/92820ca1dbd8/bzImage-54e82e93.xz > mounted in repro: https://storage.googleapis.com/syzbot-assets/074df7c33445/mount_0.gz > fsck result: failed (log: https://syzkaller.appspot.com/x/fsck.log?x=10da39fc580000) > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+3e2c95229d1ab81a0bfd@syzkaller.appspotmail.com > > gfs2: fsid=syz:syz.0: first mount done, others may mount > gfs2: fsid=syz:syz.0: found 1 quota changes > ------------[ cut here ]------------ > WARNING: fs/gfs2/rgrp.c:2267 at rgblk_free+0x136/0x750 fs/gfs2/rgrp.c:2267, CPU#0: syz.0.17/5483 The test is scribbling on an rindex entry's ri_data0. #syz test --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -871,11 +871,15 @@ static int rgd_insert(struct gfs2_rgrpd *rgd) rd_node); parent = *newn; - if (rgd->rd_addr < cur->rd_addr) + if (rgd->rd_addr < cur->rd_addr) { + if (rgd->rd_data0 + rgd->rd_data > cur->rd_addr) + return -EUCLEAN; newn = &((*newn)->rb_left); - else if (rgd->rd_addr > cur->rd_addr) + } else if (rgd->rd_addr > cur->rd_addr) { + if (rgd->rd_addr < cur->rd_data0) + return -EUCLEAN; newn = &((*newn)->rb_right); - else + } else return -EEXIST; } @@ -944,7 +948,8 @@ static int read_rindex_entry(struct gfs2_inode *ip) return 0; } - error = 0; /* someone else read in the rgrp; free it and ignore it */ + if (error == -EEXIST) + error = 0; /* someone else read in the rgrp; free it and ignore it */ fail_glock: gfs2_glock_put(rgd->rd_gl);