From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 9D220C4167B
	for <linux-kernel@archiver.kernel.org>; Tue, 28 Nov 2023 00:47:14 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234355AbjK1ArG convert rfc822-to-8bit (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 27 Nov 2023 19:47:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58272 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234342AbjK1Aqt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2023 19:46:49 -0500
Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5EA010D2
        for <linux-kernel@vger.kernel.org>; Mon, 27 Nov 2023 16:46:55 -0800 (PST)
Received: from omf16.hostedemail.com (a10.router.float.18 [10.200.18.1])
        by unirelay08.hostedemail.com (Postfix) with ESMTP id 8F397140141;
        Tue, 28 Nov 2023 00:46:54 +0000 (UTC)
Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA id 286CA2000F;
        Tue, 28 Nov 2023 00:46:52 +0000 (UTC)
Message-ID: <bfe9cc37ea78bd7833d22e5859495929cc896fa3.camel@perches.com>
Subject: Re: [PATCH] checkpatch: don't complain on _Static_assert and
 _Generic use
From:   Joe Perches <joe@perches.com>
To:     Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        Andy Whitcroft <apw@canonical.com>,
        linux-kernel@vger.kernel.org
Cc:     Jacob Keller <jacob.e.keller@intel.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date:   Mon, 27 Nov 2023 16:46:51 -0800
In-Reply-To: <20231127151847.52945-1-przemyslaw.kitszel@intel.com>
References: <20231127151847.52945-1-przemyslaw.kitszel@intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
X-Stat-Signature: xkkziewzj7otx8uwo1p4bccebqaku1zx
X-Rspamd-Server: rspamout04
X-Rspamd-Queue-Id: 286CA2000F
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Session-ID: U2FsdGVkX19AKWLmL6cO7if+ibDwWyhw8PX5h3djOBk=
X-HE-Tag: 1701132412-473074
X-HE-Meta: U2FsdGVkX1/XWu44x4hOZIKNJZgx2dvQriidbcB3IwaU8U82F9R/EokXlCtFlwRDLKLl7Dkt7ysW7xZ43X6pi/yA1VJWknS78/fgcuLCpJv/xmsb5zNr2U3my2ZywO3XkcWycqbIPmo2n7wHSQ+ddSku7u9UBrctOKGjwSv7tKfIvANwk2ceeQ/Kg7kzPeGZiCuIcTxxhlrGLGt90jMCbxzhvRJV1P2q4y5sjs4RjsOFJMjSatij6CoId7sFsSwH5gZNJkqYr7HMLnyAQqsrN8FIAE9VXfq2h/Yf9EaT+i/Bf9EFOpT0CeVcvBVRBbiUtSbfktEAnk2D1nj3Z6rfBtU2DFe7PMbD
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2023-11-27 at 16:18 +0100, Przemek Kitszel wrote:
> Improve CamelCase recognition logic to avoid reporting on _Static_assert()
> and _Generic() use.
> 
> Other C keywords, such as _Bool, are intentionally omitted, as those
> should be rather avoided in new source code.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -5839,6 +5839,8 @@ sub process {
>  #CamelCase
>  			if ($var !~ /^$Constant$/ &&
>  			    $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
> +#Ignore C keywords
> +			    $var !~ /_Static_assert|_Generic/ &&

You'll need

			    $var != /^(?:_Static_assert|_Generic)$/ &&

to avoid words that contain either


>  #Ignore some autogenerated defines and enum values
>  			    $var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ &&
>  #Ignore Page<foo> variants