From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754554AbdBVI3Z (ORCPT ); Wed, 22 Feb 2017 03:29:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51778 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754279AbdBVI3P (ORCPT ); Wed, 22 Feb 2017 03:29:15 -0500 Subject: Re: [PATCH 1/3] Input: silead - Add OF device ID table To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <20170221181254.14748-1-javier@osg.samsung.com> Cc: platform-driver-x86@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org From: Hans de Goede Message-ID: Date: Wed, 22 Feb 2017 09:29:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170221181254.14748-1-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 22 Feb 2017 08:29:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 21-02-17 19:12, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/input/touchscreen/silead.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c > index 404830a4a366..aae3ba1c3e02 100644 > --- a/drivers/input/touchscreen/silead.c > +++ b/drivers/input/touchscreen/silead.c > @@ -580,12 +580,26 @@ static const struct acpi_device_id silead_ts_acpi_match[] = { > MODULE_DEVICE_TABLE(acpi, silead_ts_acpi_match); > #endif > > +#ifdef CONFIG_OF > +static const struct of_device_id silead_ts_of_match[] = { > + { .compatible = "silead,gsl1680" }, > + { .compatible = "silead,gsl1688" }, > + { .compatible = "silead,gsl3670" }, > + { .compatible = "silead,gsl3675" }, > + { .compatible = "silead,gsl3692" }, > + { .compatible = "silead,mssl1680" }, > + { }, > +}; Please drop the mssl1680 compatible, that id an ACPI ugliness which we don't need for devicetree. Otherwise looks good to me. Regards, Hans > +MODULE_DEVICE_TABLE(of, silead_ts_of_match); > +#endif > + > static struct i2c_driver silead_ts_driver = { > .probe = silead_ts_probe, > .id_table = silead_ts_id, > .driver = { > .name = SILEAD_TS_NAME, > .acpi_match_table = ACPI_PTR(silead_ts_acpi_match), > + .of_match_table = of_match_ptr(silead_ts_of_match), > .pm = &silead_ts_pm, > }, > }; >