From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2899D2DC35A for ; Tue, 8 Jul 2025 14:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751984696; cv=none; b=DDClnw4mKcArDIKQnzeb6uc0lCcGNJC0fa5lFZTBIOgqB/kvbhJ0QaEBdl3XFTGPl5Hpj6oPNTJkexSf0tDQGlU0SXYkkflP1TTWDzPumoXA+LagJNsNR6bJqRw7Z+OxMumZOivOu3jKaqojPyO95BQZy5JzxEHtHP3xEg7ajUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751984696; c=relaxed/simple; bh=B+JOpbrgnQUARzMxGPuyQzQbSxpka8rFnoYh0/4Z1KA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MQNUgP7e5+2Z1D2CD3zSDQYT8yrjHs5oISJetaJusY3hOJgbILZEmMk4Lz0cKrsXT880FdNf/X13mxwgvMCa88j2MOi6KPknfIr1AhqBTG00RqemobIHfXeqNc0dHI9KQbhpLB83Jyrm6+IgW70PeeVAMLefiudIr48hMhFarYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TMfhbosk; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TMfhbosk" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a4f72cba73so3536663f8f.1 for ; Tue, 08 Jul 2025 07:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1751984692; x=1752589492; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=aGD5qf+W7iUuNQ0dw7d26qPURGpSWS6QvwWe8Qj/asg=; b=TMfhboskROtal/Z5evIqnxlGTwUW+C50ir/sD81DkDtvlxnkYir4EQ5RHW257gGp5E uZrPdpGa4wYqErExkzYT/LkTtUQAtJDxEbwTbMs/Pu8P6465vBL67zsKxViLSo22Djko jLrAyIsaAjIQmfhLihciTEOSwE7oHP4NebBCJoLuFlpdz/y9y8S2EUzFUEVGfNOpLjXR NOc50L4je/mEKpHT32AJoYe6QveSYO6e+7oZtNXf0YiFpdxouA679E5TQfvA3zX6N4MG +DnYX9TuHxjjkixbXyZ2+pTvomnTKecNG8HNI4zREd9s//mpJjzpBd4sKp0tQg5uGSX3 BbBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751984692; x=1752589492; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aGD5qf+W7iUuNQ0dw7d26qPURGpSWS6QvwWe8Qj/asg=; b=kvEfJDul9A9iNRtI5PzV3NMvP4gmE9PG5+0eBBU5iaWOtODx7Phu8Ij3nW9YyywOsY 0IcfXysoq1aLZzbHmgVMje5NNfY67iAnAbbuxp4Ha1QPlc7638p6BkUdY+vNcOpLPD9b mVZczbYolTMuiFMML9sXu7pY2jDpXj+dMCZHfg4Nd3MSIj4RXIVHJL1sRV/RWDBinm+6 IYXaY3M/gs62NNPKzFckPZfRwgXM0A6qzP9DsJr7lV6g1Nb0gXBlNfuBgHQih89NW6i9 VwVyxq+xGPiEdX+oByZZdtNJXeYncASXjY4oDuPdhx2PNmZYMInu9M9Lk1qzKlFFn99Z PQfA== X-Gm-Message-State: AOJu0YzI50RxRMoNjB4fHqSQMe5y5A+49abjjE8ZpL676dKLTrskYlMB Jom93uHw2kWPms7zspgHTRF9QkqF0j6Fwz2rQDqvao1GxW6E2A/EJLb7ZvujWRSAMgA= X-Gm-Gg: ASbGncuf+5RESw6TooyglfbkU2xKMg+jOuLGOK1FAUz4MR5IsPdRxgFmPnhQCT24wqN PMglqf+pShPR2XiyKVLImGbvu1bFdUM6OyHntsuFwk1HfNhaRLqb1DbxGKY38mWdE7UUTMtGfXd eFznYDEe4uCgKnu0cUdDDTFd4bkVkGOfrFwrG2yMkcWNqfqT31i10Ygo2w5uw0B9mDFmnzYlkuJ mVz3mTJYod39CW+LyAvsTis6XzvB0i9waD5h7zbJ22IG2NQCir8Mf1t+N8rh1ny2FzWSxq7hMw3 2ByB+QvyHO3rPJYOI2XiGkS20JA6NNJqzUP0fbNMVLip82HldkI31R+ynYR7n65yN4r1fygs6qC x9JesDpY1irtq8Q== X-Google-Smtp-Source: AGHT+IG0irpwA7N5b4P0TSBLPOgiP6YNu1Phtt6O8oEGN9SQbgz/Iv4AemaHRchokErh3x8EtRRO/A== X-Received: by 2002:a05:6000:25c1:b0:3a5:8601:613b with SMTP id ffacd0b85a97d-3b5de124084mr2471405f8f.20.1751984692315; Tue, 08 Jul 2025 07:24:52 -0700 (PDT) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [109.121.143.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030ba54sm13010634f8f.8.2025.07.08.07.24.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jul 2025 07:24:52 -0700 (PDT) Message-ID: Date: Tue, 8 Jul 2025 17:24:50 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] x86/kvm: Force legacy PCI hole as WB under SNP/TDX To: Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Dionna Glaze , Peter Gonda , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Kirill Shutemov , Vitaly Kuznetsov , "H . Peter Anvin" , Binbin Wu , Tom Lendacky References: <20250201005048.657470-1-seanjc@google.com> Content-Language: en-US From: Nikolay Borisov Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20250201005048.657470-1-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/1/25 02:50, Sean Christopherson wrote: > Attempt to hack around the SNP/TDX guest MTRR disaster by hijacking > x86_platform.is_untracked_pat_range() to force the legacy PCI hole, i.e. > memory from TOLUD => 4GiB, as unconditionally writeback. > > TDX in particular has created an impossible situation with MTRRs. Because > TDX disallows toggling CR0.CD, TDX enabling decided the easiest solution > was to ignore MTRRs entirely (because omitting CR0.CD write is obviously > too simple). > > Unfortunately, under KVM at least, the kernel subtly relies on MTRRs to > make ACPI play nice with device drivers. ACPI tries to map ranges it finds > as WB, which in turn prevents device drivers from mapping device memory as > WC/UC-. > > For the record, I hate this hack. But it's the safest approach I can come > up with. E.g. forcing ioremap() to always use WB scares me because it's > possible, however unlikely, that the kernel could try to map non-emulated > memory (that is presented as MMIO to the guest) as WC/UC-, and silently > forcing those mappings to WB could do weird things. > > My initial thought was to effectively revert the offending commit and > skip the cache disabling/enabling, i.e. the problematic CR0.CD toggling, > but unfortunately OVMF/EDKII has also added code to skip MTRR setup. :-( > > Sean Christopherson (2): > x86/mtrr: Return success vs. "failure" from guest_force_mtrr_state() > x86/kvm: Override low memory above TOLUD to WB when MTRRs are forced > WB > > arch/x86/include/asm/mtrr.h | 5 +++-- > arch/x86/kernel/cpu/mtrr/generic.c | 11 +++++++---- > arch/x86/kernel/kvm.c | 31 ++++++++++++++++++++++++++++-- > 3 files changed, 39 insertions(+), 8 deletions(-) > > > base-commit: fd8c09ad0d87783b9b6a27900d66293be45b7bad This prevents TPM from functioning which in turn breaks attestation on TDX enabled guests. So what's the status of it?