From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D1ADC4167B for ; Thu, 22 Dec 2022 10:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235033AbiLVKgX (ORCPT ); Thu, 22 Dec 2022 05:36:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229742AbiLVKgU (ORCPT ); Thu, 22 Dec 2022 05:36:20 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDC3762E5 for ; Thu, 22 Dec 2022 02:36:19 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id a19so1511407ljk.0 for ; Thu, 22 Dec 2022 02:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7+5IJIhCpMH6P+7mzwBTOjOH2P/NLSgQduJLQ+ZFZnE=; b=u/FHIhyvBTH3ODdQatZXfqJ4HUrXxu13PFK2fa9NOlw3NeibuQqgjun0GfEa9dF7CM oAq0M+I/sn1TfE2OKrB9h0aKLMIeo/rX4q++iWL++/WTC1T+mrDip2p+QcB29xsPJEm2 2zz13/tjmuEZ22VyjaljWw8yn7CWQtz/lHwmjUAgwil34KhOx3qGSbAov40TBSE7teZd 9zY+F6HxPqnTFN/JzamtSR1YwxtcaOxE3tbgs579grzgQ6YdKbBTa6oYYt3E5TseonSM zvARrajybk1yqd2xYie2gU+yLkZ117uMGqCrZQLvUSVc/JmlBtSZtauKB666rA4iv8nE nqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7+5IJIhCpMH6P+7mzwBTOjOH2P/NLSgQduJLQ+ZFZnE=; b=DozamnG0VxiPeqJ+TZgR47vjPzHtKIu9YxXB8Jd5T7JYRMXlCi+IvXa0W7+OqkggBa YZljVQ0ZWp9y8iCSgFRe2+sqUX+8rQaX2uXGO7HmRvJx0lVFhBq5aleQLmhynCYs2j33 V4PHmZGHCT098Pp5LXECsfNa+I1g2NRUADCyZikSzKL1/5HwRki93NnC2QrdGMX9daC/ sk7UrLQmVXszF4AfOBBZwwxgGPTWdJNuaeBZcSu1qKe7xTRwAorKUXxvIuJTbDY3xtH0 bQAB6kY7DWrc/FToRATrKgl7v0w5bJXsArmXPP61wBioO8XFS1nH2Q51XZAOsK12W+vf jbWg== X-Gm-Message-State: AFqh2kowRIUUz7nBlr8+x5xf29KPNU2EhcMbkodbOYr+ZihrYThPkV5r MeiUGZK1ci2U0dBmEgVmB7ArgQ== X-Google-Smtp-Source: AMrXdXsVlTloCzB2iAxBgbSBfusHqnXp2uP31OGYzPRWoJH7xgWb92tAKsblhbawpDaQgajQLr6DIA== X-Received: by 2002:a2e:9d86:0:b0:279:b96d:6f79 with SMTP id c6-20020a2e9d86000000b00279b96d6f79mr1462022ljj.20.1671705378050; Thu, 22 Dec 2022 02:36:18 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id z5-20020a05651c11c500b0027da3a87ff6sm10067ljo.83.2022.12.22.02.36.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Dec 2022 02:36:17 -0800 (PST) Message-ID: Date: Thu, 22 Dec 2022 11:36:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] dt-bindings: arm-smmu: disallow clocks when not used Content-Language: en-US To: Marijn Suijten Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Konrad Dybcio References: <20221222092355.74586-1-krzysztof.kozlowski@linaro.org> <20221222101611.nwt5arux2hcvvtvf@SoMainline.org> From: Krzysztof Kozlowski In-Reply-To: <20221222101611.nwt5arux2hcvvtvf@SoMainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/12/2022 11:16, Marijn Suijten wrote: > Is this missing a cc to linux-arm-msm? No, it is not (or maybe but then fix MAINTAINERS). The policy is to use get_maintainers.pl to CC people. > > On 2022-12-22 10:23:55, Krzysztof Kozlowski wrote: >> Disallow clocks for variants other than: >> 1. SMMUs with platform-specific compatibles which list explicit clocks >> and clock-names, >> 2. SMMUs using only generic compatibles, e.g. arm,mmu-500, which have a >> variable clocks on different implementations. >> >> This requires such variants with platform-specific compatible, to >> explicitly list the clocks or omit them, making the binding more >> constraint. >> >> Signed-off-by: Krzysztof Kozlowski > > Reviewed-by: Marijn Suijten > > But... > >> --- >> >> Cc: Marijn Suijten >> Cc: Dmitry Baryshkov >> Cc: Konrad Dybcio >> --- >> .../devicetree/bindings/iommu/arm,smmu.yaml | 28 +++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 895ec8418465..0d88395e43ad 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -367,6 +367,34 @@ allOf: >> - description: interface clock required to access smmu's registers >> through the TCU's programming interface. >> >> + # Disallow clocks for all other platforms with specific compatibles >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - cavium,smmu-v2 >> + - marvell,ap806-smmu-500 >> + - nvidia,smmu-500 >> + - qcom,qcm2290-smmu-500 >> + - qcom,qdu1000-smmu-500 >> + - qcom,sc7180-smmu-500 > > Hmm, sc7280 has two SMMUs. The one for Adreno has clocks and a PD, the sc7280 is not here, so what is the mistake you see? > one for APPS has neither. Same story on sm8[12]50. Aren't those going > to trip up the other `if` that requires clocks in both scenarios? They are not here either, so what is the error? > > Note that the Adreno SMMUs have (or will get when we/Konrad submit > support for it) the "qcom,adreno-smmu" compatible to distinguish them. > > - Marijn > Best regards, Krzysztof