mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miles Bader <miles@lsi.nec.co.jp>
To: linux-kernel@vger.kernel.org
Subject: net/sunrpc/clnt.c compilation error: tk_pid field
Date: 10 Oct 2003 17:40:00 +0900	[thread overview]
Message-ID: <buo65ixv63j.fsf@mcspd15.ucom.lsi.nec.co.jp> (raw)

With linux-2.6.0-test7, I get compilation errors like:

     CC      net/sunrpc/clnt.o
   net/sunrpc/clnt.c:965: structure has no member named `tk_pid'
   net/sunrpc/clnt.c:970: structure has no member named `tk_pid'
   net/sunrpc/clnt.c:976: structure has no member named `tk_pid'
   make[2]: *** [net/sunrpc/clnt.o] Error 1

The reason seems to be that the tk_pid field is only included in
`struct rpc_task' (defined in include/linux/sunrpc/sched.h) if
DEBUG_RPC is defined, and DEBUG_RPC is only defined if CONFIG_SYSCTL
is defined (include/linux/sunrpc/debug.h).  I've enabled NFS, but not
CONFIG_SYSCTL:

   $ egrep '(SYSCTL|NFS|RPC)' .config
   # CONFIG_SYSCTL is not set
   CONFIG_NFS_FS=y
   CONFIG_NFS_V3=y
   CONFIG_NFS_V4=y
   # CONFIG_NFSD is not set
   CONFIG_SUNRPC=y
   CONFIG_SUNRPC_GSS=y

Most code in net/sunrpc only references the tk_pid field inside of calls
to `dprintk', which is a macro that does nothing unless DEBUG_RPC is
defined; however the three lines mentioned in the error messages above
use ordinary printks, and so don't compile unless DEBUG_RPC is defined.
Perhaps these three lines should also use dprintk.

-Miles
-- 
`Life is a boundless sea of bitterness'

             reply	other threads:[~2003-10-10  8:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-10  8:40 Miles Bader [this message]
2003-10-10 15:44 ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buo65ixv63j.fsf@mcspd15.ucom.lsi.nec.co.jp \
    --to=miles@lsi.nec.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®