From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51C282E2EE4 for ; Wed, 20 Aug 2025 11:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755690056; cv=none; b=KIq6lsPz6vGFTNUwE89tgl0HxOCqHQdsqdZ0/6Jx497z0uvSjEYt0DxT+UNyezPqQavgpd+/GgAwUX2LDur5fLzB6c2MTUWHukehdInQDD4OumNbqbY5VSSKKuaG26RMzIK8TKWDnc8xRwB3J47LTFpSOGfno+tn0P/gC+R3j6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755690056; c=relaxed/simple; bh=LZ9lNwKnI9igWjqDhty8BMFySOw2pytmhPSOrssKm1g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=myj5xCgy/HhL16PIwDRxk/h+UVMIA2tyyVD6SK/k+yk89pi0DienIsmcQMk8Ay0VSFqXSxVM76QRB/YiCf0ZYYqsKGbZK5lxpYdCWhcSnDArSWJz+C2gNroIelwJtVvWc/Jayo3DJ700DV2i1aS8DAAg1iu7aUQHUiALM9HNmnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vKA/DOwp; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vKA/DOwp" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-45a1ac7c066so5138905e9.1 for ; Wed, 20 Aug 2025 04:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755690053; x=1756294853; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fBsvg6YZ6d6Q45uqCriOUykxMP3lYx/MkdCJhYtl/R8=; b=vKA/DOwp1ZX/NVOTc2ENaLymncOv4vBvB08b5qVq6mF0zHLc3HxOI54MIz5Oyp/i+5 8/NrMbB9hlkGOadiAbYLgIKaA17mgoRBlolxN1QpNW2QCoQR8grVS/TuH+2/rl8I53jP eJkbUGBTwO6izB9QVLaAPwW3zEUsVCb7dV7Bvq9y8fdyAnii37CSP71IsyCqWontGjLh u6DuOjV9HOVix5mxG+mpoB6AeCTq5+pBVcBXZQENo5XCsuHe/Rmg5mhl1Rv60cdNJuNs M+QFIJsRWUfeDj4RUfC7JPdIe4B/F1ZW3Z/1gd9MhUKLWoHAdfOa+IniVKMD8rCUKyU3 RJlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755690053; x=1756294853; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fBsvg6YZ6d6Q45uqCriOUykxMP3lYx/MkdCJhYtl/R8=; b=cG3QZV2C4oxleBm0AttzR9SjsRNjAxk6YeMwW+iC6Wm0y2a7yjhvhq3F0TRO9fFXey GQZ318vT0G4rDPbvzNoH50lHObaPg6SkIXdA8m/tCBeLIyk66+PzGICgcjQ1kqKg4lmM c3U0ipGq85lEHdXmz6T78A+pw2DFHE+TgO6CtRiNuVjxcCjZceVhz/m2omV4tNmODX4S 0gmlT8qvFEHJfdMbXQdCeFwybxtgvxVn5lP0FfUBRFKhHYYtSp5g+aMkFbmU49FmQHK6 rRpnVXlUrfSJXTVFOga5h7tBUbUHtd7aCHhu2tlKrccUwHrNXWpxf6epNYsSvMhZ+35o 93mQ== X-Forwarded-Encrypted: i=1; AJvYcCXPwr0uubo8gJyB33VfZiKoPkSZbTs729IrQLcw2mTxVOduGsmtKa0xUZfkZzYt0wxittSlli3D2Na2FRQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyeAlskIjr3sIsT93qRl8uVkBhDwxR9vCywpA6YQB2n4Bc1Whzw h0ChqoKeBovf1fSLiSOCJJY9JSqoYwJ3JcTOW7r3z+pIc0ZkEr+1uB6Q+SZ+OHNcoEs= X-Gm-Gg: ASbGncvfd7HGwRla2uiMaSu5ffjGmc8lrUrp1+qOTWDc75iixk93022srsFt/gi0TXz Ev2ItyHUAOzmFPR5PICTezmuRi4Ww3n8yeEbD5zMowDqW+wlbG3gaoz5LXfwY7sSJ4sr7Bw9Z+/ 6ewBp8tyDt9uWUS71AHhuZnP9gfVX3hifSvFH3DOUUjIzz4pM5tyPFRNV2MaFxfa47G6mYG/yiE pVAOfs37Gq5Gv1nl51JrAGP8oYVk6KiAzqFp8n417VzUz9xJshE+hUvWOHUrcS9jJv4KuJuXtWI en+TTbR4wySPkUROvZiWqymzSep6V7oVYlB4Zm9l5v+guMhA3e1oXZogS6V+Anvl5Tv5KfIwXcs NreyLQ65u0Akq6sigE+HQTuzCS7YE2afiUqoxQSzVev0saFLU/I/mkVfQJnrhgFY= X-Google-Smtp-Source: AGHT+IHXEFwMDm2kihqAnYayZR6gT+vK15GNCQ1aLgzVsq2r159WZVA/FhKSfLtVw38Kifu9RBCDaw== X-Received: by 2002:a05:600c:c494:b0:459:e39e:e5a5 with SMTP id 5b1f17b1804b1-45b4743654emr22623065e9.5.1755690052559; Wed, 20 Aug 2025 04:40:52 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b47cad57asm31636555e9.24.2025.08.20.04.40.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Aug 2025 04:40:52 -0700 (PDT) Message-ID: Date: Wed, 20 Aug 2025 12:40:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/11] firmware: qcom_scm: Introduce PAS context initialization helper To: Mukesh Ojha , Bjorn Andersson , Konrad Dybcio , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Mathieu Poirier Cc: Abhinav Kumar , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20250819165447.4149674-1-mukesh.ojha@oss.qualcomm.com> <20250819165447.4149674-2-mukesh.ojha@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250819165447.4149674-2-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/08/2025 17:54, Mukesh Ojha wrote: > Currently, remoteproc and non-remoteproc subsystems use different > variants of the MDT loader helper API, primarily due to the handling of > the metadata context. Remoteproc subsystems retain this context until > authentication and reset, while non-remoteproc subsystems (e.g., video, > graphics) do not require it. > > Unify the metadata loading process for both remoteproc and > non-remoteproc subsystems by introducing a dedicated PAS context > initialization function. You've introduced what PAS is in the cover letter but you haven't done so in the commit log where you use it. "Peripheral Authentication Service (PAS)" should be defined in this patch somewhere so we know what PAS means. > > By introducing qcom_scm_pas_ctx_init(), we can standardize the API usage > across subsystems and reduce the number of parameters passed to MDT > loader functions, improving code clarity and maintainability. > > Signed-off-by: Mukesh Ojha > --- > drivers/firmware/qcom/qcom_scm.c | 26 ++++++++++++++++++++++++++ > include/linux/firmware/qcom/qcom_scm.h | 11 +++++++++++ > 2 files changed, 37 insertions(+) > > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c > index 96d5cf40a74c..33187d4f4aef 100644 > --- a/drivers/firmware/qcom/qcom_scm.c > +++ b/drivers/firmware/qcom/qcom_scm.c > @@ -558,6 +558,32 @@ static void qcom_scm_set_download_mode(u32 dload_mode) > dev_err(__scm->dev, "failed to set download mode: %d\n", ret); > } > > +void *qcom_scm_pas_ctx_init(struct device *dev, u32 peripheral, phys_addr_t mem_phys, > + size_t mem_size, bool save_mdt_ctx) > +{ > + struct qcom_scm_pas_ctx *ctx; > + > + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return NULL; > + > + ctx->dev = dev; > + ctx->peripheral = peripheral; > + ctx->mem_phys = mem_phys; > + ctx->mem_size = mem_size; > + ctx->save_mdt_ctx = save_mdt_ctx; > + ctx->metadata = NULL; > + > + if (save_mdt_ctx) { You could check metadata != NULL and drop the bool ctx->save_mdt_ctx entirely. --- bod