From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 28DD3198E96; Wed, 13 Nov 2024 13:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731504531; cv=none; b=Zmt6p//obrnZ8lqkzd5UMbWinaPShqYN5VUtxhMIBeq1ZNtILJ3h5WFSDDA8zLBa3H4oWSKUqobH6IgNe+xjYy1xWLmecBFx3g4zE9UOrfYM22nuevkkKjWUG28T5SdTYKXJOhFPNL2wTRtLid2hzSSdrtEdrRp2zSyLeb9SpP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731504531; c=relaxed/simple; bh=pX8JITPcEXhaiBInmyV3s2awwzyAdbyKOqtBZizTfyo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VTQ6jC4yZuHbVlHEP4ZTQ4X1BuO+y5lRgHrtAC2Gozua9KVRbBa8rCwTxW9LNH5wrM+FkC+U+UM8QPbiC2UrZWPMVhM35dKJs8jqglmh1RhOeUklOoKyDgpIupTIaV1Bp68W3jgq4eP3wTYE6smFaTpTpVVVi8mvy0mViGtAhbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 60D7A1655; Wed, 13 Nov 2024 05:29:18 -0800 (PST) Received: from [10.1.29.78] (Suzukis-MBP.cambridge.arm.com [10.1.29.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7E5D43F66E; Wed, 13 Nov 2024 05:28:46 -0800 (PST) Message-ID: Date: Wed, 13 Nov 2024 13:28:45 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Coresight: Narrow down the matching range of tpdm Content-Language: en-GB To: Songwei Chai , Mike Leach , James Clark , Alexander Shishkin , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20241009091728.1638-1-quic_songchai@quicinc.com> From: Suzuki K Poulose In-Reply-To: <20241009091728.1638-1-quic_songchai@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/10/2024 10:17, Songwei Chai wrote: > The format of tpdm's peripheral id is 1f0exx. To avoid potential > conflicts in the future, update the .id_table's id to 0x001f0e00. > This update will narrow down the matching range and prevent incorrect > matches. For example, another component's peripheral id might be > f0e00, which would incorrectly match the old id. > > Fixes: b3c71626a9333b0b29f9921a39ce ("Coresight: Add coresight TPDM source driver") > Signed-off-by: Songwei Chai > --- > drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c > index b7d99e91ab84..3230d76aed90 100644 > --- a/drivers/hwtracing/coresight/coresight-tpdm.c > +++ b/drivers/hwtracing/coresight/coresight-tpdm.c > @@ -1308,8 +1308,8 @@ static void tpdm_remove(struct amba_device *adev) > */ > static struct amba_id tpdm_ids[] = { > { > - .id = 0x000f0e00, > - .mask = 0x000fff00, > + .id = 0x001f0e00, > + .mask = 0x00ffff00, > }, > { 0, 0, NULL }, > }; > Looks good to me, will queue this for v6.14. Apologies for missing the v6.13 cycle Suzuki