From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1951432AbdDYQPd (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Apr 2017 12:15:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35808 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1950202AbdDYQP0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Apr 2017 12:15:26 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 15EBD80043
Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dvlasenk@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 15EBD80043
Subject: Re: [PATCH v2] x86, msr: Document AMD "tweak MSRs", use MSR_FnnH_NAME
 scheme for them
To: Borislav Petkov <bp@alien8.de>
References: <20170425152705.13991-1-dvlasenk@redhat.com>
 <20170425160659.o5h5hb27ovwlwlei@pd.tnic>
Cc: Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
        Brian Gerst <brgerst@gmail.com>, Peter Zijlstra <peterz@infradead.org>,
        "H. Peter Anvin" <hpa@linux.intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
From: Denys Vlasenko <dvlasenk@redhat.com>
Message-ID: <c00458ef-8262-d8f5-6303-be01c4e43d3c@redhat.com>
Date: Tue, 25 Apr 2017 18:15:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20170425160659.o5h5hb27ovwlwlei@pd.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 25 Apr 2017 16:15:26 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/25/2017 06:06 PM, Borislav Petkov wrote:
> Pls no. Not every MSR for every family. Only the 4 which are actually
> being used. We can't hold in here the full 32-bit MSR space.

The replacement of four define names is not the purpose
of the proposed patch.

The patch was prompted by the realization that these particular MSRs
are so badly and inconsistently documented that it takes many hours
of work and requires reading of literally a dozen PDFs to figure out
what are their names, which CPUs have them, and what bits are known.

Anyone who looks at only one document won't see the full picture.

Patch does not document bits, but at least documents all MSR names
and explains why documentation is so sparse.

If you think it's not useful, so be it.