From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C21549F100 for ; Thu, 3 Sep 2026 12:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436837; cv=none; b=SQhbBxp16hEbd3XetT0d/jecYN6jRbu77XmPEpdOZNAoqXgMjkueHpdKu6KwWNgVHFfJq+gUhRwTeV6Z8i+GC0Gm2ZiDgLfLWEqek50k14PCX9zn/STw1OjM7+gWgWDzaSsuzHkSx0vcd/VH2V4nYH6EK8ZKwv83TLysEHWOIMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436837; c=relaxed/simple; bh=hYv0Tjkpm329P9k+TQgqKAPpwtzq68X7vpyHeYE1jHE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j3KapNVs2rT3trqbfinSXgAokpBFdXOxCO2z3AxgDxoCZqH0btVqrjxjvdPYmzh6NJ0lkU50zDBEAqnm+I6eUZoWpMtKtPNoOwQo1YeX0JLTgCxdzZEahoPnDLb1Yww7XZQmm3mIs1CcNWh4+juyf61efgJGw3dnhgRLpZAFz3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kvjv7mTH; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kvjv7mTH" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2d7195706f1so24412185ad.0 for ; Thu, 03 Sep 2026 05:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788436836; x=1789041636; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=x84L8D3771uX1JRAz3DeEhkLMS/d3fFl7+pMbK1JIwc=; b=kvjv7mTHOi7YcvKmPL+bqdpCLBoTNMQ+EGYilMjh0sbYviv2xQSSAjf8/vy6wQTHit h7w7donsSKHUetTy+NaahPfjrD+YmvkwV2tLftrqmVAaj7zfIJeBPV8CuIayacxYFQb/ JUeVX8l2OYiQDhj5x6qw16Bq1SJCv8jGfmrm9q6pxc2DB48BUR1egTlQ6NfZmoLIvul8 GPa9ckqgbB6Dq7rYw1cM64qIQopLdoUWOFMNrTxMPAjytPcMobHcUJrR+bNKutlyjsq5 aRqhP6Na+o90p7jYTJISu0qojHjueQAhSaT2bub9JDDttDxPMj9lqKOuqnbdObDSMoEV JP0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788436836; x=1789041636; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=x84L8D3771uX1JRAz3DeEhkLMS/d3fFl7+pMbK1JIwc=; b=rT+eBunpjJxkJxbULNfmY1fjAOsYm6+LJ8ZisK1tCdzxI2rPug296e4Q9jhJXDEFnW Dn2k+ZhIfmUIt6UsGXTOKnrVkki3tsplo49ZZLVpPUJkV4VKm6iNsPcna5WVfSCXH3dM Zzu2crwfvus58kKhMr4KQg8b/GgW+ZsRMd/kQoZXcYqspWvHtEKMTX24H6FCYibgYIyn IHscFf71LYCBGB+CVVu6Z59fMaNivOZimrN/vFut2uwnfMCFq212aMFVKmpctUbdq/gY z4Jjt4Mb/MwahyZhcvZ79y7jsC9Pef42mg7IP1xLVQECjAzQBhCrOOKc3xAQQGShWBo7 rYZw== X-Forwarded-Encrypted: i=1; AKwUvBywlMBD/D2m5WdupSqVeJEH/qdJlje2upn3xzVKJWvo2Tadr47BpkWCD6rmda012j/w/SGiZTCRJLrVELA=@vger.kernel.org X-Gm-Message-State: AFuF++l7MpbgXHnrRC9XYl3vEk2SeLuih04Z3IxeCMMnKiP4RSKB1X/g koHHaxTzwFLspngLKkxfazhJdfn/i+uGTTqLF7wuHLRzMWu1mJn4KCtZ X-Gm-Gg: AYBFou1wTgfeaV6oRe/sSFVasLG7uUtYL+imcQ0ozaPs4gDHexpLAaipdUy+Y8EbI33 n9pTpLBBxN9EfuIMGiDMc2KuLH7FZ/SQWu+K618J9zTd2syF8giwwNCvyJFI5WV47Ebd+2BzsG9 jp1w0j2WGFNa7KhgbclXy43qpyF6f2yAkiILwlkE1r4omnqELiSBlpZ0GBfdeFeCQiwT4G2InS7 bmek2R2mQqptXuTtAEKkKZPNeLlga1XANfjkHuKcYzUs/8eQHd2htRju0psyV0f3KXpAcgFYVcc gl9o2MSdPFpDqt+4h/C3P104//Wa1I9y+h/GfqeIZPwE6nz44XrF1UXTm5Qlf2IkXkPFU2X426B iBPw/c0h6UyJiM/kt8UijTPtc8fwu0UkTZqRqf1qcjMqJavYOw46rlhNKQAxrHRRAUqDFt7I4yT jM9z8IKkjyEpFm3yPpyD74r2oFuI+S62wIwfSiMDoX1EMk0pLyuTANRVZfO32Q4p3ZqFtemtmKH YsApZKUo7wneGVrDvjF7RS602mc6PSWCyUrBriS8KJgRFvgJw== X-Received: by 2002:a17:903:26c6:b0:2d8:d4cc:be67 with SMTP id d9443c01a7336-2daec73f1d2mr160598335ad.20.1788436835424; Thu, 03 Sep 2026 05:00:35 -0700 (PDT) Received: from ?IPV6:2406:7400:56:e503:ad72:fda5:83e8:be95? ([2406:7400:56:e503:ad72:fda5:83e8:be95]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2db01c4204csm8037835ad.66.2026.09.03.05.00.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 05:00:35 -0700 (PDT) Message-ID: Date: Thu, 3 Sep 2026 17:30:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] pmdomain: core: Rename genpd_status_on() To: Ulf Hansson , Sudeep Holla , "Rafael J . Wysocki" , Daniel Lezcano , linux-pm@vger.kernel.org Cc: Abel Vesa , Lorenzo Pieralisi , Christian Loehle , Maulik Shah , Yuanfang Zhang , Sneh Mankad , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260901111441.122436-1-ulf.hansson@oss.qualcomm.com> <20260901111441.122436-2-ulf.hansson@oss.qualcomm.com> Content-Language: en-US From: Dhruva G In-Reply-To: <20260901111441.122436-2-ulf.hansson@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Ulf, On 01-09-2026 16:44, Ulf Hansson wrote: > Let's rename the internal function genpd_status_on() to > genpd_status_on_unlocked() to clarify its use. > > Suggested-by: Abel Vesa > Signed-off-by: Ulf Hansson > --- Optional: An additional line explaining why this otherwise unnecessary rename exists: Rename the accessor to leave genpd_status_on() available for a lock-taking wrapper introduced in a future commit. > > Changes in v2: > - New patch. > > --- > drivers/pmdomain/core.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c > index 842c4169e290..6ac1ce18fda3 100644 > --- a/drivers/pmdomain/core.c > +++ b/drivers/pmdomain/core.c > @@ -173,7 +173,7 @@ static const struct genpd_lock_ops genpd_raw_spin_ops = { > #define genpd_lock_interruptible(p) p->lock_ops->lock_interruptible(p) > #define genpd_unlock(p) p->lock_ops->unlock(p) > > -#define genpd_status_on(genpd) (genpd->status == GENPD_STATE_ON) > +#define genpd_status_on_unlocked(genpd) (genpd->status == GENPD_STATE_ON) > #define genpd_is_irq_safe(genpd) (genpd->flags & GENPD_FLAG_IRQ_SAFE) > #define genpd_is_always_on(genpd) (genpd->flags & GENPD_FLAG_ALWAYS_ON) > #define genpd_is_active_wakeup(genpd) (genpd->flags & GENPD_FLAG_ACTIVE_WAKEUP) > @@ -771,7 +771,7 @@ EXPORT_SYMBOL_GPL(dev_pm_genpd_rpm_always_on); > * @dev: Device to get the current power status > * > * This function checks whether the generic power domain associated with the > - * given device is on or not by verifying if genpd_status_on equals > + * given device is on or not by verifying if genpd_status_on_unlocked equals > * GENPD_STATE_ON. Since we're fixing this anyway, It should describe comparing genpd->status with GENPD_STATE_ON, not the macro which expands to that logic ;) Anyway, nits only, LGTM otherwise. Reviewed-by: Dhruva Gole