From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3433AC7EE25 for ; Tue, 16 May 2023 15:39:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233950AbjEPPjh (ORCPT ); Tue, 16 May 2023 11:39:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233916AbjEPPjf (ORCPT ); Tue, 16 May 2023 11:39:35 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39D76903E for ; Tue, 16 May 2023 08:39:22 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-96b0235c10bso612704066b.3 for ; Tue, 16 May 2023 08:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684251558; x=1686843558; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G37gzrMu4TqK3kGvjNsx+P6G+3xLLe+mvP0p2BsUJuc=; b=UM7HBXtYHBlkNTuMj+HwCqBEVIyYYw2iT0ZXMJPPtDZ4GC1nYgOwmR5hE4JfQHT4aW LM3O/XRIzhTxU03zYp91oljWmDr+e6TktfwkvH2QwtRrSzj671cRJgloCRm2zwVynyEH MQuspYnJC5C5RdUCduxTS+GzOnq6TIN9y+NAJY8gdhGUbQnbWz8GLNomXL+g0pamOzLO a2q3kJZuiTNqlHtfcPURNK/IVTFWKuXDYWNqmvMw7yOWasfCHXM2qnz0q3ixkxsBkACj o3+pFhC/S53Dh06C7TYzmZGclLU7z6G/0D58FGQxByubjEY6Dcwfti4mLAKhcOIncd2a gpbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684251558; x=1686843558; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G37gzrMu4TqK3kGvjNsx+P6G+3xLLe+mvP0p2BsUJuc=; b=R8ku0zQzkpnVUnx3UNanznkO2pQyC1ScaiJSymncBL9IgGS9tZYR91++lBB8lrVCLM Vd71B4paSD4U9vWfDguTQVUXFjM1CMUjxMK4Defam7KaRsD0plMW563Tyhtsi9sGfzqi oH4IcIXSL0NyL0naSljm4lC3drw5WqyoOgDxprAYWnOwwkzoL7yQ/AHl5+rrXD2dckmP pNEYmOiIgZFUncd25UVn2gmoFCexYkIwH1jX0fatjdAwTQxz8UxJRtG+0VueEKmgEL9O DkQk4mUGeY3mw8MdlnLVmueTeh5jFr56hDT3vfpwhc20FDC3CaXl0EXRcdRqS8XsNm3h Sh9Q== X-Gm-Message-State: AC+VfDxiZ8utMqll/GTQO3sKmaQsmVeB1Mwktj1ahxYDxgdtZ5l6+ECg Yhl52/8ou4E41/jzdOigJAI6lA== X-Google-Smtp-Source: ACHHUZ6trXVDo9j17RfS2X15UIE+hBBVGAWrNQuzSGoEqtYQTusV9ZiU/sOkVMj+eabrQgFBtQNjiA== X-Received: by 2002:a17:906:974e:b0:96a:4c61:3c87 with SMTP id o14-20020a170906974e00b0096a4c613c87mr18849630ejy.71.1684251558104; Tue, 16 May 2023 08:39:18 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:77d1:16a1:abe1:84fc? ([2a02:810d:15c0:828:77d1:16a1:abe1:84fc]) by smtp.gmail.com with ESMTPSA id gv15-20020a1709072bcf00b0095337c5da35sm11348656ejc.15.2023.05.16.08.39.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 08:39:17 -0700 (PDT) Message-ID: Date: Tue, 16 May 2023 17:39:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] arm64: dts: qcom: sm8550-qrd: add display and panel Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Neil Armstrong , "Signed-off-by : Abel Vesa" References: <20230516151708.213744-1-krzysztof.kozlowski@linaro.org> <8b670310-47b3-c301-99ae-84ccb704d733@linaro.org> <2bc16f9a-e150-b3d0-6d72-a2ff0a4d05ae@linaro.org> <894282af-fdfa-d476-fe9a-677db6483501@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <894282af-fdfa-d476-fe9a-677db6483501@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/05/2023 17:36, Konrad Dybcio wrote: >>>> But don't we want to disable both when display is not used (not connected)? >>> The MDSS bus device only has a 0x1000 slice of the 0x90000-long "full MDSS", >>> the rest is probed with MDP/DPU. It also calls of_something_populate that >>> make DSI, DSIPHY and DP/HDMI probe. But all of them ultimately need a graph >>> handle to MDP. >>> >>> If we have a display (of any kind), MDP has to be enabled (or the display >>> engine will not have a way to be programmed). >>> >>> If we don't, enabling MDSS makes no sense as all of the hardware will be >>> shut down right after probing. >>> >>> So I'd say either both or none. >> >> Yes, so the current state - both disabled - is matching it. > Right, but what i was trying to say is that if we leave MDP without > any status properties, it will follow MDSS. Ah, I missed that it is MDSS child, so indeed there is no point to have it explicitly disabled. I'll fix it. Best regards, Krzysztof