From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748AAC04A6B for ; Wed, 8 May 2019 16:42:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44846216F4 for ; Wed, 8 May 2019 16:42:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728539AbfEHQmS (ORCPT ); Wed, 8 May 2019 12:42:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:18754 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727786AbfEHQmR (ORCPT ); Wed, 8 May 2019 12:42:17 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2019 09:42:16 -0700 X-ExtLoop1: 1 Received: from mayalewx-mobl1.amr.corp.intel.com (HELO [10.255.230.159]) ([10.255.230.159]) by fmsmga006.fm.intel.com with ESMTP; 08 May 2019 09:42:15 -0700 Subject: Re: [alsa-devel] [RFC PATCH 1/7] soundwire: Add sysfs support for master(s) To: Greg KH , Vinod Koul Cc: alsa-devel@alsa-project.org, tiwai@suse.de, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, joe@perches.com, Sanyog Kale References: <20190504010030.29233-1-pierre-louis.bossart@linux.intel.com> <20190504010030.29233-2-pierre-louis.bossart@linux.intel.com> <20190504065242.GA9770@kroah.com> <20190507052732.GD16052@vkoul-mobl> <20190507055432.GB17986@kroah.com> <20190507110331.GL16052@vkoul-mobl> <20190507111956.GB1092@kroah.com> <10fef156-7b01-7a08-77b4-ae3153eaaabc@linux.intel.com> <20190508074606.GV16052@vkoul-mobl> <20190508091628.GB1858@kroah.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 8 May 2019 11:42:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190508091628.GB1858@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/8/19 4:16 AM, Greg KH wrote: > On Wed, May 08, 2019 at 01:16:06PM +0530, Vinod Koul wrote: >> On 07-05-19, 17:49, Pierre-Louis Bossart wrote: >>> >>>>> The model here is that Master device is PCI or Platform device and then >>>>> creates a bus instance which has soundwire slave devices. >>>>> >>>>> So for any attribute on Master device (which has properties as well and >>>>> representation in sysfs), device specfic struct (PCI/platfrom doesn't >>>>> help). For slave that is not a problem as sdw_slave structure takes care >>>>> if that. >>>>> >>>>> So, the solution was to create the psedo sdw_master device for the >>>>> representation and have device-specific structure. >>>> >>>> Ok, much like the "USB host controller" type device. That's fine, make >>>> such a device, add it to your bus, and set the type correctly. And keep >>>> a pointer to that structure in your device-specific structure if you >>>> really need to get to anything in it. >>> >>> humm, you lost me on the last sentence. Did you mean using >>> set_drv/platform_data during the init and retrieving the bus information >>> with get_drv/platform_data as needed later? Or something else I badly need >>> to learn? >> >> IIUC Greg meant we should represent a soundwire master device type and >> use that here. Just like we have soundwire slave device type. Something >> like: >> >> struct sdw_master { >> struct device dev; >> struct sdw_master_prop *prop; >> ... >> }; >> >> In show function you get master from dev (container of) and then use >> that to access the master properties. So int.sdw.0 can be of this type. > > Yes, you need to represent the master device type if you are going to be > having an internal representation of it. Humm, confused...In the existing code bus and master are synonyms, see e.g. following code excerpts: * sdw_add_bus_master() - add a bus Master instance * @bus: bus instance * * Initializes the bus instance, read properties and create child * devices. struct sdw_bus { struct device *dev; <<< pointer here unsigned int link_id; struct list_head slaves; DECLARE_BITMAP(assigned, SDW_MAX_DEVICES); struct mutex bus_lock; struct mutex msg_lock; const struct sdw_master_ops *ops; const struct sdw_master_port_ops *port_ops; struct sdw_bus_params params; struct sdw_master_prop prop; The existing code creates a platform_device in drivers/soundwire/intel_init.c, and it's assigned by the following code: static int intel_probe(struct platform_device *pdev) { struct sdw_cdns_stream_config config; struct sdw_intel *sdw; int ret; sdw = devm_kzalloc(&pdev->dev, sizeof(*sdw), GFP_KERNEL); [snip] sdw->cdns.dev = &pdev->dev; sdw->cdns.bus.dev = &pdev->dev; I really don't see what you are hinting at, sorry, unless we are talking about major surgery in the code.