From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757987AbdKGQRM (ORCPT ); Tue, 7 Nov 2017 11:17:12 -0500 Received: from esa6.dell-outbound.iphmx.com ([68.232.149.229]:17190 "EHLO esa6.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757701AbdKGQRK (ORCPT ); Tue, 7 Nov 2017 11:17:10 -0500 From: X-LoopCount0: from 10.166.132.195 X-IronPort-AV: E=Sophos;i="5.44,359,1505797200"; d="scan'208";a="170650176" X-DLP: DLP_GlobalPCIDSS To: CC: , , , Subject: RE: [PATCH 0/2] Account for uncorrectable failures in probing Thread-Topic: [PATCH 0/2] Account for uncorrectable failures in probing Thread-Index: AQHTVMCj5WThkTmn/0+au/KSDeZU6aMJHY2Q Date: Tue, 7 Nov 2017 16:17:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA7GHGT2014352 > -----Original Message----- > From: Limonciello, Mario > Sent: Friday, November 3, 2017 11:27 AM > To: dvhart@infradead.org; Andy Shevchenko > Cc: LKML ; platform-driver-x86@vger.kernel.org; > pali.rohar@gmail.com; Limonciello, Mario > Subject: [PATCH 0/2] Account for uncorrectable failures in probing > > Pali raised some concerns around corner case scenarios that probing > may fail on dell-wmi-descriptor causing dell-wmi and dell-smbios-wmi > to be stuck in infinite deferred probing loops. > > This patch series accounts for that corner case. > > Changes since original submission: > - Add as second patch that catches potential NULL pointer > - Avoid potential race condition between driver init and calling > check for if validation successful > Mario Limonciello (2): > platform/x86: dell-wmi-descriptor: check if memory was allocated > platform/x86: dell-*wmi*: Relay failed initial probe to dependent > drivers > > drivers/platform/x86/dell-smbios-wmi.c | 4 ++++ > drivers/platform/x86/dell-wmi-descriptor.c | 16 ++++++++++++++++ > drivers/platform/x86/dell-wmi-descriptor.h | 7 +++++++ > drivers/platform/x86/dell-wmi.c | 5 +++++ > 4 files changed, 32 insertions(+) > > -- > 2.14.1 Pali, Did you have any thoughts on these two patches? I believe they should account for the concerns you raised regarding the corner cases with probing in my series. The series is queued up in the platform-drivers-x86 testing branch and they are intended to be on top of that. Thanks,