From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D26DC4727D for ; Fri, 25 Sep 2020 14:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E7322086A for ; Fri, 25 Sep 2020 14:00:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="Eqaqt8aP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbgIYOAy (ORCPT ); Fri, 25 Sep 2020 10:00:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:50492 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728330AbgIYOAy (ORCPT ); Fri, 25 Sep 2020 10:00:54 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1601042452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fgydADyCw89aBbyJRs5VBaKQ6Mc9dhZddkJCrlc6Emw=; b=Eqaqt8aPxRLLuyUjanMNQGx2Gq+j9mNtvrFqaZLAfL/rLUZ0fdQXLNvnwHjPdksXkrqo9k 7yZytCFPaAJ5GcrGRgoW0ri2SFC2378A2kszoZJ/oV1j1fM8zLTsA5DASeSvLV8GyVi9lG P26u06zjylzRjM58GLkcfhybZMIIxmw= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6CD4FAF49; Fri, 25 Sep 2020 14:00:52 +0000 (UTC) Subject: Re: [PATCH] x86/xen: disable Firmware First mode for correctable memory errors To: boris.ostrovsky@oracle.com, Juergen Gross , x86@kernel.org, linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , stable@vger.kernel.org References: <20200925101148.21012-1-jgross@suse.com> <171970df-5f6e-5a2b-e784-e62d300a005b@oracle.com> From: Jan Beulich Message-ID: Date: Fri, 25 Sep 2020 16:00:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <171970df-5f6e-5a2b-e784-e62d300a005b@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.09.2020 15:45, boris.ostrovsky@oracle.com wrote: > On 9/25/20 6:11 AM, Juergen Gross wrote: >> @@ -1296,6 +1296,14 @@ asmlinkage __visible void __init xen_start_kernel(void) >> >> xen_smp_init(); >> >> +#ifdef CONFIG_ACPI >> + /* >> + * Disable selecting "Firmware First mode" for correctable memory >> + * errors, as this is the duty of the hypervisor to decide. >> + */ >> + acpi_disable_cmcff = 1; >> +#endif > > > Not that it matters greatly but should this go under if (xen_initial_domain()) > clause a bit further down? Yes - DomU-s are supposed to be in charge of their (virtual) firmware, no matter that right now APEI for guests is completely out of sight as far as I'm aware. Jan