mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Mike Lothian <mike@fireburn.co.uk>, Alex Deucher <alexdeucher@gmail.com>
Cc: amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
	christian.koenig@amd.com, dri-devel@lists.freedesktop.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/amdgpu: runtime resume dGPU on ACPI notify from its own node
Date: Fri, 30 Oct 2026 09:52:08 -0500	[thread overview]
Message-ID: <c018e549-6d31-40fc-9b82-05b53d4dac22@kernel.org> (raw)
In-Reply-To: <20261030075735.356811-1-mike@fireburn.co.uk>

On 10/30/26 02:57, Mike Lothian wrote:
> On Thu, 29 Oct 2026, Alex Deucher wrote:
>> I'm not sure about BACO.  In the BOCO case the OEM has a mux on the HPD
>> pins that redirects them to the EC when the dGPU is powered off.  For
>> BACO it's usually a PCIe add-in board so there is no way to redirect
>> the HPD pins.
> 
> Agreed, and I can't test BACO anyway, so I'll keep it BOCO only in v2
> Mario, sorry, I'll leave your BACO suggestion out unless someone has a
> board that needs it

No problem.

> 
>> Mike Lothian does your system have ATIF?  This is already code to
>> handle this.  It sounds like it's just registering the wrong ACPI node.
>> You should be able to use the existing handler.
> 
> It does, but only on the iGPU: ATIF is in SSDT7 under \_SB.PCI0.GP17.VGA_,
> and the dGPU node (\_SB.PCI0.GPP0.SWUS.SWDS.VGA_) has none
> 
> What arrives here isn't an ATIF notification either.  _L05 in SSDT9 is
> just Notify (\_SB.PCI0.GPP0.VGA, 0x81), and that path doesn't exist on
> this board, so the interpreter aborts the method with AE_NOT_FOUND and no
> Notify is delivered to anything.  I've put the tables and the errors in
> a bug: https://gitlab.freedesktop.org/drm/amd/-/work_items/6061

Yeah looking at the tables this does look like a BIOS bug.  So quirking 
it somewhere feels appropriate.

> 
> What I haven't checked is whether the firmware would flag a dGPU display
> event in the ATIF SBIOS requests if the Notify did arrive at the right
> node.  If I alias the path so it resolves, I can turn on drm.debug and see
> whether amdgpu_atif_handler() fires and what request flags come back, and
> if ATIF_DGPU_DISPLAY_EVENT is set I'll use the existing handler rather
> than add a new one.  I'll report back
> 
> Mike


  reply	other threads:[~2026-10-30 14:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 15:14 [PATCH 0/2] drm/amdgpu: wake a powered-off dGPU on a dock hotplug notify Mike Lothian
2026-10-29 15:14 ` [PATCH 1/2] drm/amdgpu: runtime resume dGPU on ACPI notify from its own node Mike Lothian
2026-10-29 15:20   ` Mario Limonciello
2026-10-29 16:05     ` Alex Deucher
2026-10-30  7:57       ` Mike Lothian
2026-10-30 14:52         ` Mario Limonciello [this message]
2026-10-29 15:14 ` [PATCH 2/2] drm/amdgpu: handle broken dGPU hotplug GPE on ASUS ROG Strix G513QY Mike Lothian
2026-10-29 15:24   ` Mario Limonciello
2026-10-30  7:57     ` Mike Lothian
2026-10-30 14:55       ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c018e549-6d31-40fc-9b82-05b53d4dac22@kernel.org \
    --to=superm1@kernel.org \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike@fireburn.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®