From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C043EC10F00 for ; Thu, 28 Mar 2019 01:37:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9936B2070B for ; Thu, 28 Mar 2019 01:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728210AbfC1Bhv (ORCPT ); Wed, 27 Mar 2019 21:37:51 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:50640 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726143AbfC1Bhv (ORCPT ); Wed, 27 Mar 2019 21:37:51 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id E123227FB41 Message-ID: Subject: Re: [PATCH] media: mtk-vcodec: fix access to incorrect planes member From: Ezequiel Garcia To: Alexandre Courbot , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 27 Mar 2019 22:37:39 -0300 In-Reply-To: <20190326074423.123864-1-acourbot@chromium.org> References: <20190326074423.123864-1-acourbot@chromium.org> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-03-26 at 16:44 +0900, Alexandre Courbot wrote: > Commit 0650a91499e0 ("media: mtk-vcodec: Correct return type for mem2mem > buffer helpers") fixed the return types for mem2mem buffer helper > functions by changing a few local variables from vb2_buffer to > vb2_v4l2_buffer. However, it left a few accesses to vb2_buffer::planes > as-is, accidentally turning them into accesses to > vb2_v4l2_buffer::planes and resulting in values being read from/written > to the wrong place. > > Fix this by inserting vb2_buf into these accesses so they mimic their > original behavior. > > Fixes: 0650a91499e0 ("media: mtk-vcodec: Correct return type for mem2mem buffer helpers") > Hm, having these multiple "vb2_planes planes" fields is extremely confusing! Reviewed-by: Ezequiel Garcia Thanks for fixing this, Eze > Signed-off-by: Alexandre Courbot > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 ++-- > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 10 +++++----- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c > index a85c7cc8328e..e20b340855e7 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c > @@ -388,7 +388,7 @@ static void mtk_vdec_worker(struct work_struct *work) > } > buf.va = vb2_plane_vaddr(&src_buf->vb2_buf, 0); > buf.dma_addr = vb2_dma_contig_plane_dma_addr(&src_buf->vb2_buf, 0); > - buf.size = (size_t)src_buf->planes[0].bytesused; > + buf.size = (size_t)src_buf->vb2_buf.planes[0].bytesused; > if (!buf.va) { > v4l2_m2m_job_finish(dev->m2m_dev_dec, ctx->m2m_ctx); > mtk_v4l2_err("[%d] id=%d src_addr is NULL!!", > @@ -1155,7 +1155,7 @@ static void vb2ops_vdec_buf_queue(struct vb2_buffer *vb) > > src_mem.va = vb2_plane_vaddr(&src_buf->vb2_buf, 0); > src_mem.dma_addr = vb2_dma_contig_plane_dma_addr(&src_buf->vb2_buf, 0); > - src_mem.size = (size_t)src_buf->planes[0].bytesused; > + src_mem.size = (size_t)src_buf->vb2_buf.planes[0].bytesused; > mtk_v4l2_debug(2, > "[%d] buf id=%d va=%p dma=%pad size=%zx", > ctx->id, src_buf->vb2_buf.index, > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > index c6b48b5925fb..50351adafc47 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > @@ -894,7 +894,7 @@ static void vb2ops_venc_stop_streaming(struct vb2_queue *q) > > if (q->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { > while ((dst_buf = v4l2_m2m_dst_buf_remove(ctx->m2m_ctx))) { > - dst_buf->planes[0].bytesused = 0; > + dst_buf->vb2_buf.planes[0].bytesused = 0; > v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_ERROR); > } > } else { > @@ -947,7 +947,7 @@ static int mtk_venc_encode_header(void *priv) > > bs_buf.va = vb2_plane_vaddr(&dst_buf->vb2_buf, 0); > bs_buf.dma_addr = vb2_dma_contig_plane_dma_addr(&dst_buf->vb2_buf, 0); > - bs_buf.size = (size_t)dst_buf->planes[0].length; > + bs_buf.size = (size_t)dst_buf->vb2_buf.planes[0].length; > > mtk_v4l2_debug(1, > "[%d] buf id=%d va=0x%p dma_addr=0x%llx size=%zu", > @@ -976,7 +976,7 @@ static int mtk_venc_encode_header(void *priv) > } > > ctx->state = MTK_STATE_HEADER; > - dst_buf->planes[0].bytesused = enc_result.bs_size; > + dst_buf->vb2_buf.planes[0].bytesused = enc_result.bs_size; > v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE); > > return 0; > @@ -1107,12 +1107,12 @@ static void mtk_venc_worker(struct work_struct *work) > > if (ret) { > v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR); > - dst_buf->planes[0].bytesused = 0; > + dst_buf->vb2_buf.planes[0].bytesused = 0; > v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_ERROR); > mtk_v4l2_err("venc_if_encode failed=%d", ret); > } else { > v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE); > - dst_buf->planes[0].bytesused = enc_result.bs_size; > + dst_buf->vb2_buf.planes[0].bytesused = enc_result.bs_size; > v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE); > mtk_v4l2_debug(2, "venc_if_encode bs size=%d", > enc_result.bs_size);