From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3DCD3D3009 for ; Tue, 10 Mar 2026 07:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773126885; cv=none; b=XRRjaOnG6WZ/1P1HYKMZwFRMk6Lj7qYuZ1q4qT/mSGQEysAoWDvoVc3C1PPK5SLyUSkpRILoC6n151iZdv/vSxwvK+FsGz1mLck5W3jnSxPidNTa7vEoQItHqAW+k34X4b0VUw/6TfDjrXSPo5Ie6ZSgEShDZydv+Y9fE7MMif8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773126885; c=relaxed/simple; bh=eodG08hd7H2+4eEqRidkXn2k69I15r4MG0U60TKAyTg=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=daD9fYnaQa4Rd6Q0cmQvgFmPFxR/O2zYJFQBF4iw13cU+LZqNe9tx6ZgZlKdVeVCcgz6BS96r0tUQKI2MShHEhdcELg1rqaQ13mOL6UC+mC06v1J841GUAXwsLDicArWGA8bYWQdsd6n8ZFlf2Vj/jvZqnvNdqhSdwAugspxPa0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SF7TJVL5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jbBRdrLf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SF7TJVL5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jbBRdrLf" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A2F5Zm3088460 for ; Tue, 10 Mar 2026 07:14:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WUk9/yYDjpm7Lct9/O3j2FSRijHPmYsf/qPfBafPYuo=; b=SF7TJVL55NJvYKm7 0LmwUKTDG54qxXVWyXbilLsMrggjcfzx0t/wvsyroAdGm328uW0PnybO5LsvN8to XZbLKhsZ3g6dIUW5FXY+0mURtHBTSo75+iJlN2YUhvH30JMgGpF5DKz7xHAerq7v hP5/4PdTGu511BHqzH1y+DnrjRSliDpuhUXmuPY8OPhysjI19Y01OW2ZdY2SYAbA ZNTzy1AFegGNKHphrK4msRiCL1e/DioMr1o0+iVQfVyBu3Fh0xJJh3fE0HVyu2ax nnLZ68yOUk4OnS2pB6PVnrAJ8IaKn2ZHJAGwX1HlHs+o2+H7msRzPTnfS2EPCGge knaQpw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csxy8389f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 07:14:44 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae53ec06b0so448836535ad.0 for ; Tue, 10 Mar 2026 00:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773126883; x=1773731683; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WUk9/yYDjpm7Lct9/O3j2FSRijHPmYsf/qPfBafPYuo=; b=jbBRdrLfPNvwg0Oi3ANK0lTmS7pNItgb8osu07EJ7+OZKdeVyt0U960+neFaKEhLXE TcuI7S/pBSWZiDCJ7fOj1H1PQZc98ijp5z9q3ZX5oJIriNiv6OwGXdvGHPV+H6K5aq6e ZUEPAJYq847UOH2nKSqE3sJS+pyHc1NiDOzjG+PIaDQL3MipgCo3mmT0Hcy4MJXR7/Mj ttpNqUKSfleHjUL99w+e49DnhpaDBXViqumx6rq8duJ7he7I6t3Xso1seTJYk0cRP8aJ NIRRqGElO7pU4GRa2i/enX+Bi8gG945CQOlHAfpbmcdKbYnWKYTHqkyShO1zaRfAt2lX XYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773126883; x=1773731683; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WUk9/yYDjpm7Lct9/O3j2FSRijHPmYsf/qPfBafPYuo=; b=ij07iCD24rW9pnoiCXSqHCf9x7r9ikXuTBIpqRYhnQzV9UHMisGywfAAFvhCTUAOVB C37icxfDhh1Bd47oMta2qBS9migfe/ZpzVut3X0poqmuQk2GVXM+LuQeg+smGhfybKFz ui/KKNABB+Oh0OEHUy8xtalycTnr1t3qkYQHSZhIqHcW53dL3oq2LnHQTheqzJRRCaOD lrt4LBPn7kkLfUn9fJYvcTi7ovrH+Gy4tAS9LRcqTv3LbkCPsexHKdZPqIdFbu1dp0jE 5LWsfjlf3dghnx/TSzv7o9Pv6ZtcA00yg43u7q9ectoZa1Pqe0kiEDypnePQSEPyotq4 +Jkw== X-Forwarded-Encrypted: i=1; AJvYcCWe2kkVnrP6KQaQv0msh7/TMkbTaQFWz1nwUMJtbFNrO8QG94mf75fSA5GEpK/IS2o6HSsBkO3FsZzldc4=@vger.kernel.org X-Gm-Message-State: AOJu0YyJmzbZEIRh0aVV//NiNGtLwEy1rbC00VxHBnGL+wa9V7PHkd7j 6cZMJpkhbTDuJrZQ557ehN4HRNZjRwGfvm5q8lpdt3fIyIHTkYfzFX055+EMI3thU76QzqRrpE4 cdrUZQARBBIroQa5oAfpuHPILtwkutLriy4xvvE4mHTffikxX2KeGWLBo/SAOeXhWRIA= X-Gm-Gg: ATEYQzydG08wUE2DaE9KNz657YVyMHTcOYZseL3VDzM5cGj9XI3dv8HFZkKNp+tpQn/ yY84fc0ysSIaFGQFdW8ANmV/BICP7F6iJCmYMd5LjGUFW39Z69ONBrUO6qQ4YOnmGKR3UvSvkbd k05Vw0hTRsJlL10WLsUw2JI4w3lyc30fhhyn0NTUqK3ppyR+v/HP/Use1h7T05vNR1TW//h4mlU ij0vdrsNqzlW6q6BtW4pLDyudNTmGRhr3WypDYAUSqbKKRae49wSi3phXBEXAcW9wDs/NkoPVa9 f4NoJpXh8c18wPON5B3mChejVpQa9SQuZe8ryAEj4NtCli+5WAAVsQEqgZmNuUCb5iiaqDisD0H hDUbaE1uVpYN3zCZgRdCSXDCosBDM8ovTkRzib1tLZRt/taO4gu8aqu47qgNg9WRjYf77Plv+I/ Uu+NRUuCVaq5WMoMw= X-Received: by 2002:a17:903:2288:b0:2ae:5104:571e with SMTP id d9443c01a7336-2ae82366c4bmr156151845ad.9.1773126883433; Tue, 10 Mar 2026 00:14:43 -0700 (PDT) X-Received: by 2002:a17:903:2288:b0:2ae:5104:571e with SMTP id d9443c01a7336-2ae82366c4bmr156151655ad.9.1773126882992; Tue, 10 Mar 2026 00:14:42 -0700 (PDT) Received: from [10.249.19.96] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e5c167sm134165345ad.1.2026.03.10.00.14.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 00:14:42 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 15:14:37 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: wangao.wang@oss.qualcomm.com, Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] media: iris: Add IRIS_BSE_HW_CLK handling in vpu3 power on/off sequence To: Dmitry Baryshkov References: <20260306-enable_iris_on_purwa-v2-0-75fa80a0a9e3@oss.qualcomm.com> <20260306-enable_iris_on_purwa-v2-3-75fa80a0a9e3@oss.qualcomm.com> Content-Language: en-US From: Wangao Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=SvmdKfO0 c=1 sm=1 tr=0 ts=69afc4e4 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=pVNGaCLpK0EqxE-sEXsA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: kn4ailZzAhv4u3IU8Nv8RCzB6qLGDc4t X-Proofpoint-ORIG-GUID: kn4ailZzAhv4u3IU8Nv8RCzB6qLGDc4t X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA1OSBTYWx0ZWRfX3O4DkUiBSj4U VuNLAKkcuncGiqPz3zud1VN0AjpUEEqX5yWsS3QvFv01k5BrGEQZHs2WqIuNhuEKRz47DGByTGw 9gPt9/sQVLimgb7+wuBjV8i78CHkOV5vxBMoLiROyaa78+uUaFQdSIazSCr8Ac0SZI+J8h7IXiz nXQTlZxHWpbvMRR6WiwhwkqXZLGqNPb5YVDBAq/8+MQKTSAyGjOoDRNLkDTc8c90OhZABh88aSs FUarZAUeHpqGQJAyZhAKVZD67CLhbmLFWIK/hgQ6P5xlm3vfsRHx2xLhkJsQvlQN34xe9Bj77mf nuI9Bm/o/M7O9ld7r0+oE9Mf6zNj98KYNEY4W2NskcBF8Kw26EmA4nqTyXVV96EgdN04G1XvmVL mzpy8856NNr2DzH3XSJPjXGLvKFW6uzFOGf1CaOLPoMQ2IHsioa+OIz53NB2lsGo26QOgQYIlj2 CFHbzW0BLu+u8fszUyQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100059 On 2026/3/10 7:58, Dmitry Baryshkov wrote: > On Fri, Mar 06, 2026 at 04:44:31PM +0800, Wangao Wang wrote: >> On X1P42100 the Iris block has an extra BSE clock. Wire this clock into >> the power on/off sequence. >> >> The BSE clock is used to drive the Bin Stream Engine, which is a sub-block >> of the video codec hardware responsible for bitstream-level processing. It >> is required to be enabled separately from the core clock to ensure proper >> codec operation. > > As far as I can see, Purwa is a one-off. Why are we forcing support for > the platform (and for the BSE clock) into the generic code? > >> So should I add a dedicated power on/off API for Purwa, and name it something like iris_vpu31_power_on_hw() / iris_vpu31_power_off_hw()? -- Best Regards, Wangao