From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFBD4C6FA8E for ; Wed, 21 Sep 2022 09:54:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230150AbiIUJy2 convert rfc822-to-8bit (ORCPT ); Wed, 21 Sep 2022 05:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230392AbiIUJxZ (ORCPT ); Wed, 21 Sep 2022 05:53:25 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D09D792F6C for ; Wed, 21 Sep 2022 02:52:06 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-323-s3vy6a1IM_qw-LkxN2iECw-1; Wed, 21 Sep 2022 10:52:03 +0100 X-MC-Unique: s3vy6a1IM_qw-LkxN2iECw-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Wed, 21 Sep 2022 10:52:01 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.040; Wed, 21 Sep 2022 10:52:01 +0100 From: David Laight To: 'Al Viro' , Jiangshan Yi <13667453960@163.com> CC: "akpm@linux-foundation.org" , "willy@infradead.org" , "linux-kernel@vger.kernel.org" , Jiangshan Yi Subject: RE: [PATCH] fs/efs/inode.c: use __func__ instead of function name Thread-Topic: [PATCH] fs/efs/inode.c: use __func__ instead of function name Thread-Index: AQHYzIdskrFLZR+H2ka5LnnQ208eAK3ppj5g Date: Wed, 21 Sep 2022 09:52:01 +0000 Message-ID: References: <20220919023314.3622391-1-13667453960@163.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro > Sent: 20 September 2022 01:24 > > On Mon, Sep 19, 2022 at 10:33:14AM +0800, Jiangshan Yi wrote: > > From: Jiangshan Yi > > > > It is better to use __func__ instead of function name. > > Why is it better? And why is it *not* sent to (active) > maintainers of fs/erofs? I'm not going to apply that behind their > backs and I would ask akpm to abstain from taking that one. It is distinctly worse. Anyone grepping the kernel source for the message text will fail to find it. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)