From: Helge Deller <deller@gmx.de>
To: Arnd Bergmann <arnd@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/22] [RESEND] parport: gsc: mark init function static
Date: Fri, 10 Nov 2023 08:47:28 +0100 [thread overview]
Message-ID: <c030e573-b350-4da3-9fc6-f62a00a53a25@gmx.de> (raw)
In-Reply-To: <20231108125843.3806765-6-arnd@kernel.org>
On 11/8/23 13:58, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This is only used locally, so mark it static to avoid a warning:
>
> drivers/parport/parport_gsc.c:395:5: error: no previous prototype for 'parport_gsc_init' [-Werror=missing-prototypes]
>
> Acked-by: Helge Deller <deller@gmx.de>
> Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Since the parport_gsc driver is only used on parisc machines,
I've added this patch to the parisc git tree.
Thanks!
Helge
> ---
> drivers/parport/parport_gsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parport/parport_gsc.c b/drivers/parport/parport_gsc.c
> index 5e4475254bd0..c7e18382dc01 100644
> --- a/drivers/parport/parport_gsc.c
> +++ b/drivers/parport/parport_gsc.c
> @@ -392,7 +392,7 @@ static struct parisc_driver parport_driver __refdata = {
> .remove = __exit_p(parport_remove_chip),
> };
>
> -int parport_gsc_init(void)
> +static int parport_gsc_init(void)
> {
> return register_parisc_driver(&parport_driver);
> }
next prev parent reply other threads:[~2023-11-10 19:40 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 12:58 [PATCH 00/22] -Wmissing-prototype warning fixes Arnd Bergmann
2023-11-08 12:58 ` [PATCH 01/22] [RESEND^2] ida: make 'ida_dump' static Arnd Bergmann
2023-11-08 12:58 ` [PATCH 02/22] [RESEND^2] jffs2: mark __jffs2_dbg_superblock_counts() static Arnd Bergmann
2023-11-09 1:07 ` Zhihao Cheng
2023-11-08 12:58 ` [PATCH 03/22] [RESEND] kprobes: unify kprobes_exceptions_nofify() prototypes Arnd Bergmann
2023-11-08 23:20 ` Masami Hiramatsu
2023-11-08 12:58 ` [PATCH 04/22] [RESEND] time: make sysfs_get_uname() function visible in header Arnd Bergmann
2023-11-10 12:41 ` Uwe Kleine-König
2023-11-22 13:19 ` [tip: timers/core] time: Make " tip-bot2 for Arnd Bergmann
2023-11-08 12:58 ` [PATCH 05/22] [RESEND] parport: gsc: mark init function static Arnd Bergmann
2023-11-10 7:47 ` Helge Deller [this message]
2023-11-08 12:58 ` [PATCH 06/22] [RESEND] stackleak: add declarations for global functions Arnd Bergmann
2023-11-08 19:07 ` (subset) " Kees Cook
2023-11-08 12:58 ` [PATCH 07/22] [RESEND] sched: fair: move unused stub functions to header Arnd Bergmann
2023-11-08 12:58 ` [PATCH 08/22] [v2] arch: consolidate arch_irq_work_raise prototypes Arnd Bergmann
2024-01-10 9:03 ` Geert Uytterhoeven
2024-01-10 10:20 ` Arnd Bergmann
2023-11-08 12:58 ` [PATCH 09/22] [v2] arch: fix asm-offsets.c building with -Wmissing-prototypes Arnd Bergmann
2023-11-08 19:10 ` Sam Ravnborg
2023-11-08 12:58 ` [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype Arnd Bergmann
2023-11-08 20:42 ` Geert Uytterhoeven
2023-11-08 21:07 ` Arnd Bergmann
2023-11-08 21:10 ` Geert Uytterhoeven
2023-11-08 12:58 ` [PATCH 11/22] x86: sta2x11: include header for sta2x11_get_instance() prototype Arnd Bergmann
2023-11-08 12:58 ` [PATCH 12/22] csky: fix arch_jump_label_transform_static override Arnd Bergmann
2023-11-12 4:21 ` Guo Ren
2023-11-08 12:58 ` [PATCH 13/22] arch: add do_page_fault prototypes Arnd Bergmann
2023-11-08 12:58 ` [PATCH 14/22] arch: add missing prepare_ftrace_return() prototypes Arnd Bergmann
2023-11-08 12:58 ` [PATCH 15/22] arch: vdso: consolidate gettime prototypes Arnd Bergmann
2023-11-08 18:31 ` Christophe Leroy
2023-11-08 19:37 ` Arnd Bergmann
2023-11-09 7:50 ` Christophe Leroy
2023-11-09 10:18 ` Michael Ellerman
2023-11-09 10:49 ` Christophe Leroy
2023-11-09 12:23 ` Michael Ellerman
2023-11-09 9:25 ` kernel test robot
2023-11-09 9:46 ` kernel test robot
2023-11-10 10:16 ` Vincenzo Frascino
2023-11-24 12:04 ` Mark Brown
2023-11-08 12:58 ` [PATCH 16/22] bcachefs: mark bch2_target_to_text_sb() static Arnd Bergmann
2023-11-08 20:19 ` Kent Overstreet
2023-11-08 12:58 ` [PATCH 17/22] powerpc: ps3: move udbg_shutdown_ps3gelic prototype Arnd Bergmann
2023-11-08 14:18 ` Geoff Levand
2023-11-08 15:10 ` Jakub Kicinski
2023-11-09 0:44 ` kernel test robot
2023-11-10 3:40 ` Michael Ellerman
2023-11-10 6:30 ` Arnd Bergmann
2023-11-13 9:46 ` Geert Uytterhoeven
2023-11-08 12:58 ` [PATCH 18/22] powerpc: pasemi: mark pas_shutdown() static Arnd Bergmann
2023-11-08 12:58 ` [PATCH 19/22] powerpc: powermac: mark smp_psurge_{give,take}_timebase static Arnd Bergmann
2023-11-08 12:58 ` [PATCH 20/22] usb: fsl-mph-dr-of: mark fsl_usb2_mpc5121_init() static Arnd Bergmann
2023-11-21 14:12 ` Greg Kroah-Hartman
2023-11-08 12:58 ` [PATCH 21/22] fbdev/fsl-diu-fb: mark wr_reg_wa() static Arnd Bergmann
2023-11-10 7:06 ` Helge Deller
2023-11-08 12:58 ` [PATCH 22/22] Makefile.extrawarn: turn on missing-prototypes globally Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c030e573-b350-4da3-9fc6-f62a00a53a25@gmx.de \
--to=deller@gmx.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®