mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	abdurrahman@nexthop.ai, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] spi: xilinx: use device property accessors.
Date: Fri, 23 Jan 2026 15:14:22 +0100	[thread overview]
Message-ID: <c0310e06-4a50-47e8-9de7-581eff6f53ec@amd.com> (raw)
In-Reply-To: <a979b1eb-87c9-4c08-8d30-0fe18ad07a26@sirena.org.uk>



On 1/23/26 13:40, Mark Brown wrote:
> On Fri, Jan 23, 2026 at 08:11:47AM +0100, Michal Simek wrote:
>> On 1/22/26 17:18, Andrew Lunn wrote:
>>> On Thu, Jan 22, 2026 at 09:00:29AM +0000, Abdurrahman Hussain via B4 Relay wrote:
> 
>>>> +		ret = device_property_read_u32(&pdev->dev,
>>>> +					       "xlnx,num-transfer-bits",
>>>> +					       &bits_per_word);
> 
>>> It could be my grep foo is broken, but there does not appear to be any
>>> users of xlnx,num-transfer-bits and xlnx,num-ss-bits. So it would be
>>> better to just remove them. There is no point Maintaining an API
>>> nobody uses. And it would be silly to spread that API to ACPI if
>>> nobody it going to use it.
> 
> There are no upstream users of this driver at all so obviously no use of
> the properties.

We are not wiring this driver in any DT because it is soft IP but it doesn't 
mean that it is not used.
But as you see Abdurrahman is able to use this driver is one configuration.
These properties are stable for years and well documented.

Thanks,
Michal

  reply	other threads:[~2026-01-23 14:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22  9:00 Abdurrahman Hussain via B4 Relay
2026-01-22 16:18 ` Andrew Lunn
2026-01-23  7:11   ` Michal Simek
2026-01-23 12:40     ` Mark Brown
2026-01-23 14:14       ` Michal Simek [this message]
2026-01-23 14:16         ` Mark Brown
2026-02-04 12:01 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0310e06-4a50-47e8-9de7-581eff6f53ec@amd.com \
    --to=michal.simek@amd.com \
    --cc=abdurrahman@nexthop.ai \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®