mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cui Chao <cuichao1753@phytium.com.cn>,
	Will Deacon <will@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Wang Yinfeng" <wangyinfeng@phytium.com.cn>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: PCI: Add linux,pci-domain-reuse property
Date: Wed, 4 Nov 2026 08:23:42 +0100	[thread overview]
Message-ID: <c0313537-532f-4c9c-86fb-067838829427@kernel.org> (raw)
In-Reply-To: <b49779cf-5132-4539-86c2-e4f806b1675d@phytium.com.cn>

On 03/11/2026 03:57, Cui Chao wrote:
> 
> On 11/2/2026 6:00 PM, Krzysztof Kozlowski wrote:
>> On 02/11/2026 10:51, Cui Chao wrote:
>>> Add a new optional boolean property 'linux,pci-domain-reuse' for PCI
>>> host bridges.
>>>
>>> By default, the 'linux,pci-domain' property must be unique across all
>>> host bridges. This property allows a host bridge to explicitly opt-out
>>> of this uniqueness check, permitting multiple host bridges to reuse the
>>> same software domain number.
>> Why isn't this deducible from the compatibles?
> Hi Krzysztof,
> 
> Thanks.
> 
> The compatible cannot express this. "pci-host-ecam-generic" only

You have vendor specific compatibles, no?

> describes how configuration space is accessed; it does not describe
> whether two host bridge instances may share one Linux PCI domain.
> 
> The same compatible is used on systems where every host bridge must
> have a unique domain and on this system where two RCs intentionally
> share a domain with disjoint bus ranges and resource windows.
> Comparing the compatible strings of the nodes therefore cannot
> distinguish our case.

OK, so let's look at your DTS - where is it posted for upstream?

> 
> Adding a vendor-specific compatible only to trigger this Linux policy
> would not describe a different hardware programming model either.
> What actually makes reuse valid is the platform-level relationship:
> the bus ranges and resource windows are disjoint.
> 
> If you prefer to avoid a new property, I can rework this to derive or
> validate reuse from the non-overlapping bus-range and resource layout
> instead. Would that be the preferred direction?
> 

This one is clear paste of LLM output to a message.


Best regards,
Krzysztof

  reply	other threads:[~2026-11-04  7:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  9:51 [RFC PATCH 0/2] Allow reusing PCI domain numbers in DT Cui Chao
2026-11-02  9:51 ` [PATCH 1/2] dt-bindings: PCI: Add linux,pci-domain-reuse property Cui Chao
2026-11-02 10:00   ` Krzysztof Kozlowski
2026-11-03  2:57     ` Cui Chao
2026-11-04  7:23       ` Krzysztof Kozlowski [this message]
2026-11-02  9:51 ` [PATCH 2/2] PCI: Allow reusing PCI domain numbers in DT Cui Chao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0313537-532f-4c9c-86fb-067838829427@kernel.org \
    --to=krzk@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=cuichao1753@phytium.com.cn \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=wangyinfeng@phytium.com.cn \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®