mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: chenjinghuang <chenjinghuang2@huawei.com>
To: "mingo@redhat.com" <mingo@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
	"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"bsegall@google.com" <bsegall@google.com>,
	"mgorman@suse.de" <mgorman@suse.de>,
	"vschneid@redhat.com" <vschneid@redhat.com>
Subject: Re: [RESEND] In cgroup v2, setting a smaller value for sched_rt_runtime_us fails.
Date: Fri, 27 Mar 2026 11:53:56 +0800	[thread overview]
Message-ID: <c03591cf-5064-462d-a9ad-5321727a9738@huawei.com> (raw)
In-Reply-To: <20260320013419.2493925-1-chenjinghuang2@huawei.com>

On 3/20/2026 9:34 AM, Chen Jinghuang wrote:
> For example:
> 
> 	# cat /proc/sys/kernel/sched_rt_runtime_us
> 	950000
> 	# echo 940000 > /proc/sys/kernel/sched_rt_runtime_us
> 	-bash: echo: write error: Invalid argument
> 
> This occurs because when the global RT quota is reduced while the root
> cgroup’s ratio remains unchanged, the root cgroup’s proportion ends up
> exceeding the global RT ratio. This is unreasonable: the root cgroup’s
> ratio should be updated when the global RT ratio changes.
> 
> This patch ensures the root cgroup’s RT quota is adjusted whenever the
> global RT quota is modified.
> 
> Signed-off-by: Chen Ridong <chenridong@huawei.com>
> Tested-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
> Reviewed-by: Chen Jinghuang <chenjinghuang2@huawei.com>
> ---
>  kernel/sched/rt.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index f1867fe8e5c5..30770ba7be4e 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -2814,9 +2814,11 @@ long sched_group_rt_period(struct task_group *tg)
>  static int sched_rt_global_constraints(void)
>  {
>  	int ret = 0;
> +	u64 period = global_rt_period();
> +	u64 runtime = global_rt_runtime();
>  
>  	mutex_lock(&rt_constraints_mutex);
> -	ret = __rt_schedulable(NULL, 0, 0);
> +	ret = __rt_schedulable(&root_task_group, period, runtime);
>  	mutex_unlock(&rt_constraints_mutex);
>  
>  	return ret;
> @@ -2856,6 +2858,14 @@ static int sched_rt_global_validate(void)
>  
>  static void sched_rt_do_global(void)
>  {
> +#ifdef CONFIG_RT_GROUP_SCHED
> +	if (!rt_group_sched_enabled())
> +		return;
> +
> +	WARN_ON_ONCE(tg_set_rt_bandwidth(&root_task_group,
> +					global_rt_period(),
> +					global_rt_runtime()));
> +#endif
>  }
>  
>  static int sched_rt_handler(const struct ctl_table *table, int write, void *buffer,
ping

  reply	other threads:[~2026-03-27  3:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20  1:34 Chen Jinghuang
2026-03-27  3:53 ` chenjinghuang [this message]
2026-04-20  4:03   ` chenjinghuang
  -- strict thread matches above, loose matches on Subject: below --
2026-02-26  3:38 Chen Jinghuang
2026-02-27  8:18 ` Chen Ridong
2026-02-11  2:12 Chen Jinghuang
2026-02-12  3:39 ` Madadi Vineeth Reddy
2026-02-08 10:29 Chen Jinghuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c03591cf-5064-462d-a9ad-5321727a9738@huawei.com \
    --to=chenjinghuang2@huawei.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®