From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752012AbdHEM05 (ORCPT ); Sat, 5 Aug 2017 08:26:57 -0400 Received: from mout.web.de ([217.72.192.78]:55870 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbdHEM0z (ORCPT ); Sat, 5 Aug 2017 08:26:55 -0400 Subject: [PATCH 1/4] atm: idt77252: Adjust four function calls together with a variable assignment From: SF Markus Elfring To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Sat, 5 Aug 2017 14:26:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:gLdkcavLiQFoDJkwRe+wEPbkC2pxzdgTtHsPb0+Iq+qQbKAPm/Z P0HcjUY2MIgLHhjkWwvve1yYkjDLhuufQWOAvQaDOvI7E7kkGRzPvZBb3db4rJQ15eIXKzJ 2W+X+7CkyCM4WlJPgceIxb5/K/yJrznLEBPyJBewVLef4K62P1ioovz9zMR1/9cblDWZt1+ lWAXx7jt79q06uaUQPE/g== X-UI-Out-Filterresults: notjunk:1;V01:K0:Fz9iKMJy4Bg=:qdNWA1L76Lz0XWk9r7TCFV IHZDYnpuzxl6jTmyONfw6g2d8gwmWODf8gHk0dVWL7dlcLrxz+6whY0ygtyO6pFsRP+JHWgUg dHkFipk+ys3qZGo0KWXLj0FCxokD2zKBhz6S/cu/ELvwwcXWQiDfe18LcsnuxV7uJhAGoUon8 anWsObjXqbQ4+ZyJ66epRWsLnjpOmpUrRDxFWpqanJJD6kzEGuLV9xwoHHdaKnvLgmsxjRdSY cSrO9XPUQNrG5bQrV5BlOAAV1Su0pbXBzSdNHabocyxONe/oJuHZDjqgacglv2zVSlfBjoB4Y tQyReZpzuQjt8AJ74CPtw37xW6OTqk2r2n9g4Pb8dze+yGrdU0RL627If3dkjn0OkMh9AL9d4 b/5MSIcjwmWNF+SBn+bSX469Gr281vdyLxrTNOSkk3zzQxop03yu/l75AH74vzWOffPu1jQM6 D/u1StcuuKwRMvk2+R4/a6jueM03fziW85w6Vj6qgpUvqVv3vG9Nwk7fR5eVJ2vOVlfrXpp3J HiP+iq1+8qk8qkbvKOYkctbqMSc2cDY7moyb/1hOCRJeUeSxQzm2KbJIHSPlKsLlGP2Fix6DA PgLYr/l5l/SUbTqgc3JCdS3e6VfIUfII77X30lUIzFr0dhTC3QhoPayvqXqorYXcoGM03uWKs wMB+bGrtVV1o43BhHWLsYqEp9ny9RJC/brDbIOS8fyrS7aXvtt48W5IFKI0yLi1mKgRljtjsT iSLFlU4xIqSSqqGrf+QI1+8xU6pOuXBK0dANSwZGNrlDb1yIzQL2x82tPQDw6Z/sodmwBr/jx HeU+BkNwb4YPdtfoJPNGktX9IH8zg4899PwOiOjQmTe02gD7RQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 4 Aug 2017 22:20:08 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/atm/idt77252.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index b7a168c46692..6a051f5909d0 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -1070,7 +1070,8 @@ dequeue_rx(struct idt77252_dev *card, struct rsq_entry *rsqe) cell = skb->data; for (i = (stat & SAR_RSQE_CELLCNT); i; i--) { - if ((sb = dev_alloc_skb(64)) == NULL) { + sb = dev_alloc_skb(64); + if (!sb) { printk("%s: Can't allocate buffers for aal0.\n", card->name); atomic_add(i, &vcc->stats->rx_drop); @@ -1304,7 +1305,8 @@ idt77252_rx_raw(struct idt77252_dev *card) goto drop; } - if ((sb = dev_alloc_skb(64)) == NULL) { + sb = dev_alloc_skb(64); + if (!sb) { printk("%s: Can't allocate buffers for AAL0.\n", card->name); atomic_inc(&vcc->stats->rx_err); @@ -3600,13 +3602,14 @@ static int idt77252_init_one(struct pci_dev *pcidev, struct atm_dev *dev; int i, err; - - if ((err = pci_enable_device(pcidev))) { + err = pci_enable_device(pcidev); + if (err) { printk("idt77252: can't enable PCI device at %s\n", pci_name(pcidev)); return err; } - if ((err = dma_set_mask_and_coherent(&pcidev->dev, DMA_BIT_MASK(32)))) { + err = dma_set_mask_and_coherent(&pcidev->dev, DMA_BIT_MASK(32)); + if (err) { printk("idt77252: can't enable DMA for PCI device at %s\n", pci_name(pcidev)); return err; } -- 2.13.4