From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC11F12BF24 for ; Sun, 5 Jan 2025 18:53:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736103211; cv=none; b=Lyr+Ta6xpwofl6uY5UzOEAlhgHARegAOk0qOtK+1TeIAxw/RDGRUllW/ntMcjG5u9pznkW6A+MXtsEl8Ggm6zzThw94Ks4O5BW4J5XzOzsSmrrjsKK5wCvn6yGmTMgyKn+cEghkQtkr5uFT4sA0uAE2G9enKnYjTTwihlSDr6Pg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736103211; c=relaxed/simple; bh=sZmaBqaG+qm+IXvu2H7QgW3iecZQLXY9YB4NaSFZnoM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PFHW3liG5RjIf4A4HAWSs05sSM+Wpav4v0TxPmZYiK9Wug05oEStXnz4r1hEvYQAQ3wOg18qgp0YUk1HZrqdHe5654kfiNDvLGfhhdBCwrBHQJn0Os2hTZPXSO9gfkSeTr+tBmPTDxrduhFrDNiygGcf0xMuaGK+P50xobNz11E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=ZRP3XaHn; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="ZRP3XaHn" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 505E7IbJ027986; Sun, 5 Jan 2025 18:52:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s=pp1; bh=7hViRt/vp5luLICtxKWXLSvyzMUti1UcjVgNHnUPME8=; b=ZRP3XaHnpgNG 2dWyxS6/Rtr+k07HAU0CdHjNDu5SgQM65zsB2b0aWY5hLvQwbFV/CTKFMeBnY1Yn ofAz3iAkDM+tUU2+bILlx+376M31vuipofupnbNEdBngseEjYNnoQ+dBY+IW0H+l ZmDqyxiphRpjjmE5jqZUo4o1ZeTFW6bQGZMP9OJj4Ze8/Mp5umBir0B8/P+PYxJM fUVyhY+N1oginOgLmojvBqZG9uv9+RhF2Jd7lvHusuTRbhxsN6unYsh8XdOCnyXM 3R107ib76kzU9qwNK4sfbRIj6ZsK4yBmhlVg5izQhMfSeNJHsWbZwcJH3JE/Azcy b4GLKnjbOA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43yuj50j0d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 05 Jan 2025 18:52:37 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 505IqbC3012473; Sun, 5 Jan 2025 18:52:37 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43yuj50j0b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 05 Jan 2025 18:52:37 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 505Hk2jJ008870; Sun, 5 Jan 2025 18:52:36 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43yfpyjsgb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 05 Jan 2025 18:52:36 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 505IqZg519595820 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 5 Jan 2025 18:52:35 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C641D58057; Sun, 5 Jan 2025 18:52:35 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8890D58059; Sun, 5 Jan 2025 18:52:29 +0000 (GMT) Received: from [9.43.108.122] (unknown [9.43.108.122]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Sun, 5 Jan 2025 18:52:28 +0000 (GMT) Message-ID: Date: Mon, 6 Jan 2025 00:22:26 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] sched/fair: Ignore isolated cpus in update_numa_stat Content-Language: en-US To: Chuyi Zhou Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, longman@redhat.com, riel@surriel.com, chengming.zhou@linux.dev, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org, Madadi Vineeth Reddy References: <20250103065930.413464-1-zhouchuyi@bytedance.com> <20250103065930.413464-3-zhouchuyi@bytedance.com> Reply-To: 20250103065930.413464-3-zhouchuyi@bytedance.com From: Madadi Vineeth Reddy In-Reply-To: <20250103065930.413464-3-zhouchuyi@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: eLKqKWJUxUkLSG1dpnSxxX-sSA--krIv X-Proofpoint-ORIG-GUID: 8-GJfv35EIkkNjCcUOyvbSm0gV36LBMY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501050172 On 03/01/25 12:29, Chuyi Zhou wrote: > Now update_numa_stats() iterates each cpu in a node to gather load > information for the node and attempts to find the idle cpu as a candidate > best_cpu within the node. > > In update_numa_stats() we should take into account the scheduling domain. > This is because the "isolcpus" kernel command line option and cpuset iso- > late partitions can remove CPUs from load balance. Similar to task wakeup > and periodic load balancing, we should not involve isolated CPUs in NUMA > balancing. When gathering load information for nodes, we need to ignore the > load of isolated CPUs. This change also avoids selecting an isolated CPU > as the idle_cpu. If possible, would you be able to share any performance metrics or benchmarks that demonstrate the impact of this patch on NUMA balancing or CPU migration efficiency? Thanks, Madadi Vineeth Reddy > > Signed-off-by: Chuyi Zhou > --- > kernel/sched/fair.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-)