From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA0FC43334 for ; Thu, 30 Jun 2022 08:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233632AbiF3Isz (ORCPT ); Thu, 30 Jun 2022 04:48:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233592AbiF3Isv (ORCPT ); Thu, 30 Jun 2022 04:48:51 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB8CB40E67 for ; Thu, 30 Jun 2022 01:48:49 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id n8so11636617eda.0 for ; Thu, 30 Jun 2022 01:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=KJ6oqzacpWT0tfg5DNbwZFGWq7BtF7yMtkVN7HxcDnk=; b=tNO+oZo9shQdh1rhNWDOTosr5geu8ztqOhGSN7j0kUgWKRvrTDNpKMMQTxwugbtmoO eTQkFwTN5/tFn8QUJ9KoVI+ocrRCGUBL00/1JEOeHcl8PW0KwQv/rvIJe4EgJ9vbbNDq 3YCN25Rm7P4ptDfHHe/qjx2zazpEJbfRq1r/Ud0YyjKBppd4eBph+AtNEGkqt20bU3pB AHiJoIOTXky5f8d6vG5gO6foGmgLQTNzQ9HB77R0gNExx6L3GKaebwFGQY3ZatD3hVYa BSfnovPSQAsQ+vn+kI8/vwt0vdt/brsr8BuVk27z4bOXYjlhTu+e82O16agQGYg7qd0N nrtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KJ6oqzacpWT0tfg5DNbwZFGWq7BtF7yMtkVN7HxcDnk=; b=vNnU5obcU8+pVptqCdyQFP3PXtFJUaLDbc0oCi92kVxTKsJZaA7gnEg15bTcXxArUK VpmEaQeEqfz9YKZIhKb5OYjlw8pTUdaOy6V7mi5c+i2DT0Eg8cPcuqfGySE21YZva5Zy ACsBeR3r3Cf6gdsqfYUc7tI/wZbpa8/FJU+zjY4FmRf+egVg9A8bHCCrvecbKPY5kOFt j/LAlet4olDzbvFr1CjurG5Nv0LFIsWEPHM5ahmFTC8e1OLn4go2wJhoR3Km2GtCwYVs DK9TF14gu1OPMlxe7HzpyNAvNTdDv4aasdAl+hQYX780k0IZw4tpovHBwm97ZcD0xuC8 GrFg== X-Gm-Message-State: AJIora8VYHwE1vfCK4OvpZ+hRSBX/UMB4GV0qfnJUjIChSvYTaQSbFAn zfiQa32Sl2bqYY9pw1g4+KAHUA== X-Google-Smtp-Source: AGRyM1sYlD7GgYsvG4haXeZ+OfvqtO8Fd9dImoUw0WI2NrSxwKr0gKtRg+uGeYRy9i0ZqtRk4XeXtQ== X-Received: by 2002:a05:6402:11d1:b0:435:d76d:f985 with SMTP id j17-20020a05640211d100b00435d76df985mr9900795edw.8.1656578928360; Thu, 30 Jun 2022 01:48:48 -0700 (PDT) Received: from [192.168.0.188] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id z4-20020a1709060f0400b00722f069fd40sm8714366eji.159.2022.06.30.01.48.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jun 2022 01:48:47 -0700 (PDT) Message-ID: Date: Thu, 30 Jun 2022 10:48:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 5/7] memory: renesas-rpc-if: Move resource acquisition to .probe() Content-Language: en-US To: Geert Uytterhoeven Cc: Vignesh Raghavendra , Sergey Shtylyov , Wolfram Sang , Lad Prabhakar , Miquel Raynal , Richard Weinberger , Mark Brown , MTD Maling List , Linux-Renesas , linux-spi , Linux Kernel Mailing List References: <2fd9b9e3f60fe555d9dcad499c90e3ec869aa96e.1656341824.git.geert+renesas@glider.be> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/06/2022 20:48, Geert Uytterhoeven wrote: >> >> You sure? Except rebasing I don't see that. rpcif_sw_init() received the >> rpcif so it had access to all fields. > > Yes I am, don't be misguided by the name of the local variable. > The rpcif structure is allocated by the HF or SPI child driver, > and thus not available in the RPC core driver's .probe() function. > The rpc_priv structure (as of patch 4) is allocated by the RPC core driver. > >>> I agree patches 1-3 could be moved later, if you think it is worthwhile. >> >> This would not be enough, it has to be first patch to be backportable. > > I can make it second? ;-) Why? The point is that this commit should have Fixes or Cc-stable tag. If you make it depending on other non-backportable commit, stable folks cannot pull it automatically. > Note that that still precludes (easily) backporting s2ram support. But S2R is a feature so it won't be backported... Best regards, Krzysztof